Merge pull request #10698 from Johnetordoff/fix-self-link-on-pp-insti…

…tutions Fix Self Link for Preprint Affiliated Institutions
CenterForOpenScience · Aug 8, 2024 · a362241 · a362241
2 parents 2965d17 + 2e4e47d
commit a362241
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/api/preprints/serializers.py b/api/preprints/serializers.py
@@ -209,7 +209,7 @@ class PreprintSerializer(TaxonomizableSerializerMixin, MetricsSerializerMixin, J
  affiliated_institutions = RelationshipField(
  related_view='preprints:preprints-institutions',
  related_view_kwargs={'preprint_id': '<_id>'},
- self_view='preprints:preprints-institutions',
+ self_view='preprints:preprint-relationships-institutions',
  self_view_kwargs={'preprint_id': '<_id>'},
  read_only=False,
  required=False,

diff --git a/api_tests/preprints/views/test_preprint_detail.py b/api_tests/preprints/views/test_preprint_detail.py
@@ -229,6 +229,8 @@ def test_return_affiliated_institutions(self, app, user, preprint, institution,
  assert res.status_code == 200
  relationship_link = res.json['data']['relationships']['affiliated_institutions']['links']['related']['href']
  assert f'/v2/preprints/{preprint._id}/institutions/' in relationship_link
+ relationship_link = res.json['data']['relationships']['affiliated_institutions']['links']['self']['href']
+ assert f'/v2/preprints/{preprint._id}/relationships/institutions/' in relationship_link
 
 
 @pytest.mark.django_db

diff --git a/api_tests/preprints/views/test_preprint_list.py b/api_tests/preprints/views/test_preprint_list.py
@@ -197,7 +197,8 @@ def test_return_affiliated_institutions(self):
  assert res.content_type == 'application/vnd.api+json'
  relationship_link = res.json['data'][0]['relationships']['affiliated_institutions']['links']['related']['href']
  assert f'/v2/preprints/{self.preprint._id}/institutions/' in relationship_link
-
+ relationship_link = res.json['data'][0]['relationships']['affiliated_institutions']['links']['self']['href']
+ assert f'/v2/preprints/{self.preprint._id}/relationships/institutions/' in relationship_link
 
 class TestPreprintsListFiltering(PreprintsListFilteringMixin):