Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] recatalog metadata async #10440

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Aug 16, 2023

Purpose

speedier manage.py recatalog_metadata

Changes

call task__update_share.apply_async instead of update_share

(because framework.celery_tasks.handlers.enqueue_task is a lie when called outside a request context (instead runs synchronously) -- is sometimes convenient, but not in this case)

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

@aaxelb aaxelb changed the base branch from develop to feature/search-improvements-2023 August 16, 2023 14:49
@mfraezz mfraezz merged commit 49bca21 into CenterForOpenScience:feature/search-improvements-2023 Aug 16, 2023
6 checks passed
mfraezz added a commit that referenced this pull request Aug 22, 2023
* OSFMAP Search Improvements (#10386)
* [ENG-4618] User Search metadata (#10428)
* [fixes] Search Improvement tests (#10432)
* Fix Search Improvement test (#10435)
* [Fix] Filterable "resourceNature" (#10434)
* Add Withdrawal metadata to SHARE (#10430)
* [ENG-4617] Send File Metadata to SHARE (#10436)
* Fix: Skip sending non-provider collections to SHARE (#10439)
* Optimize recatalog_metadata via celery (#10440)
* fix: send utf-8 to shtrove (#10437)
* [fix] Search/Metadata back-compat and fixes (#10443)
* [fix] Add missing registration component metadata (#10444)
* d42708e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants