-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't Merge] [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation #10646
Draft
Johnetordoff
wants to merge
12
commits into
CenterForOpenScience:feature/preprints-affiliations
Choose a base branch
from
Johnetordoff:institutional-affilation-clean-up
base: feature/preprints-affiliations
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
Allow institutional Affiliations for Preprints
[WIP] Allow institutional Affiliations for Preprints
Jun 21, 2024
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
3 times, most recently
from
June 21, 2024 17:56
f6f096e
to
902e29e
Compare
Johnetordoff
commented
Jun 21, 2024
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
from
June 21, 2024 18:06
902e29e
to
73f6285
Compare
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
from
June 21, 2024 19:36
73f6285
to
827c4d1
Compare
cslzchen
changed the title
[WIP] Allow institutional Affiliations for Preprints
[ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation
Jun 21, 2024
cslzchen
changed the title
[ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation
[Don't Merge] [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation
Jun 21, 2024
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
13 times, most recently
from
June 24, 2024 18:48
82fb215
to
889ae38
Compare
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
from
June 24, 2024 18:57
889ae38
to
6d7b532
Compare
…m/CenterForOpenScience/osf.io into institutional-affilation-clean-up * 'institutional-affilation-clean-up' of https://github.com/CenterForOpenScience/osf.io: Change PATCH to PUT request add institution relationship view add test for Preprint detail affiliation updates add stuff to allow institutional affiliations for Preprints # Conflicts: # api/preprints/permissions.py # api/preprints/serializers.py # api/preprints/urls.py # api/preprints/views.py
…m/CenterForOpenScience/osf.io into institutional-affilation-clean-up * 'institutional-affilation-clean-up' of https://github.com/CenterForOpenScience/osf.io: Change PATCH to PUT request add institution relationship view add test for Preprint detail affiliation updates add stuff to allow institutional affiliations for Preprints # Conflicts: # api/preprints/permissions.py # api/preprints/serializers.py # api/preprints/urls.py # api/preprints/views.py
…m/CenterForOpenScience/osf.io into institutional-affilation-clean-up * 'institutional-affilation-clean-up' of https://github.com/CenterForOpenScience/osf.io:
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
from
June 27, 2024 15:23
ce94220
to
e0fa094
Compare
…ohnetordoff/osf.io into institutional-affilation-clean-up * 'preprint-institutions-list-api' of https://github.com/johnetordoff/osf.io: add preprint institution affiliation endpoint # Conflicts: # api/preprints/permissions.py # api/preprints/serializers.py # api/preprints/urls.py # api/preprints/views.py # api_tests/preprints/views/test_preprint_institutions.py
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
2 times, most recently
from
June 27, 2024 16:18
15fddb5
to
9329d9a
Compare
Johnetordoff
changed the base branch from
develop
to
feature/preprints-affiliations
June 27, 2024 16:19
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
3 times, most recently
from
July 1, 2024 15:10
db08f37
to
e97f67d
Compare
Johnetordoff
force-pushed
the
institutional-affilation-clean-up
branch
from
July 1, 2024 15:40
e97f67d
to
832f24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prototype institutional Affiliation changes for Preprints
Changes
filterable_fields
[Ask about product this]affiliated_institutions
relationship fieldPreprintsInstitutionsSerializer
AffiliatedInstitutionMixin
to preprint and override to avoid related name conflictQuestions
affiliated_institutions
To do:
update_institutional_affiliation
update_IA
logo
field?/relationship
non-relationship
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
N/A
Side Effects
N/A
Ticket
Part of https://openscience.atlassian.net/browse/ENG-5826