Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Merge] [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation #10646

Draft
wants to merge 12 commits into
base: feature/preprints-affiliations
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Jun 21, 2024

Purpose

⚠️ While this seems to cover a lot it does not contain permissions changes or SHARE updates

Prototype institutional Affiliation changes for Preprints

Changes

  • add affilations to filterable_fields [Ask about product this]
  • create affiliated_institutions relationship field
  • add update method for affiliated_institutions and use that in PreprintsInstitutionsSerializer
  • add PreprintInstitutionsList realtionship view
  • add AffiliatedInstitutionMixin to preprint and override to avoid related name conflict
  • add tests

Questions

  • Do we want for filter on affiliated_institutions

To do:

  • InstitutionList write permissions? ensure they are nuanced and correct
  • More test cases, remove a single institution, add a few.
  • add Preprint model tests for update_institutional_affiliation
  • Model based tests for update_IA
  • logo field?
  • DELETE ?
  • /relationship non-relationship

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

N/A

Side Effects

N/A

Ticket

Part of https://openscience.atlassian.net/browse/ENG-5826

@Johnetordoff Johnetordoff changed the title Allow institutional Affiliations for Preprints [WIP] Allow institutional Affiliations for Preprints Jun 21, 2024
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch 3 times, most recently from f6f096e to 902e29e Compare June 21, 2024 17:56
api/base/parsers.py Outdated Show resolved Hide resolved
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch from 902e29e to 73f6285 Compare June 21, 2024 18:06
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch from 73f6285 to 827c4d1 Compare June 21, 2024 19:36
@cslzchen cslzchen changed the title [WIP] Allow institutional Affiliations for Preprints [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation Jun 21, 2024
@cslzchen cslzchen changed the title [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation [Don't Merge] [ENG-5826] Proof-of-Concept / Analysis: Preprints Institution Affiliation Jun 21, 2024
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch 13 times, most recently from 82fb215 to 889ae38 Compare June 24, 2024 18:48
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch from 889ae38 to 6d7b532 Compare June 24, 2024 18:57
John Tordoff added 2 commits June 25, 2024 10:46
…m/CenterForOpenScience/osf.io into institutional-affilation-clean-up

* 'institutional-affilation-clean-up' of https://github.com/CenterForOpenScience/osf.io:
  Change PATCH to PUT request
  add institution relationship view
  add test for Preprint detail affiliation updates
  add stuff to allow institutional affiliations for Preprints

# Conflicts:
#	api/preprints/permissions.py
#	api/preprints/serializers.py
#	api/preprints/urls.py
#	api/preprints/views.py
John Tordoff added 3 commits June 26, 2024 13:56
…m/CenterForOpenScience/osf.io into institutional-affilation-clean-up

* 'institutional-affilation-clean-up' of https://github.com/CenterForOpenScience/osf.io:
  Change PATCH to PUT request
  add institution relationship view
  add test for Preprint detail affiliation updates
  add stuff to allow institutional affiliations for Preprints

# Conflicts:
#	api/preprints/permissions.py
#	api/preprints/serializers.py
#	api/preprints/urls.py
#	api/preprints/views.py
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch from ce94220 to e0fa094 Compare June 27, 2024 15:23
…ohnetordoff/osf.io into institutional-affilation-clean-up

* 'preprint-institutions-list-api' of https://github.com/johnetordoff/osf.io:
  add preprint institution affiliation endpoint

# Conflicts:
#	api/preprints/permissions.py
#	api/preprints/serializers.py
#	api/preprints/urls.py
#	api/preprints/views.py
#	api_tests/preprints/views/test_preprint_institutions.py
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch 2 times, most recently from 15fddb5 to 9329d9a Compare June 27, 2024 16:18
@Johnetordoff Johnetordoff changed the base branch from develop to feature/preprints-affiliations June 27, 2024 16:19
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch 3 times, most recently from db08f37 to e97f67d Compare July 1, 2024 15:10
@Johnetordoff Johnetordoff force-pushed the institutional-affilation-clean-up branch from e97f67d to 832f24c Compare July 1, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant