[ENG-5845] Preprint Institutions Relationship #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the base branch from
develop
to
feature/preprints-affiliations
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
from
27db54a
to
60bfb27
Compare
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
2 times, most recently
from
660d92d
to
e3425bf
Compare
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
from
e3425bf
to
07bf405
Compare
Johnetordoff
changed the title
Johnetordoff
changed the title
…enterForOpenScience/osf.io into preprint-insetitutions-relationship-list-api * 'feature/preprints-affiliations' of https://github.com/CenterForOpenScience/osf.io: remove literal string permissions add docstring to explain permission improve preprint tests by creating 404 case improve permissions by dropping unsafe method behavior remove vestigial serializer # Conflicts: # api/preprints/permissions.py # api/preprints/serializers.py # api/preprints/views.py # api_tests/preprints/views/test_preprint_institutions.py
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
from
55f6105
to
268d5c6
Compare
Johnetordoff
changed the title
Johnetordoff
commented
Jul 5, 2024
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
from
eff1e35
to
164aa66
Compare
Johnetordoff
force-pushed
the
preprint-insetitutions-relationship-list-api
branch
from
c54fbb1
to
8adc2df
Compare
cslzchen
requested changes
Jul 16, 2024
Johnetordoff
changed the title
cslzchen
approved these changes
Jul 17, 2024
cslzchen
reviewed
Jul 18, 2024
cslzchen
merged commit 231b478
into
CenterForOpenScience:feature/preprints-affiliations
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To transfer
NodeInstitutionsRelationshipListlogic to Preprints from nodes with adjoining classes.Changes
WriteOrPublicForRelationshipInstitutionsis moved and refactored from being exclusively for nodes into a all resourcesNodeInstitutionsRelationshipListview toPreprintInstitutionsRelationshipListNodeInstitutionsRelationshipSerializertoPreprintsInstitutionsRelationshipSerializerTODO
update_institutionsto baseQA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-5845