Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-4903] Fixes issue with email confirmation links failing due to database congestion #10662

Merged
merged 8 commits into from
Jul 17, 2024
Merged

[ENG-4903] Fixes issue with email confirmation links failing due to database congestion #10662

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ab64e3
fix: move send_confirmation_email to post-commit task
Jul 9, 2024
269f8b2
Move send_confirm_email logic to framework/auth/views
Jul 9, 2024
e1d6ac2
Fix argument passing in enqueue_postcommit_task call in send_confirm_…
Jul 9, 2024
b914119
Fix argument passing in enqueue_postcommit_task call in send_confirm_…
Jul 9, 2024
f287c8d
Fix argument passing in enqueue_postcommit_task call in send_confirm_…
Jul 10, 2024
1722d9f
Refactor: Separate send_confirm_email task for post-commit execution
Jul 16, 2024
a744968
Refactor: Separate send_confirm_email task for post-commit execution
Jul 16, 2024
db710c0
Refactor: Separate send_confirm_email task for post-commit execution
Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion api/users/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@
from api.base.schemas.utils import validate_user_json, from_json
from framework.auth.views import send_confirm_email
from api.base.versioning import get_kebab_snake_case_field
from framework.postcommit_tasks.handlers import enqueue_postcommit_task


def send_confirmation_email_task(user_id, email):
from framework.auth import get_user
user = get_user(user_id)
send_confirm_email(user, email=email)


class SocialField(ser.DictField):
Expand Down Expand Up @@ -596,7 +603,7 @@ def create(self, validated_data):
token = user.add_unconfirmed_email(address)
user.save()
if CONFIRM_REGISTRATIONS_BY_EMAIL:
send_confirm_email(user, email=address)
enqueue_postcommit_task(send_confirmation_email_task, user.id, address)
cslzchen marked this conversation as resolved.
Show resolved Hide resolved
user.email_last_sent = timezone.now()
user.save()
except ValidationError as e:
Expand Down
Loading