fix: waffle flags in flask context #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(use `api.waffle.utils.flag_is_active`, not `waffle.flag_is_active`)
aaxelb
force-pushed
the
fix/gv-waffle
branch
2 times, most recently
from
8346ae2
to
366e108
Compare
jwalz
merged commit 106994b
into
CenterForOpenScience:feature/gravy_valet_integration
6 checks passed
jwalz
pushed a commit
to jwalz/osf.io
that referenced
this pull request
Jul 16, 2024
* fix: waffle flags in flask context
jwalz
pushed a commit
to jwalz/osf.io
that referenced
this pull request
Jul 25, 2024
* fix: waffle flags in flask context
jwalz
pushed a commit
to jwalz/osf.io
that referenced
this pull request
Jul 25, 2024
* fix: waffle flags in flask context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
correct checking of waffle-flags on flask requests
Changes
api.waffle.utils.flag_is_active, notwaffle.flag_is_activeapi.waffle.utils.flag_is_activeto work for either flask or django requestQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket