[ENG-2562] Fix Source Tags for Users #10696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
fix-source-tags
branch
5 times, most recently
from
9786736
to
4efe8a4
Compare
cslzchen
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for the quick work, looks good overall 🎆
One requested change is correctly handle tags secondary institution.
In addition, need to check (probably with @brianjgeiger) if the tags we added here make sense.
Finally, need to check (probably with Product folks) if existing user should be tagged with institution when they get affiliated.
|
I do not have a preference on the source tag names. Product uses them, so if there's going to be a preference, they'll have it. My guess is they won't be too fussy as long as they are distinct enough. |
|
You guessed right.
…On Mon, Aug 12, 2024 at 3:27 PM Brian J. Geiger ***@***.***> wrote:
I do not have a preference on the source tag names. Product uses them, so
if there's going to be a preference, they'll have it. My guess is they
won't be too fussy as long as they are distinct enough.
—
Reply to this email directly, view it on GitHub
<#10696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZE6KAUOKBNYYYYFATPZA3ZREEDRAVCNFSM6AAAAABMGSBBDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUG42TKMBWGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
cslzchen
requested changes
Aug 12, 2024
cslzchen
approved these changes
Aug 13, 2024
|
@Johnetordoff Could you rebase and target the b&i branch for this? |
Johnetordoff
force-pushed
the
fix-source-tags
branch
2 times, most recently
from
497424e
to
0aadaee
Compare
Johnetordoff
force-pushed
the
fix-source-tags
branch
from
0aadaee
to
b18fdfe
Compare
brianjgeiger
merged commit 9d02957
into
CenterForOpenScience:feature/b-and-i-24-14
6 checks passed
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 21, 2024
…penScience/osf.io into fix-preprint-emails * 'feature/b-and-i-24-14' of https://github.com/CenterForOpenScience/osf.io: Make resubmissions more like submissions (CenterForOpenScience#10709) renamed files with travis in their names fixed case where it was more appropriate removed all travis mentions and replaced them with CI [ENG-2562] add system tags to users created via institutional sign up system (CenterForOpenScience#10696) refactor handle_duplicate_notifications and add tests Shorten lines; rename script for test clarity fix flake8 errors add admin screen to manage duplicate notifications [ENG-2814] Allow Read-only and Read/Write contributors to view a project's draft registrations (CenterForOpenScience#10660) [CR][ENG-5997] merge develop into b-and-i branch (CenterForOpenScience#10691) add exception handling in case state doesn't change [ENG-4527] Fix citation to use registered date (CenterForOpenScience#10678) restrict state changes more and allow no-ops split apart change provider views from general preprint view and machine_state change viewa Re-add permissions changes for files on withdrawn registrations (CenterForOpenScience#10671) [ENG-4903] Fixes issue with email confirmation links failing due to database congestion (CenterForOpenScience#10662) # Conflicts: # osf/utils/notifications.py # website/templates/emails/reviews_resubmission_confirmation.html.mako
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 21, 2024
…penScience/osf.io into fix-preprint-emails * 'feature/b-and-i-24-14' of https://github.com/CenterForOpenScience/osf.io: Make resubmissions more like submissions (CenterForOpenScience#10709) renamed files with travis in their names fixed case where it was more appropriate removed all travis mentions and replaced them with CI [ENG-2562] add system tags to users created via institutional sign up system (CenterForOpenScience#10696) refactor handle_duplicate_notifications and add tests Shorten lines; rename script for test clarity fix flake8 errors add admin screen to manage duplicate notifications [ENG-2814] Allow Read-only and Read/Write contributors to view a project's draft registrations (CenterForOpenScience#10660) [CR][ENG-5997] merge develop into b-and-i branch (CenterForOpenScience#10691) add exception handling in case state doesn't change [ENG-4527] Fix citation to use registered date (CenterForOpenScience#10678) restrict state changes more and allow no-ops split apart change provider views from general preprint view and machine_state change viewa Re-add permissions changes for files on withdrawn registrations (CenterForOpenScience#10671) [ENG-4903] Fixes issue with email confirmation links failing due to database congestion (CenterForOpenScience#10662) # Conflicts: # osf/utils/notifications.py # website/templates/emails/reviews_resubmission_confirmation.html.mako
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds source tags to users created via email invitation or sso.
Changes
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-2562