[ENG-6094] Poetry won't install deps properly in when venv is inside project root #10697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Aug 8, 2024
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 12, 2024
into fix-source-tags * 'develop' of https://github.com/CenterForOpenScience/osf.io: Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697)
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 13, 2024
into add-more-spam-metrics * 'develop' of https://github.com/CenterForOpenScience/osf.io: (173 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ...
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 13, 2024
into clean-up-preprint-permissions * 'develop' of https://github.com/CenterForOpenScience/osf.io: Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697)
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 21, 2024
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 21, 2024
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 22, 2024
into institutional-dashboard * 'develop' of https://github.com/CenterForOpenScience/osf.io: (41 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ... # Conflicts: # api/users/serializers.py # conftest.py
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 22, 2024
into institutional-dashboard * 'develop' of https://github.com/CenterForOpenScience/osf.io: (41 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ... # Conflicts: # api/users/serializers.py # conftest.py
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 22, 2024
into institutional-dashboard * 'develop' of https://github.com/CenterForOpenScience/osf.io: (41 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ... # Conflicts: # api/users/serializers.py # conftest.py
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 22, 2024
into institutional-dashboard * 'develop' of https://github.com/CenterForOpenScience/osf.io: (41 commits) Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests update dataverse dep revision to get changes Update CHANGELOG, bump version [CR][ENG-5681] Great Big Python Upgrade (CenterForOpenScience#10648) Revert "[ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650)" (CenterForOpenScience#10666) Check Registration READ perms on the Registration - Do not record download metrics for renders Fix signature Allow DOI metadata updates to be queued [ENG-3685] Add permissions for withdrawn registration files (CenterForOpenScience#10650) Update CHANGELOG, bump version [ENG-5030] Preprints Phase 2 - BE (CenterForOpenScience#10617) Update CHANGELOG, bump version Ensure Assumed-HAM users do not get autobanned [ENG-5762] Get GV set up in osf docker configs (CenterForOpenScience#10643) ... # Conflicts: # api/users/serializers.py # conftest.py
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Aug 23, 2024
into remove-quickfiles-code * 'develop' of https://github.com/CenterForOpenScience/osf.io: Hotfixes for: double-encoded urls + dep upgrades fixed docker-compose requirements for local setups with venv inside project root (CenterForOpenScience#10697) use correct version of module for metrics update Dockerfile for recent lints remove deprecated version stanza from docker-composes update reqs to pull from github commit shas correct body location for api.ia POST requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix devenv setup for people who use virtualenv inside project root in conjuction with docker-compose
Changes
Changed mount for
docker-composerequirementsserviceQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
ENG-6094