Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3 Improvements] More WB Path Fixes #409

Merged

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Aug 8, 2023

Ticket

Purpose

Ensure relative paths work properly for s3.

Changes

Side effects

QA Notes

Deployment Notes

@Johnetordoff Johnetordoff changed the base branch from develop to feature/s3-improvements August 8, 2023 20:16
@Johnetordoff Johnetordoff force-pushed the api-tweak branch 3 times, most recently from 98d6906 to 775b176 Compare August 9, 2023 12:57
@Johnetordoff Johnetordoff changed the title [WIP] WB S3 Improvement Path Fixes WB S3 Improvement Path Fixes Aug 9, 2023
@Johnetordoff Johnetordoff force-pushed the api-tweak branch 3 times, most recently from 146d598 to 75979e3 Compare August 9, 2023 17:10
@felliott
Copy link
Member

felliott commented Aug 9, 2023

@Johnetordoff, see #406 (comment) for advice on how to proceed with this.

@coveralls
Copy link

coveralls commented Aug 9, 2023

Coverage Status

coverage: 88.925% (-0.09%) from 89.016% when pulling 7035d09 on Johnetordoff:api-tweak into e627806 on CenterForOpenScience:feature/s3-improvements.

@Johnetordoff Johnetordoff force-pushed the api-tweak branch 5 times, most recently from 3c764e0 to 4dea92c Compare August 10, 2023 13:05
@Johnetordoff Johnetordoff marked this pull request as ready for review August 10, 2023 17:45
@cslzchen cslzchen changed the title WB S3 Improvement Path Fixes [S3 Improvements] WB S3 Improvement Path Fixes Aug 16, 2023
@cslzchen cslzchen changed the title [S3 Improvements] WB S3 Improvement Path Fixes [S3 Improvements] More WB Path Fixes Aug 16, 2023
@cslzchen cslzchen merged commit 7683994 into CenterForOpenScience:feature/s3-improvements Aug 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants