Remove "Frequency" from the option list #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear Chuck,
Thanks for looking into this!
Frequency doesn’t make sense in the sunpath diagram.
It should remain in the drop-down for the psychrometric chart. I believe the issue is that all the drop-down at the moment share the same list
Best,
Giovanni
On 3. Dec 2023, at 00:08, Chuck McCallum ***@***.***> wrote:
Discussion<#176 (comment)> suggests it makes sense just not to show this option?
…________________________________
You can view, comment on, or merge this pull request online at:
#218
Commit Summary
* e81207b<e81207b> Remove "Frequency" from the option list
File Changes
(1 file<https://github.com/CenterForTheBuiltEnvironment/clima/pull/218/files>)
* M my_project/tab_sun/app_sun.py<https://github.com/CenterForTheBuiltEnvironment/clima/pull/218/files#diff-c57cbdaab847b6f81a07f9d1a002fb5402d6165501a806c27f057916527af4f3> (1)
Patch Links:
* https://github.com/CenterForTheBuiltEnvironment/clima/pull/218.patch
* https://github.com/CenterForTheBuiltEnvironment/clima/pull/218.diff
—
Reply to this email directly, view it on GitHub<#218>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIWZJADMOOR7YUHL6HL3IRDYHOYE3AVCNFSM6AAAAABAEKHGA6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDEMRUG44TINY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
FedericoTartarini
approved these changes
Dec 5, 2023
FedericoTartarini
merged commit 4560f5b
into
CenterForTheBuiltEnvironment:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion suggests it makes sense just not to show this option?