build: use now-stable async traits #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisCraft
force-pushed
the
stable-async-traits
branch
from
02fc2bb
to
f9eb0d5
Compare
JarvisCraft
force-pushed
the
stable-async-traits
branch
from
8fa18e7
to
f9d3f71
Compare
JarvisCraft
force-pushed
the
stable-async-traits
branch
3 times, most recently
from
4f5cac2
to
50ba7d7
Compare
CertainLach
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the usage of now-stable
async fns intraits.While
1.75is not released yet, it is still okay for us to use this version since the specific crate feature is opt-in. The key factor here is that we don't need nightly#[feature]s for this to work.