Only issue a warning for channel mismatches #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the validator made the assumption that image channels have 8 bits. This means that when someone tried to represent, for example, a 16-bit value in a property texture with a single channel, then the validator generated an
ERROR
with typeTEXTURE_CHANNELS_OUT_OF_RANGE
.There still are some open questions about the handling of non-8-bit channels in images. Some thoughts and discussion are tracked in CesiumGS/3d-tiles#748 . But for now, the validator should not claim that assets that contain images with 16-bit channels are "invalid". So this PR changes the former
ERROR
in these cases into aWARNING
with the typeTEXTURE_CHANNELS_SIZE_MISMATCH
.The issue will therefore be reported as
but the asset will still be considered to be valid.