-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs + gh pages deploy #1
Conversation
Thanks for the docs setup! :) |
@Ceyron I think you need to set the Pages source to "GitHub Actions" in the repo settings for the deploy to work |
But this will make the documentation public already, doesn't it? |
No, GH Pages on private repos is private as well (only people with read access to the repo can see it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dionhaefner, I have a question regarding the Python module system: What was the reason for excluding the submodules from all? Now the import via import exponax; exponax.normalized.XXX
does no longer work.
Did you re-run |
In other experiment folders, I just use the repo as a separate folder from which I import (no installation). In these cases, the import no longer works. |
There's your problem :) You can add the imports back, it doesn't hurt (just unnecessary in a sane setup). |
I used Equinox as inspiration for this: https://github.com/patrick-kidger/equinox/blob/main/equinox/__init__.py I also tried the module structure with installation (i.e., what you added with the PR). In these cases, I can do the following from exponax import stepper
diffusions_stepper = stepper.Diffusion(1, 3.0, 50, 0.1) but the following does not work: import exponax as ex
diffusions_stepper = ex.stepper.Diffusion(1, 3.0, 50, 0.1) Probably, there are proper names for both importing strategies. I would like the latter, which seemingly only works when I have the submodule export in the top-level Or did I do anything incorrectly? For installation, I cloned the repo, cd'ed into the directory, and ran |
True, if you never import So yea just add the submodule imports back here if you explicitly want to support that use case. |
A stub for docs to get you going. Will be deployed to GH pages whenever a PR is merged into
main
.