Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: type safe metric labels #278

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 3, 2024

See ChainSafe/lodestar#6201 for motivation / rationale

@nflaig nflaig requested a review from a team as a code owner January 3, 2024 10:06
@nflaig nflaig changed the title refactor: type safe metric labels feat: type safe metric labels Jan 3, 2024
@nflaig nflaig force-pushed the nflaig/type-safe-metric-labels branch from ad27025 to 560ea8b Compare January 3, 2024 10:16
@nflaig nflaig changed the title feat: type safe metric labels chore: type safe metric labels Jan 3, 2024
@nflaig nflaig changed the title chore: type safe metric labels feat: type safe metric labels Jan 3, 2024
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wemeetagain wemeetagain merged commit acb4792 into master Jan 3, 2024
8 checks passed
@wemeetagain wemeetagain deleted the nflaig/type-safe-metric-labels branch January 3, 2024 14:45
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants