Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc tests on demand #4242

Merged
merged 1 commit into from
Apr 22, 2024
Merged

rpc tests on demand #4242

merged 1 commit into from
Apr 22, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Apr 19, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • introduces a cron/on-demand workflow to spawn 100 parallel RPC tests in order to flush out flakiness from the Forest's RPC world.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the rpc-tests-on-demand branch 4 times, most recently from 86cf2aa to 03bd5d5 Compare April 19, 2024 10:19
hanabi1224
hanabi1224 reviewed Apr 19, 2024
View reviewed changes
.github/workflows/composite/rpc_test/action.yml Outdated
timeout-minutes: 30
env:
# We use a custom Dockerfile for CI to speed up the build process.
FOREST_DOCKERFILE_OVERRIDE: scripts/devnet/forest_ci.dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this can be made an input, we can use edge-fat tag for non-PR runs

@LesnyRumcajs LesnyRumcajs force-pushed the rpc-tests-on-demand branch 13 times, most recently from 93ce5e9 to 495120e Compare April 22, 2024 10:08
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review April 22, 2024 10:08
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 22, 2024 10:08
@LesnyRumcajs LesnyRumcajs requested review from elmattic and aatifsyed and removed request for a team April 22, 2024 10:08
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 22, 2024
@LesnyRumcajs LesnyRumcajs removed this pull request from the merge queue due to a manual request Apr 22, 2024
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 22, 2024
@LesnyRumcajs LesnyRumcajs removed this pull request from the merge queue due to a manual request Apr 22, 2024
@LesnyRumcajs LesnyRumcajs enabled auto-merge April 22, 2024 10:40
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 3645e3c Apr 22, 2024
27 checks passed
@LesnyRumcajs LesnyRumcajs deleted the rpc-tests-on-demand branch April 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatifsyed aatifsyed aatifsyed approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LesnyRumcajs @hanabi1224 @aatifsyed