Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): bootstrap node specific configurations #4377

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 30, 2024

Summary of changes

(Part of #4346 investigation)

This PR adds --bootstrap CLI option to forest daemon and configure the P2P parameters differently, to align with lotus.

Changes introduced in this pull request:

  • adds --bootstrap CLI option to forest daemon
  • update gossipsub configs to align with lotus
  • implement bootstrap node specific P2P configs that align with lotus

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review May 30, 2024 07:17
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 30, 2024 07:17
@hanabi1224 hanabi1224 requested review from lemmih and elmattic and removed request for a team May 30, 2024 07:17
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for running a stateless node outside of being a bootstrap node? If not, let's coalesce stateless and bootstrap notion into a single one, probably bootstrap for better discoverability. This will require some changes in docs, but should be easy to find.

@hanabi1224
Copy link
Contributor Author

Is there a reason for running a stateless node outside of being a bootstrap node? If not, let's coalesce stateless and bootstrap notion into a single one, probably bootstrap for better discoverability. This will require some changes in docs, but should be easy to find.

@LesnyRumcajs As I understand, the bootstrap-specific gossipsub config mainly works for regular(stateful) nodes. For stateless nodes, I need to explore further on whether it works better with the bootstrap config or the non-bootstrap config as lotus does not offer the stateless mode atm.

@LesnyRumcajs
Copy link
Member

@hanabi1224 Did you confirm the mainnet node (both bootstrap and not bootstrap) works well with those settings? I don't understand what each of those parameters does, so it'd be great to manually check we're still good on connectivity side.

What should we actually expect by applying these settings? Better connectivity? Better performance?

Should this be documented so that the infrastructure team can benefit from this flag?

@hanabi1224 hanabi1224 marked this pull request as draft June 5, 2024 04:12
@LesnyRumcajs
Copy link
Member

@hanabi1224 what do we do with this draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants