Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc test): favor API v1 compatibility over v0 #4448

Closed
wants to merge 4 commits into from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jun 25, 2024

Summary of changes

Part of #4424 investigation

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224
Copy link
Contributor Author

The CI failures show that StateSectorPreCommitInfo and StateWaitMsg are the only 2 methods that are v1-incompatible (there still might be cases not covered by the parity test suite though)

@LesnyRumcajs
Copy link
Member

@hanabi1224 what do we do with this draft?

@hanabi1224 hanabi1224 closed this Jul 20, 2024
@hanabi1224 hanabi1224 deleted the hm/favour-rpc-v1-compatiblity branch July 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants