Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Filecoin.EthEstimateGas #4496

Merged
merged 16 commits into from
Jul 19, 2024
Merged

feat(rpc): Filecoin.EthEstimateGas #4496

merged 16 commits into from
Jul 19, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 9, 2024

Summary of changes

Changes introduced in this pull request:

     Running `target/quick/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2024-07-16_height_1794896.forest.car.zst --filter EthEstimateGas`
| RPC Method                  | Forest

                                      | Lotus

                                                                                                                      |
|-----------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Filecoin.EthEstimateGas (2) | Rejected("Message has no gas limit set")

                                      | Rejected("failed to estimate gas: message execution failed: exit 33, revert reason: 0x5416eb985902a47900000000000000000000000000000000000000000000000000000000, vm error: message failed with backtrace:\n00: f0131175 (method 3844450837) -- contract reverted (33)\n (RetCode=33)")                                         |
| Filecoin.EthEstimateGas     | Rejected("Message has no gas limit set")

                                      | Rejected("failed to estimate gas: message execution failed: exit 33, revert reason: none, vm error: message failed with backtrace:\n00: f0120961 (method 3844450837) -- contract reverted (33)\n (RetCode=33)")                                                                                                               |
| Filecoin.EthEstimateGas (2) | Rejected("Message has no gas limit set")

                                      | Rejected("failed to estimate gas: message execution failed: exit 33, revert reason: none, vm error: message failed with backtrace:\n00: f0133994 (method 3844450837) -- contract reverted (33)\n (RetCode=33)")                                                                                                               |
| Filecoin.EthEstimateGas     | Rejected("Message has no gas limit set")

                                      | Rejected("failed to estimate gas: message execution failed: exit ErrUnhandledMessage(22), revert reason: none, vm error: message failed with backtrace:\n00: f01024 (method 3844450837) -- invalid method: 3844450837 (22)\n (RetCode=22)")                                                                                   |
| Filecoin.EthEstimateGas     | Rejected("message execution failed: exit 6, reason: message failed with backtrace:\n--> caused by: send::send -- sender does not have funds to transfer (balance 367.058155041994155272, transfer 8099.99987) (5: insufficient funds)\n (RetCode=6)") | Rejected("failed to estimate gas: message execution failed: exit SysErrInsufficientFunds(6), revert reason: none, vm error: message failed with backtrace:\n--> caused by: send::send -- sender does not have funds to transfer (balance 367.058155041994155272, transfer 8099.99987) (5: insufficient funds)\n (RetCode=6)") |
| Filecoin.EthEstimateGas     | Valid

                                      | Valid

                                                                                                                      |

Reference issue to close (if applicable)

Closes #4556

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review July 18, 2024 03:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner July 18, 2024 03:54
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team July 18, 2024 03:54
}

impl GasEstimateGasLimit {
pub async fn estimate_call_with_gas<DB>(
Copy link
Contributor Author

@hanabi1224 hanabi1224 Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving free fn estimate_gas_limit here and split it into estimate_call_with_gas and estimate_gas_limit

@hanabi1224
Copy link
Contributor Author

@sudo-shashank Please re-approve again. This PR constantly gets merge conflicts : )

@hanabi1224 hanabi1224 added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit b778ffd Jul 19, 2024
26 of 28 checks passed
@hanabi1224 hanabi1224 deleted the hm/EthEstimateGas branch July 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecoin.EthEstimateGas
3 participants