Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc) Implement Filecoin.EthGetTransactionHashByCid #4506

Merged
merged 6 commits into from
Jul 12, 2024
Merged

feat(rpc) Implement Filecoin.EthGetTransactionHashByCid #4506

merged 6 commits into from
Jul 12, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Jul 11, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Implement Filecoin.EthGetTransactionHashByCid RPC method
  • API compare tests
| RPC Method                                      | Forest | Lotus |
|-------------------------------------------------|--------|-------|
| Filecoin.EthGetTransactionHashByCid (10)        | Valid  | Valid |

Reference issue to close (if applicable)

Contributes to #4165

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank mentioned this pull request Jul 11, 2024
Open
39 tasks
@sudo-shashank sudo-shashank marked this pull request as ready for review July 11, 2024 11:23
@sudo-shashank sudo-shashank requested a review from a team as a code owner July 11, 2024 11:23
@sudo-shashank sudo-shashank requested review from ruseinov and hanabi1224 and removed request for a team July 11, 2024 11:23
@sudo-shashank sudo-shashank added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit b10be60 Jul 12, 2024
28 checks passed
@sudo-shashank sudo-shashank deleted the shashank/Rpc-EthGetTransactionHashByCid branch July 12, 2024 12:25
sudo-shashank added a commit that referenced this pull request Jul 12, 2024
@sudo-shashank
feat(rpc) Implement Filecoin.EthGetTransactionHashByCid (#4506)
3bd24a9
sudo-shashank added a commit that referenced this pull request Jul 16, 2024
@sudo-shashank
feat(rpc) Implement Filecoin.EthGetTransactionHashByCid (#4506)
a098808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@aatifsyed aatifsyed aatifsyed approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudo-shashank @lemmih @hanabi1224 @aatifsyed