feat: add logs for builder validator registrations (#5986)

* feat: add logs for builder validator registrations * Throw error if builder is not enabled * Update log messages * Add epoch info to beacon log
ChainSafe · Sep 23, 2023 · 0f74435 · 0f74435
1 parent 3903dc1
commit 0f74435
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/packages/beacon-node/src/api/impl/validator/index.ts b/packages/beacon-node/src/api/impl/validator/index.ts
@@ -816,6 +816,10 @@ export function getValidatorApi({
     },
 
     async registerValidator(registrations) {
+      if (!chain.executionBuilder) {
+        throw Error("Execution builder not enabled");
+      }
+
       // should only send active or pending validator to builder
       // Spec: https://ethereum.github.io/builder-specs/#/Builder/registerValidator
       const headState = chain.getHeadState();
@@ -838,7 +842,12 @@ export function getValidatorApi({
         );
       });
 
-      return chain.executionBuilder?.registerValidator(filteredRegistrations);
+      await chain.executionBuilder.registerValidator(filteredRegistrations);
+
+      logger.debug("Forwarded validator registrations to connected builder", {
+        epoch: currentEpoch,
+        count: filteredRegistrations.length,
+      });
     },
   };
 }
diff --git a/packages/beacon-node/src/execution/builder/http.ts b/packages/beacon-node/src/execution/builder/http.ts
@@ -84,7 +84,10 @@ export class ExecutionBuilderHttp implements IExecutionBuilder {
   }
 
   async registerValidator(registrations: bellatrix.SignedValidatorRegistrationV1[]): Promise<void> {
-    ApiError.assert(await this.api.registerValidator(registrations));
+    ApiError.assert(
+      await this.api.registerValidator(registrations),
+      "Failed to forward validator registrations to connected builder"
+    );
   }
 
   async getHeader(

diff --git a/packages/validator/src/services/prepareBeaconProposer.ts b/packages/validator/src/services/prepareBeaconProposer.ts
@@ -106,8 +106,9 @@ export function pollBuilderValidatorRegistration(
             })
           );
           ApiError.assert(await api.validator.registerValidator(registrations));
+          logger.info("Published validator registrations to builder network", {epoch, count: registrations.length});
         } catch (e) {
-          logger.error("Failed to register validator registrations with builder", {epoch}, e as Error);
+          logger.error("Failed to publish validator registrations to builder network", {epoch}, e as Error);
         }
       }
     }