Improve monitoring endpoint validation errors

ChainSafe · Aug 14, 2023 · 4fddfda · 4fddfda
1 parent 51382d0
commit 4fddfda
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/beacon-node/src/monitoring/service.ts b/packages/beacon-node/src/monitoring/service.ts
@@ -210,7 +210,7 @@ export class MonitoringService {
 
   private parseMonitoringEndpoint(endpoint: string): URL {
     if (!endpoint) {
-      throw new Error("Monitoring endpoint must be provided");
+      throw new Error(`Monitoring endpoint is empty or undefined: ${endpoint}`);
     }
 
     try {
@@ -226,7 +226,7 @@ export class MonitoringService {
 
       return url;
     } catch {
-      throw new Error("Monitoring endpoint must be a valid URL");
+      throw new Error(`Monitoring endpoint must be a valid URL: ${endpoint}`);
     }
   }
 }
diff --git a/packages/beacon-node/test/unit/monitoring/service.test.ts b/packages/beacon-node/test/unit/monitoring/service.test.ts
@@ -58,14 +58,16 @@ describe("monitoring / service", () => {
     });
 
     it("should throw an error if monitoring endpoint is not provided", () => {
-      expect(() => new MonitoringService("beacon", {endpoint: ""}, {register, logger})).to.throw(
-        "Monitoring endpoint must be provided"
+      const endpoint = "";
+      expect(() => new MonitoringService("beacon", {endpoint}, {register, logger})).to.throw(
+        `Monitoring endpoint is empty or undefined: ${endpoint}`
       );
     });
 
     it("should throw an error if monitoring endpoint is not a valid URL", () => {
-      expect(() => new MonitoringService("beacon", {endpoint: "invalid"}, {register, logger})).to.throw(
-        "Monitoring endpoint must be a valid URL"
+      const endpoint = "invalid";
+      expect(() => new MonitoringService("beacon", {endpoint}, {register, logger})).to.throw(
+        `Monitoring endpoint must be a valid URL: ${endpoint}`
       );
     });