Skip to content

Commit

Permalink
Fix relevant breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
nazarhussain committed Sep 25, 2023
1 parent 7ca39ee commit 9a9d096
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
1 change: 0 additions & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"packages/*"
],
"npmClient": "yarn",
"useWorkspaces": true,
"useNx": true,
"version": "1.11.1",
"stream": "true",
Expand Down
2 changes: 1 addition & 1 deletion packages/beacon-node/test/unit/monitoring/service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ describe("monitoring / service", () => {
const endpoint = `${baseUrl}${remoteServiceRoutes.pending}`;
service = new MonitoringService("beacon", {endpoint, collectSystemStats: false}, {register, logger});

service.send().finally(() => {
void service.send().finally(() => {
try {
assertError({message: new ErrorAborted("request").message});
done();
Expand Down
2 changes: 1 addition & 1 deletion packages/db/src/controller/level.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const DB_SIZE_METRIC_INTERVAL_MS = 5 * 60 * 1000;
export class LevelDbController implements DatabaseController<Uint8Array, Uint8Array> {
private status = Status.started;

private dbSizeMetricInterval?: NodeJS.Timer;
private dbSizeMetricInterval?: NodeJS.Timeout;

constructor(
private readonly logger: Logger,
Expand Down
10 changes: 7 additions & 3 deletions packages/validator/src/services/indices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,13 @@ export class IndicesService {

this.pollValidatorIndicesPromise = this.pollValidatorIndicesInternal(pubkeysHex);
// Once the pollValidatorIndicesInternal() resolves or rejects null the cached promise so it can be called again.
this.pollValidatorIndicesPromise.finally(() => {
this.pollValidatorIndicesPromise = null;
});
this.pollValidatorIndicesPromise
.catch((err) => {
this.logger.error("Error polling validator indices", {}, err);
})
.finally(() => {
this.pollValidatorIndicesPromise = null;
});
return this.pollValidatorIndicesPromise;
}

Expand Down

0 comments on commit 9a9d096

Please sign in to comment.