Add todos

ChainSafe · Aug 5, 2024 · 9b9836e · 9b9836e
1 parent e4f52b4
commit 9b9836e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/api/src/beacon/routes/beacon/pool.ts b/packages/api/src/beacon/routes/beacon/pool.ts
@@ -30,9 +30,9 @@ const SignedVoluntaryExitListType = ArrayOf(ssz.phase0.SignedVoluntaryExit);
 const SignedBLSToExecutionChangeListType = ArrayOf(ssz.capella.SignedBLSToExecutionChange);
 const SyncCommitteeMessageListType = ArrayOf(ssz.altair.SyncCommitteeMessage);
 
-export type AttestationListPhase0 = ValueOf<typeof AttestationListTypePhase0>;
+type AttestationListPhase0 = ValueOf<typeof AttestationListTypePhase0>;
 type AttestationListElectra = ValueOf<typeof AttestationListTypeElectra>;
-export type AttestationList = AttestationListPhase0 | AttestationListElectra;
+type AttestationList = AttestationListPhase0 | AttestationListElectra;
 
 type AttesterSlashingListPhase0 = ValueOf<typeof AttesterSlashingListTypePhase0>;
 type AttesterSlashingListElectra = ValueOf<typeof AttesterSlashingListTypeElectra>;

diff --git a/packages/beacon-node/src/api/impl/validator/index.ts b/packages/beacon-node/src/api/impl/validator/index.ts
@@ -1067,6 +1067,7 @@ export function getValidatorApi(
       };
     },
 
+    // TODO Electra: Implement getAggregatedAttestation to properly handle pre-electra
     async getAggregatedAttestation() {
       throw new Error("Not implemented. Use getAggregatedAttestationV2 for now.");
     },

diff --git a/packages/validator/src/services/attestation.ts b/packages/validator/src/services/attestation.ts
@@ -225,6 +225,7 @@ export class AttestationService {
       ...(this.opts?.disableAttestationGrouping && {index: attestationNoCommittee.index}),
     };
     try {
+      // TODO Electra: Ensure calling V2 works in pre-electra
       (await this.api.beacon.submitPoolAttestationsV2({signedAttestations})).assertOk();
       this.logger.info("Published attestations", {...logCtx, count: signedAttestations.length});
       this.metrics?.publishedAttestations.inc(signedAttestations.length);