Skip to content

Commit

Permalink
fix(metrics): remove unused re-emit metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewkeil committed Jul 25, 2023
1 parent 77bb847 commit f41eb50
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 16 deletions.
4 changes: 2 additions & 2 deletions dashboards/lodestar_networking.json
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@
"uid": "${DS_PROMETHEUS}"
},
"exemplar": false,
"expr": "rate(lodestar_network_worker_wire_events_on_worker_thread_port_latency[6m])",
"expr": "rate(lodestar_network_worker_wire_events_on_worker_thread_latency[6m])",
"interval": "",
"legendFormat": "to worker thread",
"refId": "to worker thread"
Expand All @@ -970,7 +970,7 @@
"uid": "${DS_PROMETHEUS}"
},
"exemplar": false,
"expr": "rate(lodestar_network_worker_wire_events_on_main_thread_port_latency[6m])",
"expr": "rate(lodestar_network_worker_wire_events_on_main_thread_latency[6m])",
"hide": false,
"interval": "",
"legendFormat": "to main thread",
Expand Down
9 changes: 2 additions & 7 deletions packages/beacon-node/src/metrics/metrics/lodestar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,8 @@ export function createLodestarMetrics(
help: "Current count of pending items in reqRespBridgeReqCaller data structure",
}),
},
networkWorkerWireEventsOnMainThreadEventLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_main_thread_event_latency",
help: "Latency to re-emit network events on main thread event bus",
buckets: [0.001, 0.003, 0.01, 0.03, 0.1],
}),
networkWorkerWireEventsOnMainThreadPortLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_main_thread_port_latency",
networkWorkerWireEventsOnMainThreadLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_main_thread_latency",
help: "Latency to transmit network events to main thread across worker port",
buckets: [0.001, 0.003, 0.01, 0.03, 0.1],
}),
Expand Down
9 changes: 2 additions & 7 deletions packages/beacon-node/src/network/core/metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,8 @@ export function getNetworkCoreWorkerMetrics(register: RegistryMetricCreator) {
name: "lodestar_network_worker_reqresp_bridge_caller_pending_count",
help: "Current count of pending elements in respBridgeCaller",
}),
networkWorkerWireEventsOnWorkerThreadEventLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_worker_thread_event_latency",
help: "Latency to re-emit network events on worker thread event bus",
buckets: [0.001, 0.003, 0.01, 0.03, 0.1],
}),
networkWorkerWireEventsOnWorkerThreadPortLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_worker_thread_port_latency",
networkWorkerWireEventsOnWorkerThreadLatency: register.histogram({
name: "lodestar_network_worker_wire_events_on_worker_thread_latency",
help: "Latency to transmit network events to worker thread across parent port",
buckets: [0.001, 0.003, 0.01, 0.03, 0.1],
}),
Expand Down

0 comments on commit f41eb50

Please sign in to comment.