Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.21.0-rc.1: service deployment vs docker deployment #7003

Closed
twoeths opened this issue Aug 5, 2024 · 3 comments
Closed

v1.21.0-rc.1: service deployment vs docker deployment #7003

twoeths opened this issue Aug 5, 2024 · 3 comments
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Aug 5, 2024

Describe the bug

After testing v1.21.0-rc.1 on service deployment - the test mainnet node I found its performance is clearly better than docker deployment

  • Service deployment, mesh peer
Screenshot 2024-08-05 at 11 20 02 Screenshot 2024-08-05 at 11 21 10
  • Docker deployment, mesh peer
Screenshot 2024-08-05 at 11 20 26 Screenshot 2024-08-05 at 11 21 26
  • Service deployment, attestation validation
Screenshot 2024-08-05 at 11 22 12
  • Docker deployment, attestation validation
Screenshot 2024-08-05 at 11 22 40

it could be linked to the napi-rs binding #6894 cc @wemeetagain @matthewkeil

Expected behavior

Docker deployment should be as great as service deployment's performance

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.21.0-rc.1

@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Aug 5, 2024
@twoeths
Copy link
Contributor Author

twoeths commented Aug 5, 2024

could be the performance of aggregateWithRandomness is not the same between service deployment vs docker deployment due to gc

Screenshot 2024-08-05 at 13 33 26
  • docker deployment, although it has less mesh peers gc is higher
Screenshot 2024-08-05 at 13 33 47

@twoeths
Copy link
Contributor Author

twoeths commented Aug 12, 2024

closed via the above PR

@twoeths
Copy link
Contributor Author

twoeths commented Aug 26, 2024

hash_tree_root() time is always better on service deployment

  • this is service deployment on a test mainnet node
Screenshot 2024-08-26 at 17 42 07
  • this is docker deployment on the stable mainnet node
Screenshot 2024-08-26 at 17 42 49

it's consistent to other types of node. Anyway we're going to go with batch hash which uses a totally different library hashtree #6939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

No branches or pull requests

1 participant