fix: use default node image to build docker #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.21.0 #7004 +/- ##
===========================================
Coverage 62.48% 62.49%
===========================================
Files 576 576
Lines 61198 61198
Branches 2141 2132 -9
===========================================
+ Hits 38242 38243 +1
Misses 22916 22916
+ Partials 40 39 -1 |
wemeetagain
reviewed
Aug 5, 2024
|
Looks like the slim image is 72MB + lodestar |
wemeetagain
approved these changes
Aug 5, 2024
do you know the total image size? |
@nflaig it's ~181MB https://hub.docker.com/r/tuyennhv/lodestar/tags while it's ~161MB for the current image https://hub.docker.com/r/chainsafe/lodestar/tags |
nflaig
approved these changes
Aug 6, 2024
|
Persisting some metrics here
the last 2 metrics are the deciding factors to get it merged, plus this will use glibc similar to service deployment |
wemeetagain
added a commit
that referenced
this pull request
Aug 6, 2024
* fix: use default node image instead of alpine * fix: use apt-get * Apply suggestions from code review --------- Co-authored-by: Cayman <caymannava@gmail.com>
|
🎉 This PR is included in v1.21.0 🎉 |
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: use default node image instead of alpine * fix: use apt-get * Apply suggestions from code review --------- Co-authored-by: Cayman <caymannava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Two things that may cause the performance issue on docker:
musllibc in the docker image https://github.com/ChainSafe/blst-ts/blob/f70469ef04507934b38560b94ff9d3897c01bbf3/index.js#L169this PR uses the default node image which is supposed to have no different to service deployment. The down side is its image size, now it's ~493MB which is >3x the current image size so we need to consider this fact
Closes #7003