feat: verifySignatureSetsSameSigningRoot bls api #5734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Not sure that we'd ever want to verify on the main thread? |
@wemeetagain I think the theory of not to do heavy operations on main thread is because normally main thread is for I/O operation. Now we do I/O operations on worker thread, we can test verifying signatures (the 1st round) on main thread (and leave all fallback verifications on worker thread), this is when I tested |
|
another use case for |
matthewkeil
requested changes
Jul 9, 2023
There was a problem hiding this comment.
I am curious what you think about simplifying the API back to:
type WorkerApi = {
verifyManySignatureSets(workReqArr: BlsWorkReq[]): Promise<BlsWorkResult>;
};That way there is only a single api from the chain code perspective and the decision making about when and to check messages for being the same and to verify accordingly all happens within the IBlsVerifier. We would be able to achieve the grouping of similar attestations across multiple gossip messages and I think it will simplify the worker API.
If you don't think this is a good idea let me know and I will come back and finish the review with the code as-is.
matthewkeil
reviewed
Jul 11, 2023
| opts?: Pick<VerifySignatureOpts, "verifyOnMainThread"> | ||
| ): Promise<boolean[]> { | ||
| if (opts?.verifyOnMainThread && !this.blsVerifyAllMultiThread) { | ||
| const isSameMessage = true; |
There was a problem hiding this comment.
What do you think about a metric for main thread time similar to the other case?
There was a problem hiding this comment.
Should we also be counting the sets and keys to see what kind of gains we get under load?
There was a problem hiding this comment.
thanks for reminding this, all metrics are available, I only need to add "api" label there
There was a problem hiding this comment.
Should we also be counting the sets and keys to see what kind of gains we get under load?
we counted the api call, regarding the gain we can count on bls.test.ts perf test
@matthewkeil thanks for looking into this PR. As discussed, the part of filtering signature sets with the same message is done in #5729 so we really need a new api here. I'm happy if you have any suggestions or simpler way to achieve this. |
matthewkeil
reviewed
Jul 11, 2023
|
@tuyennhv I think I found a simpler approach extending your idea. It re-uses the existing queue, such that:
Please take a look and consider incorporating |
@dapplion that's great, it looks really simpler, I created #5747 closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
verifyMultipleSignatures()apicanAcceptWork()(if we should process a gossip message or not)Description
verifyManySignatureSetsSameMessage()worker apiverifySignatureSetsMaybeBatch()to add new paramisSameMessage: booleanQueueItemtype (an item in "jobs" queue) andJobItemtype (which contain a resolve/reject function of a promise)verifySignatureSetsSameSigningRoothas "verifyOnMainThread" to verify on main thread or not, consumer can decide it later (in feat: verify attestation gossip messages in batch #5729)part of #5416
Notes