-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable deterministicLongLivedAttnets by default #5822
Merged
wemeetagain
merged 1 commit into
unstable
from
tuyen/deterministicLongLivedAttnets_default
Aug 1, 2023
Merged
feat: enable deterministicLongLivedAttnets by default #5822
wemeetagain
merged 1 commit into
unstable
from
tuyen/deterministicLongLivedAttnets_default
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
adding some bandquidth metrics, cc @nflaig |
The aggregator performance is the same, this is from cc @dapplion |
attaching the profile of cc @wemeetagain |
wemeetagain
approved these changes
Aug 1, 2023
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most of nodes (except for
novc
and1v
) use significant less resource so we may want to turn this flag on by default sooner than laterDescription
Enable
deterministicLongLivedAttnets
flag by default which make nodes subscribe to 2 subnets instead of depending on number of connected validator1k
node64 validator
node16 validator
node1 validator
node uses a bit more resource