feat: send and use validators fee recipient for engine block production #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Aug 3, 2023
| @@ -428,7 +431,7 @@ export type ReqTypes = { | |||
| getProposerDuties: {params: {epoch: Epoch}}; | |||
| getSyncCommitteeDuties: {params: {epoch: Epoch}; body: U64Str[]}; | |||
| produceBlock: {params: {slot: number}; query: {randao_reveal: string; graffiti: string}}; | |||
| produceBlockV2: {params: {slot: number}; query: {randao_reveal: string; graffiti: string}}; | |||
| produceBlockV2: {params: {slot: number}; query: {randao_reveal: string; graffiti: string; fee_recipient?: string}}; | |||
There was a problem hiding this comment.
This is not part of the spec right? https://github.com/ethereum/beacon-APIs/blob/ea5668708f2c6717fd2934c9a0b82b6705818a2e/apis/validator/block.v2.yaml#L13 adding this here will cause our API client to break with spec compliant impls
There was a problem hiding this comment.
yes you are correct 🙂 its not in spec, plan to PR there as well (for produce block v3),
but its spec compatible, in the sense that if the fee recipient is not passed, it will behave in the old spec complaint way
dapplion
approved these changes
Aug 14, 2023
sounds good! will open PR |
|
🎉 This PR is included in v1.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of
Generally the validator registers fee recipient every epoch for engine (as well as builder block production). However in some edge cases like where registration was not updated (for e.g. fee recipient updated just few slots into epoch via keymanager) or registration issues or the block production requests routed to a fallback bn where validators registrations were not done .... (the edge case lodestar deployments witnessed on 31 july), its imperative that the produce block calls should carry the fee recipient and start a fresh engine block production with a new recipient if bn didn't have a prepared payload id which matches the requested fee recipient.
This PR achieves the same.
TODO: