-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clarify event loop lag metrics in grafana #5842
Merged
wemeetagain
merged 1 commit into
unstable
from
tuyen/event_loop_lag_grafana_panel_titles
Aug 3, 2023
Merged
chore: clarify event loop lag metrics in grafana #5842
wemeetagain
merged 1 commit into
unstable
from
tuyen/event_loop_lag_grafana_panel_titles
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
I may have changed some charts without updating the source |
dapplion
approved these changes
Aug 3, 2023
wemeetagain
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are event loop lag metric A and metric B which causes some confusion to the team. I found that the Metric A
nodejs_eventloop_lag_seconds
actually comes fromprom-client
https://github.com/siimon/prom-client/blob/v14.2.0/lib/metrics/eventLoopLag.js#L54 while Metric Bnodejs_eventloop_lag_mean_seconds
is computed by NodeJS api https://nodejs.org/api/perf_hooks.html#perf_hooksmonitoreventloopdelayoptionsToday I found that metric A keeps increasing (v1.9.2 vs v1.10.0-rc.1) while metric B is consistently low, and the
vc
api is also consistently low so we should care more metric B (NodeJS event loop lag) cc @dapplionDescription
The change is small but looks like this "VM" dashboard is out of date so there are a lot of changes, if someone saved/updated the dashboard intentionally please confirm in this PR