-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable mixed beacon-validator sim tests #5940
Conversation
@nflaig Using custom network allows us to set a submit and then we can assign any IP to our services in that range from code. There is no drawback I see using it. |
Yeah, the only drawback is that we have to use |
Performance Report✔️ no performance regression detected Full benchmark results
|
🎉 This PR is included in v1.12.0 🎉 |
Motivation
At the moment mixed client tests are disabled because the assumption was that those will only work once #5553 is fixed but that is not the case as the issue is not an actual problem which would prevent Lodestar BN <> Lighthouse VC combinations from producing attestations and aggregates.
Description
Further considerations
We could update sim tests to run all containers with
--network host
flag and not create a custom docker networkhost.docker.internal
workaround could be removed@nazarhussain are there any other reasons / trade offs for using a custom docker network instead of host network?