Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore lockfiles when loading keys for voluntary exit #5950

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: ignore lockfiles when loading keys for voluntary exit #5950

merged 1 commit into from
Sep 13, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Sep 11, 2023 •
edited
Loading

Motivation

The voluntary exit command needs to load the keystore in order to sign the message. If this command is executed on the same keystore used by the currently running validator client it will fail due to existing lockfiles. There is a workaround to pass --force flag but this seems unnecessary as there is no reason to use lockfiles for the voluntary exit command.

Description

Ignore lockfiles when loading keys for voluntary exit

@nflaig nflaig requested a review from a team as a code owner September 11, 2023 22:02
@nflaig nflaig force-pushed the nflaig/voluntary-exit-ignore-lockfiles branch from c9823ff to f9156df Compare September 11, 2023 22:25
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: 12d71cf Previous: 80c001b Ratio
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.7210 us/op 27.519 us/op 0.32
Full benchmark results
Benchmark suite Current: 12d71cf Previous: 80c001b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 513.23 us/op 826.83 us/op 0.62
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 51.586 us/op 78.044 us/op 0.66
BLS verify - blst-native 1.1032 ms/op 1.2952 ms/op 0.85
BLS verifyMultipleSignatures 3 - blst-native 2.3324 ms/op 2.8022 ms/op 0.83
BLS verifyMultipleSignatures 8 - blst-native 5.1458 ms/op 6.1054 ms/op 0.84
BLS verifyMultipleSignatures 32 - blst-native 18.959 ms/op 21.977 ms/op 0.86
BLS verifyMultipleSignatures 64 - blst-native 36.954 ms/op 45.506 ms/op 0.81
BLS verifyMultipleSignatures 128 - blst-native 73.156 ms/op 86.207 ms/op 0.85
BLS deserializing 10000 signatures 766.92 ms/op 878.03 ms/op 0.87
BLS deserializing 100000 signatures 7.7111 s/op 8.8224 s/op 0.87
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.0947 ms/op 1.3025 ms/op 0.84
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.2574 ms/op 1.4612 ms/op 0.86
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.1668 ms/op 2.2724 ms/op 0.95
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.2014 ms/op 3.8077 ms/op 0.84
BLS verifyMultipleSignatures - same message - 128 - blst-native 4.8698 ms/op 6.4120 ms/op 0.76
BLS aggregatePubkeys 32 - blst-native 21.848 us/op 26.233 us/op 0.83
BLS aggregatePubkeys 128 - blst-native 86.484 us/op 98.584 us/op 0.88
getAttestationsForBlock 27.461 ms/op 40.019 ms/op 0.69
isKnown best case - 1 super set check 214.00 ns/op 292.00 ns/op 0.73
isKnown normal case - 2 super set checks 206.00 ns/op 267.00 ns/op 0.77
isKnown worse case - 16 super set checks 203.00 ns/op 262.00 ns/op 0.77
CheckpointStateCache - add get delete 3.4260 us/op 4.9620 us/op 0.69
validate api signedAggregateAndProof - struct 2.3892 ms/op 2.7490 ms/op 0.87
validate gossip signedAggregateAndProof - struct 2.3228 ms/op 2.6733 ms/op 0.87
validate gossip attestation - vc 640000 1.1294 ms/op 1.3437 ms/op 0.84
batch validate gossip attestation - vc 640000 - chunk 32 132.83 us/op 159.71 us/op 0.83
batch validate gossip attestation - vc 640000 - chunk 64 117.17 us/op 147.17 us/op 0.80
batch validate gossip attestation - vc 640000 - chunk 128 112.75 us/op 140.10 us/op 0.80
batch validate gossip attestation - vc 640000 - chunk 256 109.13 us/op 135.18 us/op 0.81
pickEth1Vote - no votes 886.26 us/op 1.2692 ms/op 0.70
pickEth1Vote - max votes 8.7565 ms/op 8.6211 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.119 ms/op 17.008 ms/op 0.77
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 18.089 ms/op 23.936 ms/op 0.76
pickEth1Vote - Eth1Data fastSerialize value x2048 382.73 us/op 580.23 us/op 0.66
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.4312 ms/op 4.9360 ms/op 0.90
bytes32 toHexString 335.00 ns/op 478.00 ns/op 0.70
bytes32 Buffer.toString(hex) 209.00 ns/op 310.00 ns/op 0.67
bytes32 Buffer.toString(hex) from Uint8Array 313.00 ns/op 452.00 ns/op 0.69
bytes32 Buffer.toString(hex) + 0x 206.00 ns/op 282.00 ns/op 0.73
Object access 1 prop 0.10800 ns/op 0.16200 ns/op 0.67
Map access 1 prop 0.11000 ns/op 0.14900 ns/op 0.74
Object get x1000 5.3440 ns/op 7.9340 ns/op 0.67
Map get x1000 0.43500 ns/op 0.63600 ns/op 0.68
Object set x1000 24.598 ns/op 51.214 ns/op 0.48
Map set x1000 16.176 ns/op 38.616 ns/op 0.42
Return object 10000 times 0.22230 ns/op 0.25330 ns/op 0.88
Throw Error 10000 times 2.7743 us/op 3.8457 us/op 0.72
fastMsgIdFn sha256 / 200 bytes 1.8680 us/op 3.3340 us/op 0.56
fastMsgIdFn h32 xxhash / 200 bytes 204.00 ns/op 281.00 ns/op 0.73
fastMsgIdFn h64 xxhash / 200 bytes 235.00 ns/op 347.00 ns/op 0.68
fastMsgIdFn sha256 / 1000 bytes 6.0810 us/op 11.633 us/op 0.52
fastMsgIdFn h32 xxhash / 1000 bytes 317.00 ns/op 399.00 ns/op 0.79
fastMsgIdFn h64 xxhash / 1000 bytes 302.00 ns/op 429.00 ns/op 0.70
fastMsgIdFn sha256 / 10000 bytes 54.088 us/op 106.25 us/op 0.51
fastMsgIdFn h32 xxhash / 10000 bytes 1.6990 us/op 1.9440 us/op 0.87
fastMsgIdFn h64 xxhash / 10000 bytes 1.1210 us/op 1.3370 us/op 0.84
enrSubnets - fastDeserialize 64 bits 819.00 ns/op 1.2030 us/op 0.68
enrSubnets - ssz BitVector 64 bits 301.00 ns/op 428.00 ns/op 0.70
enrSubnets - fastDeserialize 4 bits 117.00 ns/op 163.00 ns/op 0.72
enrSubnets - ssz BitVector 4 bits 308.00 ns/op 414.00 ns/op 0.74
prioritizePeers score -10:0 att 32-0.1 sync 2-0 68.509 us/op 104.90 us/op 0.65
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 81.729 us/op 129.47 us/op 0.63
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 107.41 us/op 163.19 us/op 0.66
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 176.25 us/op 284.65 us/op 0.62
prioritizePeers score 0:0 att 64-1 sync 4-1 204.74 us/op 344.36 us/op 0.59
array of 16000 items push then shift 1.2246 us/op 1.6224 us/op 0.75
LinkedList of 16000 items push then shift 6.7030 ns/op 9.0520 ns/op 0.74
array of 16000 items push then pop 58.411 ns/op 89.989 ns/op 0.65
LinkedList of 16000 items push then pop 5.8230 ns/op 8.8300 ns/op 0.66
array of 24000 items push then shift 1.8334 us/op 2.4184 us/op 0.76
LinkedList of 24000 items push then shift 6.5480 ns/op 9.1240 ns/op 0.72
array of 24000 items push then pop 97.101 ns/op 108.97 ns/op 0.89
LinkedList of 24000 items push then pop 5.6180 ns/op 8.9260 ns/op 0.63
intersect bitArray bitLen 8 5.0630 ns/op 6.7710 ns/op 0.75
intersect array and set length 8 44.572 ns/op 55.102 ns/op 0.81
intersect bitArray bitLen 128 25.545 ns/op 31.641 ns/op 0.81
intersect array and set length 128 596.75 ns/op 779.62 ns/op 0.77
bitArray.getTrueBitIndexes() bitLen 128 1.2400 us/op 1.4470 us/op 0.86
bitArray.getTrueBitIndexes() bitLen 248 1.9800 us/op 2.5400 us/op 0.78
bitArray.getTrueBitIndexes() bitLen 512 3.4640 us/op 5.1650 us/op 0.67
Buffer.concat 32 items 856.00 ns/op 960.00 ns/op 0.89
Uint8Array.set 32 items 1.6510 us/op 1.7980 us/op 0.92
Set add up to 64 items then delete first 1.9414 us/op 4.6916 us/op 0.41
OrderedSet add up to 64 items then delete first 2.9166 us/op 5.3950 us/op 0.54
Set add up to 64 items then delete last 2.3371 us/op 5.0045 us/op 0.47
OrderedSet add up to 64 items then delete last 3.4041 us/op 6.3464 us/op 0.54
Set add up to 64 items then delete middle 2.4727 us/op 4.9064 us/op 0.50
OrderedSet add up to 64 items then delete middle 4.6247 us/op 7.5993 us/op 0.61
Set add up to 128 items then delete first 3.7312 us/op 10.119 us/op 0.37
OrderedSet add up to 128 items then delete first 5.6199 us/op 13.797 us/op 0.41
Set add up to 128 items then delete last 3.7367 us/op 9.8234 us/op 0.38
OrderedSet add up to 128 items then delete last 5.8252 us/op 12.704 us/op 0.46
Set add up to 128 items then delete middle 3.7131 us/op 9.7341 us/op 0.38
OrderedSet add up to 128 items then delete middle 10.759 us/op 18.226 us/op 0.59
Set add up to 256 items then delete first 7.2733 us/op 20.469 us/op 0.36
OrderedSet add up to 256 items then delete first 11.172 us/op 25.466 us/op 0.44
Set add up to 256 items then delete last 7.2974 us/op 19.924 us/op 0.37
OrderedSet add up to 256 items then delete last 11.742 us/op 24.372 us/op 0.48
Set add up to 256 items then delete middle 7.2508 us/op 19.083 us/op 0.38
OrderedSet add up to 256 items then delete middle 31.129 us/op 46.693 us/op 0.67
transfer serialized Status (84 B) 1.3150 us/op 1.7800 us/op 0.74
copy serialized Status (84 B) 1.1490 us/op 1.5860 us/op 0.72
transfer serialized SignedVoluntaryExit (112 B) 1.4260 us/op 1.8850 us/op 0.76
copy serialized SignedVoluntaryExit (112 B) 1.2530 us/op 1.6470 us/op 0.76
transfer serialized ProposerSlashing (416 B) 1.7780 us/op 2.1640 us/op 0.82
copy serialized ProposerSlashing (416 B) 1.7240 us/op 2.2650 us/op 0.76
transfer serialized Attestation (485 B) 1.4540 us/op 2.7200 us/op 0.53
copy serialized Attestation (485 B) 1.3660 us/op 2.9100 us/op 0.47
transfer serialized AttesterSlashing (33232 B) 1.5930 us/op 2.7460 us/op 0.58
copy serialized AttesterSlashing (33232 B) 4.3500 us/op 7.8540 us/op 0.55
transfer serialized Small SignedBeaconBlock (128000 B) 1.5300 us/op 2.8160 us/op 0.54
copy serialized Small SignedBeaconBlock (128000 B) 11.081 us/op 14.362 us/op 0.77
transfer serialized Avg SignedBeaconBlock (200000 B) 1.6810 us/op 3.1880 us/op 0.53
copy serialized Avg SignedBeaconBlock (200000 B) 17.780 us/op 23.747 us/op 0.75
transfer serialized BlobsSidecar (524380 B) 1.9980 us/op 3.2520 us/op 0.61
copy serialized BlobsSidecar (524380 B) 68.334 us/op 92.329 us/op 0.74
transfer serialized Big SignedBeaconBlock (1000000 B) 2.1560 us/op 3.5780 us/op 0.60
copy serialized Big SignedBeaconBlock (1000000 B) 122.64 us/op 360.78 us/op 0.34
pass gossip attestations to forkchoice per slot 2.5582 ms/op 3.8700 ms/op 0.66
forkChoice updateHead vc 100000 bc 64 eq 0 427.52 us/op 681.37 us/op 0.63
forkChoice updateHead vc 600000 bc 64 eq 0 3.4571 ms/op 4.5565 ms/op 0.76
forkChoice updateHead vc 1000000 bc 64 eq 0 5.6581 ms/op 8.2263 ms/op 0.69
forkChoice updateHead vc 600000 bc 320 eq 0 2.7168 ms/op 4.4566 ms/op 0.61
forkChoice updateHead vc 600000 bc 1200 eq 0 2.7625 ms/op 4.5478 ms/op 0.61
forkChoice updateHead vc 600000 bc 7200 eq 0 3.3197 ms/op 5.8192 ms/op 0.57
forkChoice updateHead vc 600000 bc 64 eq 1000 9.8809 ms/op 11.974 ms/op 0.83
forkChoice updateHead vc 600000 bc 64 eq 10000 9.7113 ms/op 12.927 ms/op 0.75
forkChoice updateHead vc 600000 bc 64 eq 300000 11.912 ms/op 16.684 ms/op 0.71
computeDeltas 500000 validators 300 proto nodes 2.9780 ms/op 6.4984 ms/op 0.46
computeDeltas 500000 validators 1200 proto nodes 2.9999 ms/op 6.2674 ms/op 0.48
computeDeltas 500000 validators 7200 proto nodes 3.0211 ms/op 6.3189 ms/op 0.48
computeDeltas 750000 validators 300 proto nodes 4.5468 ms/op 9.7302 ms/op 0.47
computeDeltas 750000 validators 1200 proto nodes 4.4666 ms/op 9.6109 ms/op 0.46
computeDeltas 750000 validators 7200 proto nodes 4.5692 ms/op 9.6803 ms/op 0.47
computeDeltas 1400000 validators 300 proto nodes 8.7369 ms/op 18.168 ms/op 0.48
computeDeltas 1400000 validators 1200 proto nodes 8.8042 ms/op 18.231 ms/op 0.48
computeDeltas 1400000 validators 7200 proto nodes 8.8514 ms/op 17.955 ms/op 0.49
computeDeltas 2100000 validators 300 proto nodes 12.927 ms/op 27.389 ms/op 0.47
computeDeltas 2100000 validators 1200 proto nodes 13.260 ms/op 26.923 ms/op 0.49
computeDeltas 2100000 validators 7200 proto nodes 13.070 ms/op 26.805 ms/op 0.49
computeProposerBoostScoreFromBalances 500000 validators 2.7048 ms/op 3.2360 ms/op 0.84
computeProposerBoostScoreFromBalances 750000 validators 2.6468 ms/op 3.2414 ms/op 0.82
computeProposerBoostScoreFromBalances 1400000 validators 2.7978 ms/op 3.2422 ms/op 0.86
computeProposerBoostScoreFromBalances 2100000 validators 2.7856 ms/op 3.2674 ms/op 0.85
altair processAttestation - 250000 vs - 7PWei normalcase 1.6306 ms/op 3.0804 ms/op 0.53
altair processAttestation - 250000 vs - 7PWei worstcase 2.1358 ms/op 3.1786 ms/op 0.67
altair processAttestation - setStatus - 1/6 committees join 100.55 us/op 169.63 us/op 0.59
altair processAttestation - setStatus - 1/3 committees join 199.57 us/op 339.33 us/op 0.59
altair processAttestation - setStatus - 1/2 committees join 262.90 us/op 447.46 us/op 0.59
altair processAttestation - setStatus - 2/3 committees join 368.50 us/op 569.33 us/op 0.65
altair processAttestation - setStatus - 4/5 committees join 454.21 us/op 772.04 us/op 0.59
altair processAttestation - setStatus - 100% committees join 568.23 us/op 888.12 us/op 0.64
altair processBlock - 250000 vs - 7PWei normalcase 5.2737 ms/op 8.9171 ms/op 0.59
altair processBlock - 250000 vs - 7PWei normalcase hashState 24.028 ms/op 32.873 ms/op 0.73
altair processBlock - 250000 vs - 7PWei worstcase 30.589 ms/op 40.568 ms/op 0.75
altair processBlock - 250000 vs - 7PWei worstcase hashState 69.390 ms/op 88.037 ms/op 0.79
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9059 ms/op 2.9373 ms/op 0.65
phase0 processBlock - 250000 vs - 7PWei worstcase 24.103 ms/op 31.095 ms/op 0.78
altair processEth1Data - 250000 vs - 7PWei normalcase 265.26 us/op 592.04 us/op 0.45
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 5.4020 us/op 11.834 us/op 0.46
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 29.944 us/op 41.951 us/op 0.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.7210 us/op 27.519 us/op 0.32
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.9180 us/op 16.167 us/op 0.43
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 73.403 us/op 158.60 us/op 0.46
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 759.75 us/op 1.6127 ms/op 0.47
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 876.38 us/op 1.7815 ms/op 0.49
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.1424 ms/op 1.8483 ms/op 0.62
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.3096 ms/op 3.8874 ms/op 0.59
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.3308 ms/op 2.4962 ms/op 0.53
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.4100 ms/op 6.1052 ms/op 0.56
Tree 40 250000 create 232.91 ms/op 410.38 ms/op 0.57
Tree 40 250000 get(125000) 115.27 ns/op 215.83 ns/op 0.53
Tree 40 250000 set(125000) 702.01 ns/op 1.0764 us/op 0.65
Tree 40 250000 toArray() 17.960 ms/op 23.985 ms/op 0.75
Tree 40 250000 iterate all - toArray() + loop 18.698 ms/op 22.010 ms/op 0.85
Tree 40 250000 iterate all - get(i) 45.289 ms/op 73.569 ms/op 0.62
MutableVector 250000 create 9.1369 ms/op 14.899 ms/op 0.61
MutableVector 250000 get(125000) 5.5740 ns/op 7.2460 ns/op 0.77
MutableVector 250000 set(125000) 210.36 ns/op 311.21 ns/op 0.68
MutableVector 250000 toArray() 2.6376 ms/op 4.0712 ms/op 0.65
MutableVector 250000 iterate all - toArray() + loop 2.2574 ms/op 4.1555 ms/op 0.54
MutableVector 250000 iterate all - get(i) 1.3550 ms/op 1.6079 ms/op 0.84
Array 250000 create 2.3393 ms/op 3.6012 ms/op 0.65
Array 250000 clone - spread 909.63 us/op 1.1439 ms/op 0.80
Array 250000 get(125000) 0.46600 ns/op 0.61100 ns/op 0.76
Array 250000 set(125000) 0.53500 ns/op 0.71500 ns/op 0.75
Array 250000 iterate all - loop 77.148 us/op 88.407 us/op 0.87
effectiveBalanceIncrements clone Uint8Array 300000 11.825 us/op 48.265 us/op 0.25
effectiveBalanceIncrements clone MutableVector 300000 255.00 ns/op 294.00 ns/op 0.87
effectiveBalanceIncrements rw all Uint8Array 300000 174.13 us/op 182.89 us/op 0.95
effectiveBalanceIncrements rw all MutableVector 300000 60.064 ms/op 92.827 ms/op 0.65
phase0 afterProcessEpoch - 250000 vs - 7PWei 76.630 ms/op 125.31 ms/op 0.61
phase0 beforeProcessEpoch - 250000 vs - 7PWei 31.005 ms/op 44.660 ms/op 0.69
altair processEpoch - mainnet_e81889 390.79 ms/op 483.13 ms/op 0.81
mainnet_e81889 - altair beforeProcessEpoch 51.316 ms/op 71.562 ms/op 0.72
mainnet_e81889 - altair processJustificationAndFinalization 6.9860 us/op 20.719 us/op 0.34
mainnet_e81889 - altair processInactivityUpdates 4.9706 ms/op 9.7143 ms/op 0.51
mainnet_e81889 - altair processRewardsAndPenalties 53.652 ms/op 69.842 ms/op 0.77
mainnet_e81889 - altair processRegistryUpdates 1.0050 us/op 3.5720 us/op 0.28
mainnet_e81889 - altair processSlashings 207.00 ns/op 592.00 ns/op 0.35
mainnet_e81889 - altair processEth1DataReset 210.00 ns/op 1.8570 us/op 0.11
mainnet_e81889 - altair processEffectiveBalanceUpdates 921.90 us/op 1.2991 ms/op 0.71
mainnet_e81889 - altair processSlashingsReset 2.7930 us/op 5.6540 us/op 0.49
mainnet_e81889 - altair processRandaoMixesReset 1.6990 us/op 8.7170 us/op 0.19
mainnet_e81889 - altair processHistoricalRootsUpdate 286.00 ns/op 1.6220 us/op 0.18
mainnet_e81889 - altair processParticipationFlagUpdates 820.00 ns/op 3.5140 us/op 0.23
mainnet_e81889 - altair processSyncCommitteeUpdates 254.00 ns/op 461.00 ns/op 0.55
mainnet_e81889 - altair afterProcessEpoch 82.603 ms/op 130.79 ms/op 0.63
capella processEpoch - mainnet_e217614 1.3237 s/op 1.4751 s/op 0.90
mainnet_e217614 - capella beforeProcessEpoch 208.14 ms/op 243.60 ms/op 0.85
mainnet_e217614 - capella processJustificationAndFinalization 6.7100 us/op 13.547 us/op 0.50
mainnet_e217614 - capella processInactivityUpdates 18.087 ms/op 19.425 ms/op 0.93
mainnet_e217614 - capella processRewardsAndPenalties 218.59 ms/op 267.01 ms/op 0.82
mainnet_e217614 - capella processRegistryUpdates 11.689 us/op 25.100 us/op 0.47
mainnet_e217614 - capella processSlashings 216.00 ns/op 1.0010 us/op 0.22
mainnet_e217614 - capella processEth1DataReset 204.00 ns/op 997.00 ns/op 0.20
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.2738 ms/op 4.9883 ms/op 0.66
mainnet_e217614 - capella processSlashingsReset 916.00 ns/op 4.4970 us/op 0.20
mainnet_e217614 - capella processRandaoMixesReset 1.6530 us/op 7.0010 us/op 0.24
mainnet_e217614 - capella processHistoricalRootsUpdate 215.00 ns/op 1.0020 us/op 0.21
mainnet_e217614 - capella processParticipationFlagUpdates 665.00 ns/op 2.6010 us/op 0.26
mainnet_e217614 - capella afterProcessEpoch 206.60 ms/op 308.08 ms/op 0.67
phase0 processEpoch - mainnet_e58758 360.39 ms/op 472.98 ms/op 0.76
mainnet_e58758 - phase0 beforeProcessEpoch 98.477 ms/op 137.97 ms/op 0.71
mainnet_e58758 - phase0 processJustificationAndFinalization 7.9130 us/op 14.728 us/op 0.54
mainnet_e58758 - phase0 processRewardsAndPenalties 39.919 ms/op 64.073 ms/op 0.62
mainnet_e58758 - phase0 processRegistryUpdates 4.1660 us/op 8.8010 us/op 0.47
mainnet_e58758 - phase0 processSlashings 210.00 ns/op 442.00 ns/op 0.48
mainnet_e58758 - phase0 processEth1DataReset 351.00 ns/op 395.00 ns/op 0.89
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 746.11 us/op 1.3502 ms/op 0.55
mainnet_e58758 - phase0 processSlashingsReset 824.00 ns/op 2.1510 us/op 0.38
mainnet_e58758 - phase0 processRandaoMixesReset 1.6370 us/op 3.8620 us/op 0.42
mainnet_e58758 - phase0 processHistoricalRootsUpdate 219.00 ns/op 392.00 ns/op 0.56
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.3490 us/op 3.9590 us/op 0.59
mainnet_e58758 - phase0 afterProcessEpoch 68.615 ms/op 98.021 ms/op 0.70
phase0 processEffectiveBalanceUpdates - 250000 normalcase 926.24 us/op 1.2183 ms/op 0.76
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1296 ms/op 1.4434 ms/op 0.78
altair processInactivityUpdates - 250000 normalcase 15.649 ms/op 18.467 ms/op 0.85
altair processInactivityUpdates - 250000 worstcase 13.295 ms/op 17.805 ms/op 0.75
phase0 processRegistryUpdates - 250000 normalcase 3.1640 us/op 8.0800 us/op 0.39
phase0 processRegistryUpdates - 250000 badcase_full_deposits 223.36 us/op 354.29 us/op 0.63
phase0 processRegistryUpdates - 250000 worstcase 0.5 108.30 ms/op 137.21 ms/op 0.79
altair processRewardsAndPenalties - 250000 normalcase 60.115 ms/op 64.043 ms/op 0.94
altair processRewardsAndPenalties - 250000 worstcase 57.622 ms/op 63.043 ms/op 0.91
phase0 getAttestationDeltas - 250000 normalcase 5.0812 ms/op 7.7017 ms/op 0.66
phase0 getAttestationDeltas - 250000 worstcase 5.2023 ms/op 7.9561 ms/op 0.65
phase0 processSlashings - 250000 worstcase 1.5424 ms/op 2.4566 ms/op 0.63
altair processSyncCommitteeUpdates - 250000 101.76 ms/op 149.66 ms/op 0.68
BeaconState.hashTreeRoot - No change 212.00 ns/op 303.00 ns/op 0.70
BeaconState.hashTreeRoot - 1 full validator 147.54 us/op 117.81 us/op 1.25
BeaconState.hashTreeRoot - 32 full validator 1.2196 ms/op 1.3607 ms/op 0.90
BeaconState.hashTreeRoot - 512 full validator 13.166 ms/op 17.552 ms/op 0.75
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 153.00 us/op 141.30 us/op 1.08
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.0758 ms/op 2.1121 ms/op 0.98
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 24.622 ms/op 28.832 ms/op 0.85
BeaconState.hashTreeRoot - 1 balances 118.33 us/op 174.26 us/op 0.68
BeaconState.hashTreeRoot - 32 balances 1.3806 ms/op 1.1055 ms/op 1.25
BeaconState.hashTreeRoot - 512 balances 12.208 ms/op 10.065 ms/op 1.21
BeaconState.hashTreeRoot - 250000 balances 191.99 ms/op 197.07 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 10.080 us/op 15.668 us/op 0.64
regular array get 100000 times 29.197 us/op 35.212 us/op 0.83
wrappedArray get 100000 times 29.194 us/op 33.061 us/op 0.88
arrayWithProxy get 100000 times 9.9009 ms/op 14.357 ms/op 0.69
ssz.Root.equals 148.00 ns/op 239.00 ns/op 0.62
byteArrayEquals 140.00 ns/op 230.00 ns/op 0.61
shuffle list - 16384 els 4.3310 ms/op 7.1618 ms/op 0.60
shuffle list - 250000 els 63.661 ms/op 104.75 ms/op 0.61
processSlot - 1 slots 14.000 us/op 17.748 us/op 0.79
processSlot - 32 slots 3.2633 ms/op 3.5846 ms/op 0.91
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 49.753 ms/op 53.647 ms/op 0.93
getCommitteeAssignments - req 1 vs - 250000 vc 2.2458 ms/op 2.5316 ms/op 0.89
getCommitteeAssignments - req 100 vs - 250000 vc 3.4006 ms/op 3.7378 ms/op 0.91
getCommitteeAssignments - req 1000 vs - 250000 vc 3.6527 ms/op 4.0918 ms/op 0.89
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 3.6700 ns/op 4.6100 ns/op 0.80
state getBlockRootAtSlot - 250000 vs - 7PWei 699.45 ns/op 621.36 ns/op 1.13
computeProposers - vc 250000 6.4078 ms/op 9.4198 ms/op 0.68
computeEpochShuffling - vc 250000 70.060 ms/op 106.77 ms/op 0.66
getNextSyncCommittee - vc 250000 100.99 ms/op 158.60 ms/op 0.64
computeSigningRoot for AttestationData 22.234 us/op 23.395 us/op 0.95
hash AttestationData serialized data then Buffer.toString(base64) 1.2474 us/op 2.3391 us/op 0.53
toHexString serialized data 815.70 ns/op 1.0950 us/op 0.74
Buffer.toString(base64) 148.77 ns/op 223.14 ns/op 0.67

by benchmarkbot/action

@yorickdowne yorickdowne mentioned this pull request Sep 13, 2023
Closed
@nflaig nflaig merged commit 6d8b42c into unstable Sep 13, 2023
11 checks passed
@nflaig nflaig deleted the nflaig/voluntary-exit-ignore-lockfiles branch September 13, 2023 23:21
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

@nflaig nflaig mentioned this pull request Jan 29, 2024
Merged
@nflaig nflaig mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain