feat: introduce EIP-6110 epoch and version in ChainConfig
#5953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
changed the title
ChainConfigChainConfig
g11tech
reviewed
Sep 12, 2023
| @@ -40,6 +40,9 @@ export type ChainConfig = { | |||
| // DENEB | |||
| DENEB_FORK_VERSION: Uint8Array; | |||
| DENEB_FORK_EPOCH: number; | |||
| // EIP6110 - Experimental fork | |||
| EIP6110_FORK_VERSION?: Uint8Array, | |||
There was a problem hiding this comment.
no need to make it optional, in the corresponding mainnet spec, add it and set its epoch to infinity
|
@naviechan I would prefer to not partially merge eip6110 components to our main release branch. Instead have a main branch for eip6110 with all the code, kind of like lighthouse do. We can latter down the line consider including into a main release, but not now. EDIT: Sorry did not read the PR description in depth. Still I don't understand why this PR is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the effort to implement #5366 .
Original intention was to implement changes to pubkey cache on unstable branch, and the actual EIP-6110 implementation on a separate branch. However, there is a need to have a fork gate on pubkey cache mentioned here #5937 (comment) .As such, there is a need to define the EIP-6110 fork in unstable branch.
This PR is to make as minimal change as possible to define EIP-6110 fork such that the development of fork gate on pubkey cache can continue.
Description
EIP6110_FORK_VERSIONandEIP6110_FORK_EPOCHinChainConfig.ChainConfig.