-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: set job status of e2e tests to passed after 15m timeout #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested changes
Oct 3, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
approved these changes
Oct 3, 2023
nflaig
changed the title
ci: set job status of e2e tests to passed if timeout is reached
ci: set job status of e2e tests to passed after 15m timeout
Oct 3, 2023
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5913
Description
E2E tests are sometimes stalling until timeout (6 hours) is reached but we know that after 15 minutes those should have passed already if there are no failed test cases. In this case, just set the job status to passed as there was likely no actual issue.
Regarding the formatting changes, there were a lot of extra white spaces for no good reason, diff comes from auto-formatting.