feat: support "input" param for verifiable tx #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using contract calls in web3js, the transaction data can either be filled in the "data" parameter or "input" parameter, default is "input" The current verified execution provider supports only "data" parameter, so code like this const contract = new web3.eth.Contract(balanceOfABI, tokenContract) let result = await contract.methods.balanceOf(tokenHolder).call(); doesn't work
|
|
nazarhussain
added
the
scope-light-clients
| @@ -181,7 +181,7 @@ export async function executeVMCall({ | |||
| gasLimit: hexToBigInt(gas ?? block.gasLimit), | |||
| gasPrice: hexToBigInt(gasPrice ?? maxPriorityFeePerGas ?? "0x0"), | |||
| value: hexToBigInt(value ?? "0x0"), | |||
| data: data ? hexToBuffer(data) : undefined, | |||
| data: input ? hexToBuffer(input) : data ? hexToBuffer(data) : undefined, | |||
There was a problem hiding this comment.
For future reference, data is deprecated and input is the new data field for ethereum transactions.
nazarhussain
approved these changes
Oct 11, 2023
|
🎉 This PR is included in v1.12.0 🎉 |
rdvorkin
added a commit
to rdvorkin/lodestar
that referenced
this pull request
Nov 9, 2023
This is a continuation of ChainSafe#6019 There is an additional fix needed, where tx.input support is added in case input is used instead of data
nazarhussain
pushed a commit
that referenced
this pull request
Nov 10, 2023
This is a continuation of #6019 There is an additional fix needed, where tx.input support is added in case input is used instead of data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using contract calls in web3js, the transaction data can either be filled in the "data" parameter or "input" parameter, default is "input"
The current verified execution provider supports only "data" parameter, so code like this
const contract = new web3.eth.Contract(balanceOfABI, tokenContract)
let result = await contract.methods.balanceOf(tokenHolder).call();
doesn't work