fix: the unknown block sync timeout #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
commented
Oct 11, 2023
| // So we are adding a particular delay to ensure that the `unknownBlockSync` is enabled. | ||
| const syncStartSlot = this.chain.clock.currentSlot; | ||
| // Having one epoch time for the node to connect to peers and start a syncing process | ||
| const epochCheckFotSyncSlot = syncStartSlot + SLOTS_PER_EPOCH; |
There was a problem hiding this comment.
I think one epoch would be enough time margin for a node to connect to peers and do the syncing before we start checking the sync progress. But this time could be changed based on node behavior.
There was a problem hiding this comment.
the comment and solution look great, I just don't feel right having this fix in prod code because onClockEpoch is designed to witness the genesis event as well.
Could you move this code to the above if/else code block for test code only? something like:
if (!opts.disableRangeSync) {
// prod code
...
this.chain.clock.on(ClockEvent.epoch, this.onClockEpoch);
} else {
// test code, this is needed for Unknown block sync sim test
...
// TODO: fix sim test here
}
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nazarhussain
added
the
scope-testing
wemeetagain
reviewed
Oct 12, 2023
| // So we are adding a particular delay to ensure that the `unknownBlockSync` is enabled. | ||
| const syncStartSlot = this.chain.clock.currentSlot; | ||
| // Having one epoch time for the node to connect to peers and start a syncing process | ||
| const epochCheckFotSyncSlot = syncStartSlot + SLOTS_PER_EPOCH; |
There was a problem hiding this comment.
Suggested change
| const epochCheckFotSyncSlot = syncStartSlot + SLOTS_PER_EPOCH; | |
| const epochCheckForSyncSlot = syncStartSlot + SLOTS_PER_EPOCH; |
There was a problem hiding this comment.
Will fix this typo in upcoming PR.
There was a problem hiding this comment.
Fixed by @tuyennhv already, see 1f36e8d
twoeths
approved these changes
Oct 13, 2023
|
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the sim tests stable.
Description
Found this edge case which was causing timeout for sim test quite often.
If a node is started on the epoch boundary then the
unknownBlockSyncget disabled and node hang up on the head.Steps to test or reproduce