Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add and support builder_boost_factor query param to produceBlockV3 api #6236
feat: add and support builder_boost_factor query param to produceBlockV3 api #6236
Changes from 8 commits
5b33d75
f8960af
4eefc31
41d1112
3e73ac8
0d13572
24925f2
deaaa1b
15948e8
0119cd9
bca1d63
a543e3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use uint here, the schema validation ensures there can't be negative values
lodestar/packages/api/src/utils/schema.ts
Lines 45 to 47 in b3e5621
This should address issues mentioned by @ensi321 in #6236 (comment) and #6236 (comment).
But I think the problem is that this only supports 32-bit integers but
2**64 - 1
needs to be allowed, based on openapi docs, we could add another uint type which support 64-bit integers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we can't for the exact reason you mentioned, if you want, could you pick that up as a followup (openapi one)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can improve the validation in a separate PR