Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in networking.md #6243

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

leonarddt05
Copy link
Contributor

There might be a typo in "one peers" which could be corrected to "once peers".

Thanks.

Motivation

Description

Closes #issue_number

Steps to test or reproduce

There might be a typo in "one peers" which could be corrected to "once peers".

Thanks.
@leonarddt05 leonarddt05 requested a review from a team as a code owner December 31, 2023 06:50
@CLAassistant
Copy link

CLAassistant commented Dec 31, 2023

CLA assistant check
All committers have signed the CLA.

@matthewkeil
Copy link
Member

matthewkeil commented Jan 2, 2024

Hi there! Thanks for noticing that and making the PR. We use conventional commits and the title of this PR will become the commit message. Please update it to the conventional commit standard. I would recommend something like docs: fix typo in networking.md

I actually just updated because I am about to deploy docs updates and I would love to include this in that run. Thanks for your submission @leonarddt05 !

@matthewkeil matthewkeil changed the title Update networking.md docs: fix typo in networking.md Jan 2, 2024
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@matthewkeil matthewkeil enabled auto-merge (squash) January 2, 2024 13:33
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #6243 (b3661c0) into unstable (5408bab) will not change coverage.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6243   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
=========================================
  Files           202      202           
  Lines         19579    19579           
  Branches       1167     1167           
=========================================
  Hits          15737    15737           
  Misses         3814     3814           
  Partials         28       28           

@matthewkeil matthewkeil merged commit 051b249 into ChainSafe:unstable Jan 2, 2024
14 of 16 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.14.0 🎉

ensi321 pushed a commit to ensi321/lodestar that referenced this pull request Jan 22, 2024
- typo in "one peers" was corrected to "once peers"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants