chore: use self-hosted runner for sim tests #6282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
approved these changes
Jan 10, 2024
| @@ -24,7 +24,7 @@ env: | |||
| jobs: | |||
| sim-merge-tests: | |||
| name: Sim merge tests | |||
| runs-on: buildjet-4vcpu-ubuntu-2204 | |||
| runs-on: Sim-Test-Github-runner | |||
There was a problem hiding this comment.
I see this in the runners tab. How does it wire through to point to Hetzner?
|
Note that external contributions won't run sim tests anymore, would be good to note that somewhere or make the host a dynamic |
|
Before going ahead with this, should there be another attempt to make sim tests stable without changing runners? Based on my observation before #6163 they at least passed if the CI was not overloaded but now they fail basically all the time. If it is really just the unknown block sync node we might be able to fix it. Where I think we definitely need a self-hosted runner is for the benchmarks, they take around 45 minutes at the moment and produce random false positives all the time. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sim tests are consistently flaky
Description
use newly provisioned self-hosted runner for sim tests