refactor: use for...of instead of forEach #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6307 +/- ##
============================================
- Coverage 80.38% 80.37% -0.01%
============================================
Files 202 202
Lines 19620 19622 +2
Branches 1176 1176
============================================
Hits 15771 15771
- Misses 3821 3823 +2
Partials 28 28 |
Performance Report✔️ no performance regression detected Full benchmark results
|
The video was not primarily about for loop performance, just comment in the video. I looked up a few benchmarks yesterday and for...of seems to be slightly better than forEach. Just now, I looked up a few more benchmarks and the results seem mixed though, I also just noticed this was discussed already #1845 (comment). But yeah primary reason is code consistency as we wanna avoid forEach, the points brought up by Lion in #1845 (comment) are more relevant than the performance part of it. If we wanna min-max the performance would likely have to use a regular for loop (based on all benchmarks) but that makes the code less readable in most cases and likely not worth it. |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
|
🎉 This PR is included in v1.15.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Code consistency, marginal performance improvements. I just watched video about node performance yesterday and it was brought up how bad forEach actually is especially if you iterate huge data sets, took this as a inspiration to give our forEach usage another review. We don't use it a lot but might as well clean up remaining forEach usage.
Description
Use for...of instead of forEach
Note: I did not update all occasions as it's either not relevant there in terms of performance or it is just a neat usage of forEach where for...of would make the code less readable.
There was plenty of previous work done by Lion related to this