Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to skip gossip validation #6308

Merged
merged 2 commits into from
Jan 16, 2024
Merged

feat: allow to skip gossip validation #6308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb5059c
Allow to skip gossip validation
nazarhussain Jan 16, 2024
ffeb5e0
Add code comment
nazarhussain Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/api/src/beacon/routes/beacon/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ export type BlockHeaderResponse = {
};

export enum BroadcastValidation {
/*
NOTE: The value `none` is not part of the spec.

In case a node is configured only with the unknownBlockSync, it needs to know the unknown parent blocks on the network
to initiate the syncing process. Such cases can be covered only if we publish blocks and make sure no gossip validation
is performed on those. But this behavior is not the default.
*/
none = "none",
nazarhussain marked this conversation as resolved.
Show resolved Hide resolved
gossip = "gossip",
consensus = "consensus",
consensusAndEquivocation = "consensus_and_equivocation",
Expand Down
5 changes: 5 additions & 0 deletions packages/beacon-node/src/api/impl/beacon/blocks/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ export function getBeaconBlockApi({
break;
}

case routes.beacon.BroadcastValidation.none: {
chain.logger.debug("Skipping broadcast validation", valLogMeta);
break;
}

default: {
// error or log warning we do not support this validation
const message = `Broadcast validation of ${broadcastValidation} type not implemented yet`;
Expand Down
Loading