chore: cleanup mocha/chai/sinon usage across the repo

.eslintrc.js

@@ -4,6 +4,7 @@ module.exports = {
     browser: true,
     es6: true,
     node: true,
+    // Performance tests still use mocha
     mocha: true,
   },
   globals: {
@@ -201,24 +202,18 @@ module.exports = {
     },
     {
       files: ["**/test/**/*.test.ts"],
-      plugins: ["mocha", "chai-expect"],
-      extends: ["plugin:mocha/recommended", "plugin:chai-expect/recommended"],
+      plugins: ["vitest"],
+      extends: ["plugin:vitest/recommended"],
       rules: {
-        // We observed that having multiple top level "describe" save valuable indentation
-        // https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/max-top-level-suites.md
-        "mocha/max-top-level-suites": "off",
-        // We need to disable because we disabled "mocha/no-setup-in-describe" rule
-        // TODO: Move all setup code to before/beforeEach and then disable async describe
-        // https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-async-describe.md
-        "mocha/no-async-describe": "off",
-        // Use of arrow functions are very common
-        "mocha/no-mocha-arrows": "off",
-        // It's common to call function inside describe block
-        // https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-setup-in-describe.md
-        "mocha/no-setup-in-describe": "off",
-        // We use to split before in small isolated tasks
-        // https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-sibling-hooks.md
-        "mocha/no-sibling-hooks": "off",
+        "vitest/consistent-test-it": ["error", {fn: "it", withinDescribe: "it"}],
+        // We use a lot dynamic assertions so tests may not have usage of expect
+        "vitest/expect-expect": "off",                
+        "vitest/no-disabled-tests": "error",
+        "vitest/no-focused-tests": "error",
+        "vitest/prefer-called-with": "error",
+        "vitest/prefer-spy-on": "error",
+        // Our usage contains dynamic test title, this rule enforce static string value
+        "vitest/valid-title": "off",
       },
     },
     {

CONTRIBUTING.md

@@ -42,12 +42,12 @@ Contributing to tests:
 ### Debugging Spec Tests
 
 - To fix errors always focus on passing all minimal tests first without running mainnet tests.
-- Spec tests often compare full expected vs actual states in JSON format. To better understand the diff it's convenient to use mocha's option `--inline-diffs`.
-- A single logical error can cause many spec tests to fail. To focus on a single test at a time you can use mocha's option `--bail` to stop at the first failed test
-- To then run only that failed test you can run against a specific file as use mocha's option `--grep` to run only one case
+- Spec tests often compare full expected vs actual states in JSON format.
+- A single logical error can cause many spec tests to fail. To focus on a single test at a time you can use vitest's option `--bail` to stop at the first failed test
+- To then run only that failed test you can run against a specific file as use vitest's filters to run only one case
 
 ```sh
-LODESTAR_PRESET=minimal ../../node_modules/.bin/mocha --config .mocharc.spec.yml test/spec/phase0/sanity.test.ts --inline-diffs --bail --grep "attestation"
+LODESTAR_PRESET=minimal ../../node_modules/.bin/vitest --config vitest.config.spec.ts --run test/spec/phase0/sanity.test.ts
 ```
 
 ## Docker

docs/pages/contribution/testing/integration-tests.md

@@ -13,7 +13,7 @@ There are two ENV variables that are required to run this test:
 
 The command to run this test is:
 
-`EL_BINARY_DIR=g11tech/geth:withdrawals EL_SCRIPT_DIR=gethdocker yarn mocha test/sim/withdrawal-interop.test.ts`
+`EL_BINARY_DIR=g11tech/geth:withdrawals EL_SCRIPT_DIR=gethdocker yarn vitest --run test/sim/withdrawal-interop.test.ts`
 
 The images used by this test during CI are:
 

package.json

@@ -47,69 +47,45 @@
   "devDependencies": {
     "@chainsafe/eslint-plugin-node": "^11.2.3",
     "@dapplion/benchmark": "^0.2.4",
-    "@types/chai": "^4.3.6",
-    "@types/chai-as-promised": "^7.1.6",
-    "@types/mocha": "^10.0.1",
+    "@types/mocha": "^10.0.6",
     "@types/node": "^20.6.5",
-    "@types/sinon": "^10.0.16",
-    "@types/sinon-chai": "^3.2.9",
     "@typescript-eslint/eslint-plugin": "6.7.2",
     "@typescript-eslint/parser": "6.7.2",
-    "@vitest/coverage-v8": "^1.1.0",
-    "@vitest/browser": "^1.1.0",
-    "c8": "^8.0.1",
-    "chai": "^4.3.8",
-    "chai-as-promised": "^7.1.1",
+    "@vitest/coverage-v8": "^1.2.1",
+    "@vitest/browser": "^1.2.1",
     "codecov": "^3.8.3",
     "crypto-browserify": "^3.12.0",
     "electron": "^26.2.2",
     "eslint": "^8.50.0",
     "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-chai-expect": "^3.0.0",
     "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-mocha": "^10.2.0",
     "eslint-plugin-prettier": "^5.0.0",
+    "eslint-plugin-vitest": "^0.3.20",
     "https-browserify": "^1.0.0",
     "jsdom": "^23.0.1",
-    "karma": "^6.4.2",
-    "karma-chai": "^0.1.0",
-    "karma-chrome-launcher": "^3.2.0",
-    "karma-cli": "^2.0.0",
-    "karma-electron": "^7.3.0",
-    "karma-firefox-launcher": "^2.1.2",
-    "karma-mocha": "^2.0.1",
-    "karma-spec-reporter": "^0.0.36",
-    "karma-webpack": "^5.0.0",
     "lerna": "^7.3.0",
     "libp2p": "1.1.1",
     "mocha": "^10.2.0",
     "node-gyp": "^9.4.0",
     "npm-run-all": "^4.1.5",
-    "nyc": "^15.1.0",
     "path-browserify": "^1.0.1",
     "prettier": "^3.0.3",
     "process": "^0.11.10",
-    "resolve-typescript-plugin": "^2.0.1",
-    "sinon": "^16.0.0",
-    "sinon-chai": "^3.7.0",
     "stream-browserify": "^3.0.0",
     "stream-http": "^3.2.0",
     "supertest": "^6.3.3",
-    "ts-loader": "^9.4.4",
     "ts-node": "^10.9.1",
     "typescript": "^5.2.2",
     "typescript-docs-verifier": "^2.5.0",
-    "vite-plugin-node-polyfills": "^0.18.0",
+    "vite-plugin-node-polyfills": "^0.19.0",
     "vite-plugin-top-level-await": "^1.4.1",
-    "vitest": "^1.1.0",
-    "vitest-when": "^0.3.0",
+    "vitest": "^1.2.1",
+    "vitest-when": "^0.3.1",
     "wait-port": "^1.1.0",
-    "webdriverio": "^8.27.0",
-    "webpack": "^5.88.2"
+    "webdriverio": "^8.28.0"
   },
   "resolutions": {
     "dns-over-http-resolver": "^2.1.1",
-    "chai": "^4.3.10",
     "loupe": "^2.3.6",
     "vite": "^5.0.0"
   }

packages/api/package.json

@@ -65,7 +65,7 @@
     "lint:fix": "yarn run lint --fix",
     "pretest": "yarn run check-types",
     "test": "yarn test:unit && yarn test:e2e",
-    "test:unit": "vitest --run --dir test/unit/ --coverage",
+    "test:unit": "vitest --run --dir test/unit/",
     "check-readme": "typescript-docs-verifier"
   },
   "dependencies": {

packages/api/test/perf/compileRouteUrlFormater.test.ts

@@ -3,6 +3,7 @@ import {compileRouteUrlFormater} from "../../src/utils/urlFormat.js";
 /* eslint-disable no-console */
 
 describe("route parse", () => {
+  // eslint-disable-next-line vitest/no-disabled-tests
   it.skip("Benchmark compileRouteUrlFormater", () => {
     const path = "/eth/v1/validator/:name/attester/:epoch";
     const args = {epoch: 5, name: "HEAD"};

packages/api/test/utils/utils.ts

@@ -38,7 +38,6 @@ export function getTestServer(): {baseUrl: string; server: FastifyInstance} {
   return {baseUrl, server};
 }
 
-/** Type helper to get a Sinon mock object type with Api */
 export function getMockApi<Api extends Record<string, any>>(
   routeIds: Record<string, any>
 ): MockedObject<ServerApi<Api>> & ServerApi<Api> {

packages/api/vitest.config.ts

@@ -1,5 +1,5 @@
 import {defineConfig, mergeConfig} from "vitest/config";
-import vitestConfig from "../../vitest.base.config";
+import vitestConfig from "../../vitest.base.unit.config";
 
 export default mergeConfig(
   vitestConfig,

packages/beacon-node/package.json

@@ -77,15 +77,15 @@
     "lint:fix": "yarn run lint --fix",
     "pretest": "yarn run check-types",
     "test": "yarn test:unit && yarn test:e2e",
-    "test:unit:minimal": "vitest --run --segfaultRetry 3 --dir test/unit/ --coverage",
-    "test:unit:mainnet": "LODESTAR_PRESET=mainnet nyc --cache-dir .nyc_output/.cache -e .ts mocha 'test/unit-mainnet/**/*.test.ts'",
+    "test:unit:minimal": "vitest --run --segfaultRetry 3 --dir test/unit/",
+    "test:unit:mainnet": "LODESTAR_PRESET=mainnet vitest --run --dir test/unit-mainnet",
     "test:unit": "wrapper() { yarn test:unit:minimal $@ && yarn test:unit:mainnet $@; }; wrapper",
-    "test:e2e": "LODESTAR_PRESET=minimal vitest --run --segfaultRetry 3 --poolOptions.threads.singleThread true --dir test/e2e",
-    "test:sim": "mocha 'test/sim/**/*.test.ts'",
-    "test:sim:merge-interop": "mocha 'test/sim/merge-interop.test.ts'",
-    "test:sim:mergemock": "mocha 'test/sim/mergemock.test.ts'",
-    "test:sim:withdrawals": "mocha 'test/sim/withdrawal-interop.test.ts'",
-    "test:sim:blobs": "mocha 'test/sim/4844-interop.test.ts'",
+    "test:e2e": "LODESTAR_PRESET=minimal vitest --run --segfaultRetry 3 --config vitest.config.e2e.ts --dir test/e2e",
+    "test:sim": "vitest --run test/sim/**/*.test.ts",
+    "test:sim:merge-interop": "vitest --run test/sim/merge-interop.test.ts",
+    "test:sim:mergemock": "vitest --run test/sim/mergemock.test.ts",
+    "test:sim:withdrawals": "vitest --run test/sim/withdrawal-interop.test.ts",
+    "test:sim:blobs": "vitest --run test/sim/4844-interop.test.ts",
     "download-spec-tests": "node --loader=ts-node/esm test/spec/downloadTests.ts",
     "test:spec:bls": "vitest --run --config vitest.config.spec.ts --dir test/spec/bls/",
     "test:spec:general": "vitest --run --config vitest.config.spec.ts --dir test/spec/general/",

packages/beacon-node/test/e2e/api/impl/beacon/state/endpoint.test.ts

@@ -43,7 +43,7 @@ describe("beacon state api", function () {
     await bn.close();
   });
 
-  describe("getEpochCommittees", async () => {
+  describe("getEpochCommittees", () => {
     it("should return all committees for the given state", async () => {
       const res = await client.getEpochCommittees("head");
       ApiError.assert(res);