-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extend chiado config from gnosis config #6329
Conversation
@@ -41,4 +40,7 @@ export const gnosisChainConfig: ChainConfig = { | |||
// Capella | |||
CAPELLA_FORK_VERSION: b("0x03000064"), | |||
CAPELLA_FORK_EPOCH: 648704, // 2023-08-01T11:34:20.000Z | |||
// Deneb | |||
DENEB_FORK_VERSION: b("0x04000064"), | |||
DENEB_FORK_EPOCH: Infinity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to safe guard against previous issue
See fix for the issue
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6329 +/- ##
=========================================
Coverage 76.61% 76.61%
=========================================
Files 248 248
Lines 25898 25898
Branches 1448 1448
=========================================
Hits 19842 19842
Misses 6026 6026
Partials 30 30 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
🎉 This PR is included in v1.15.0 🎉 |
Motivation
As noted in #6284 (comment) is might better to extend the chiado config from the gnosis config instead of mainnet.
Both networks override the same mainnet values, there are of course a few values (e.g.
DEPOSIT_CHAIN_ID
) that chiado still needs to override but this reduces maintenance of network configs and makes overall config more robust / less error prone.Description
Extend chiado config from gnosis config
I verified that config of both networks did not change by comparing the results of
/eth/v1/config/spec
. Also made sure we are still able to join the networks.Note: This PR does not yet schedule Deneb fork on chiado (#6284)