Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log errors setting agent version as debug #6374

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix: log errors setting agent version as debug #6374

merged 3 commits into from
Feb 1, 2024

Conversation

matthewkeil
Copy link
Member

@matthewkeil matthewkeil commented Jan 30, 2024 •
edited by nflaig
Loading

Motivation

Seeing an error when attempting to setAgent for a peer that is no longer in the peerStore

@wemeetagain @tuyennhv Do you think this error should be skipped because its just a result of peer churn and the info already being removed from the DB or do you think its worth making it a debug statement?

Resolves #6365

Description

Log errors setting agent version as debug

Add check for leveldb NotFound error and do not log as its an anticipated error.

NOTE: Double checking the leveldb code where this originates to see if there is a better way to filter for the error. Will move to readyToReveiw once complete

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

Merging #6374 (e8be145) into unstable (6adbd27) will increase coverage by 0.01%.
Report is 13 commits behind head on unstable.
The diff coverage is n/a.

❗ Current head e8be145 differs from pull request most recent head 473a445. Consider uploading reports for the commit 473a445 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6374      +/-   ##
============================================
+ Coverage     60.14%   60.16%   +0.01%     
============================================
  Files           407      407              
  Lines         46486    46514      +28     
  Branches       1545     1550       +5     
============================================
+ Hits          27957    27983      +26     
- Misses        18497    18499       +2     
  Partials         32       32

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: b935af8 Previous: 8e0078b Ratio
Set add up to 64 items then delete first 1.7450 us/op 5.8431 us/op 0.30
OrderedSet add up to 64 items then delete first 2.5322 us/op 7.6546 us/op 0.33
Set add up to 64 items then delete last 1.8343 us/op 5.9177 us/op 0.31
Set add up to 64 items then delete middle 1.8295 us/op 6.0506 us/op 0.30
Set add up to 128 items then delete first 3.6254 us/op 12.024 us/op 0.30
Set add up to 128 items then delete last 3.5060 us/op 11.682 us/op 0.30
Set add up to 128 items then delete middle 3.4960 us/op 11.795 us/op 0.30
Set add up to 256 items then delete first 7.1258 us/op 24.679 us/op 0.29
OrderedSet add up to 256 items then delete first 11.479 us/op 34.445 us/op 0.33
Set add up to 256 items then delete last 6.9590 us/op 24.621 us/op 0.28
Set add up to 256 items then delete middle 7.0725 us/op 24.987 us/op 0.28
forkChoice updateHead vc 600000 bc 64 eq 300000 12.011 ms/op 47.389 ms/op 0.25
computeDeltas 500000 validators 7200 proto nodes 2.8874 ms/op 8.7089 ms/op 0.33
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.0610 us/op 33.173 us/op 0.24
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 863.13 us/op 2.9463 ms/op 0.29
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.0091 ms/op 8.5627 ms/op 0.23
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.4705 ms/op 4.6132 ms/op 0.32
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.5175 ms/op 13.301 ms/op 0.26
Full benchmark results
Benchmark suite Current: b935af8 Previous: 8e0078b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 922.83 us/op 617.39 us/op 1.49
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 51.963 us/op 114.45 us/op 0.45
BLS verify - blst-native 1.0944 ms/op 1.3944 ms/op 0.78
BLS verifyMultipleSignatures 3 - blst-native 2.3329 ms/op 2.9516 ms/op 0.79
BLS verifyMultipleSignatures 8 - blst-native 5.1557 ms/op 6.5923 ms/op 0.78
BLS verifyMultipleSignatures 32 - blst-native 18.928 ms/op 23.902 ms/op 0.79
BLS verifyMultipleSignatures 64 - blst-native 37.263 ms/op 48.295 ms/op 0.77
BLS verifyMultipleSignatures 128 - blst-native 74.016 ms/op 92.325 ms/op 0.80
BLS deserializing 10000 signatures 779.07 ms/op 1.0184 s/op 0.76
BLS deserializing 100000 signatures 8.0638 s/op 9.9473 s/op 0.81
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.0888 ms/op 1.5695 ms/op 0.69
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.2303 ms/op 1.6098 ms/op 0.76
BLS verifyMultipleSignatures - same message - 32 - blst-native 1.9342 ms/op 2.5048 ms/op 0.77
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8171 ms/op 3.7129 ms/op 1.03
BLS verifyMultipleSignatures - same message - 128 - blst-native 4.9298 ms/op 6.1040 ms/op 0.81
BLS aggregatePubkeys 32 - blst-native 22.618 us/op 28.445 us/op 0.80
BLS aggregatePubkeys 128 - blst-native 87.786 us/op 113.88 us/op 0.77
getAttestationsForBlock 33.544 ms/op 63.622 ms/op 0.53
getSlashingsAndExits - default max 130.27 us/op 360.85 us/op 0.36
getSlashingsAndExits - 2k 294.22 us/op 782.04 us/op 0.38
proposeBlockBody type=full, size=empty 3.8921 ms/op 7.4375 ms/op 0.52
isKnown best case - 1 super set check 320.00 ns/op 719.00 ns/op 0.45
isKnown normal case - 2 super set checks 311.00 ns/op 711.00 ns/op 0.44
isKnown worse case - 16 super set checks 315.00 ns/op 691.00 ns/op 0.46
CheckpointStateCache - add get delete 3.4070 us/op 7.3040 us/op 0.47
validate api signedAggregateAndProof - struct 2.2745 ms/op 3.0713 ms/op 0.74
validate gossip signedAggregateAndProof - struct 2.2771 ms/op 3.1482 ms/op 0.72
validate gossip attestation - vc 640000 1.1142 ms/op 1.5880 ms/op 0.70
batch validate gossip attestation - vc 640000 - chunk 32 132.88 us/op 195.87 us/op 0.68
batch validate gossip attestation - vc 640000 - chunk 64 116.37 us/op 161.15 us/op 0.72
batch validate gossip attestation - vc 640000 - chunk 128 109.96 us/op 164.14 us/op 0.67
batch validate gossip attestation - vc 640000 - chunk 256 110.26 us/op 164.90 us/op 0.67
pickEth1Vote - no votes 848.66 us/op 1.5164 ms/op 0.56
pickEth1Vote - max votes 6.4425 ms/op 13.758 ms/op 0.47
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.718 ms/op 27.329 ms/op 0.50
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 20.428 ms/op 40.462 ms/op 0.50
pickEth1Vote - Eth1Data fastSerialize value x2048 405.64 us/op 791.95 us/op 0.51
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.4562 ms/op 7.5231 ms/op 0.59
bytes32 toHexString 443.00 ns/op 831.00 ns/op 0.53
bytes32 Buffer.toString(hex) 309.00 ns/op 345.00 ns/op 0.90
bytes32 Buffer.toString(hex) from Uint8Array 398.00 ns/op 584.00 ns/op 0.68
bytes32 Buffer.toString(hex) + 0x 293.00 ns/op 386.00 ns/op 0.76
Object access 1 prop 0.19100 ns/op 0.22500 ns/op 0.85
Map access 1 prop 0.19200 ns/op 0.17000 ns/op 1.13
Object get x1000 5.6220 ns/op 8.2730 ns/op 0.68
Map get x1000 0.71400 ns/op 0.90700 ns/op 0.79
Object set x1000 25.258 ns/op 73.653 ns/op 0.34
Map set x1000 16.872 ns/op 47.312 ns/op 0.36
Return object 10000 times 0.22450 ns/op 0.26070 ns/op 0.86
Throw Error 10000 times 2.6792 us/op 4.1312 us/op 0.65
fastMsgIdFn sha256 / 200 bytes 1.9800 us/op 3.5370 us/op 0.56
fastMsgIdFn h32 xxhash / 200 bytes 287.00 ns/op 360.00 ns/op 0.80
fastMsgIdFn h64 xxhash / 200 bytes 337.00 ns/op 389.00 ns/op 0.87
fastMsgIdFn sha256 / 1000 bytes 6.1670 us/op 12.086 us/op 0.51
fastMsgIdFn h32 xxhash / 1000 bytes 397.00 ns/op 472.00 ns/op 0.84
fastMsgIdFn h64 xxhash / 1000 bytes 409.00 ns/op 459.00 ns/op 0.89
fastMsgIdFn sha256 / 10000 bytes 52.124 us/op 111.28 us/op 0.47
fastMsgIdFn h32 xxhash / 10000 bytes 1.8060 us/op 2.1210 us/op 0.85
fastMsgIdFn h64 xxhash / 10000 bytes 1.2200 us/op 1.4740 us/op 0.83
send data - 1000 256B messages 11.579 ms/op 24.364 ms/op 0.48
send data - 1000 512B messages 15.118 ms/op 30.186 ms/op 0.50
send data - 1000 1024B messages 25.557 ms/op 45.249 ms/op 0.56
send data - 1000 1200B messages 29.927 ms/op 28.747 ms/op 1.04
send data - 1000 2048B messages 21.923 ms/op 50.893 ms/op 0.43
send data - 1000 4096B messages 32.312 ms/op 33.463 ms/op 0.97
send data - 1000 16384B messages 100.62 ms/op 131.04 ms/op 0.77
send data - 1000 65536B messages 384.02 ms/op 633.47 ms/op 0.61
enrSubnets - fastDeserialize 64 bits 939.00 ns/op 1.8700 us/op 0.50
enrSubnets - ssz BitVector 64 bits 412.00 ns/op 593.00 ns/op 0.69
enrSubnets - fastDeserialize 4 bits 199.00 ns/op 256.00 ns/op 0.78
enrSubnets - ssz BitVector 4 bits 413.00 ns/op 597.00 ns/op 0.69
prioritizePeers score -10:0 att 32-0.1 sync 2-0 69.837 us/op 135.66 us/op 0.51
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 75.054 us/op 171.59 us/op 0.44
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 101.04 us/op 240.60 us/op 0.42
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 173.61 us/op 392.51 us/op 0.44
prioritizePeers score 0:0 att 64-1 sync 4-1 198.30 us/op 430.30 us/op 0.46
array of 16000 items push then shift 1.2493 us/op 1.8678 us/op 0.67
LinkedList of 16000 items push then shift 5.8180 ns/op 12.834 ns/op 0.45
array of 16000 items push then pop 63.269 ns/op 151.31 ns/op 0.42
LinkedList of 16000 items push then pop 5.6630 ns/op 11.067 ns/op 0.51
array of 24000 items push then shift 1.8861 us/op 2.9391 us/op 0.64
LinkedList of 24000 items push then shift 5.8350 ns/op 12.638 ns/op 0.46
array of 24000 items push then pop 94.036 ns/op 181.77 ns/op 0.52
LinkedList of 24000 items push then pop 5.6330 ns/op 12.167 ns/op 0.46
intersect bitArray bitLen 8 4.9270 ns/op 8.3730 ns/op 0.59
intersect array and set length 8 48.100 ns/op 111.05 ns/op 0.43
intersect bitArray bitLen 128 27.611 ns/op 40.555 ns/op 0.68
intersect array and set length 128 677.23 ns/op 1.2634 us/op 0.54
bitArray.getTrueBitIndexes() bitLen 128 1.0730 us/op 2.1660 us/op 0.50
bitArray.getTrueBitIndexes() bitLen 248 1.8600 us/op 3.7100 us/op 0.50
bitArray.getTrueBitIndexes() bitLen 512 3.4590 us/op 7.3980 us/op 0.47
Buffer.concat 32 items 819.00 ns/op 1.2320 us/op 0.66
Uint8Array.set 32 items 1.5830 us/op 3.6720 us/op 0.43
Set add up to 64 items then delete first 1.7450 us/op 5.8431 us/op 0.30
OrderedSet add up to 64 items then delete first 2.5322 us/op 7.6546 us/op 0.33
Set add up to 64 items then delete last 1.8343 us/op 5.9177 us/op 0.31
OrderedSet add up to 64 items then delete last 2.7540 us/op 7.9448 us/op 0.35
Set add up to 64 items then delete middle 1.8295 us/op 6.0506 us/op 0.30
OrderedSet add up to 64 items then delete middle 3.8894 us/op 9.1783 us/op 0.42
Set add up to 128 items then delete first 3.6254 us/op 12.024 us/op 0.30
OrderedSet add up to 128 items then delete first 5.7099 us/op 16.719 us/op 0.34
Set add up to 128 items then delete last 3.5060 us/op 11.682 us/op 0.30
OrderedSet add up to 128 items then delete last 5.3060 us/op 15.570 us/op 0.34
Set add up to 128 items then delete middle 3.4960 us/op 11.795 us/op 0.30
OrderedSet add up to 128 items then delete middle 9.9608 us/op 21.657 us/op 0.46
Set add up to 256 items then delete first 7.1258 us/op 24.679 us/op 0.29
OrderedSet add up to 256 items then delete first 11.479 us/op 34.445 us/op 0.33
Set add up to 256 items then delete last 6.9590 us/op 24.621 us/op 0.28
OrderedSet add up to 256 items then delete last 10.819 us/op 32.265 us/op 0.34
Set add up to 256 items then delete middle 7.0725 us/op 24.987 us/op 0.28
OrderedSet add up to 256 items then delete middle 29.109 us/op 77.615 us/op 0.38
transfer serialized Status (84 B) 1.3890 us/op 2.9710 us/op 0.47
copy serialized Status (84 B) 1.1240 us/op 2.1270 us/op 0.53
transfer serialized SignedVoluntaryExit (112 B) 1.5140 us/op 2.7240 us/op 0.56
copy serialized SignedVoluntaryExit (112 B) 1.2150 us/op 2.5740 us/op 0.47
transfer serialized ProposerSlashing (416 B) 2.4460 us/op 3.2000 us/op 0.76
copy serialized ProposerSlashing (416 B) 2.3720 us/op 2.8790 us/op 0.82
transfer serialized Attestation (485 B) 2.4480 us/op 3.9270 us/op 0.62
copy serialized Attestation (485 B) 2.3450 us/op 3.6560 us/op 0.64
transfer serialized AttesterSlashing (33232 B) 2.5130 us/op 4.2940 us/op 0.59
copy serialized AttesterSlashing (33232 B) 5.4480 us/op 13.764 us/op 0.40
transfer serialized Small SignedBeaconBlock (128000 B) 2.3860 us/op 4.4400 us/op 0.54
copy serialized Small SignedBeaconBlock (128000 B) 12.324 us/op 34.275 us/op 0.36
transfer serialized Avg SignedBeaconBlock (200000 B) 2.4070 us/op 4.4230 us/op 0.54
copy serialized Avg SignedBeaconBlock (200000 B) 17.638 us/op 57.282 us/op 0.31
transfer serialized BlobsSidecar (524380 B) 2.0310 us/op 7.0430 us/op 0.29
copy serialized BlobsSidecar (524380 B) 69.577 us/op 148.76 us/op 0.47
transfer serialized Big SignedBeaconBlock (1000000 B) 2.1810 us/op 7.9340 us/op 0.27
copy serialized Big SignedBeaconBlock (1000000 B) 151.37 us/op 303.60 us/op 0.50
pass gossip attestations to forkchoice per slot 2.5433 ms/op 4.4389 ms/op 0.57
forkChoice updateHead vc 100000 bc 64 eq 0 418.39 us/op 803.41 us/op 0.52
forkChoice updateHead vc 600000 bc 64 eq 0 2.6262 ms/op 7.8331 ms/op 0.34
forkChoice updateHead vc 1000000 bc 64 eq 0 4.3240 ms/op 9.8985 ms/op 0.44
forkChoice updateHead vc 600000 bc 320 eq 0 2.5392 ms/op 5.0140 ms/op 0.51
forkChoice updateHead vc 600000 bc 1200 eq 0 2.6443 ms/op 5.9367 ms/op 0.45
forkChoice updateHead vc 600000 bc 7200 eq 0 3.2104 ms/op 6.9816 ms/op 0.46
forkChoice updateHead vc 600000 bc 64 eq 1000 9.2503 ms/op 14.239 ms/op 0.65
forkChoice updateHead vc 600000 bc 64 eq 10000 9.3782 ms/op 16.200 ms/op 0.58
forkChoice updateHead vc 600000 bc 64 eq 300000 12.011 ms/op 47.389 ms/op 0.25
computeDeltas 500000 validators 300 proto nodes 3.1359 ms/op 8.4517 ms/op 0.37
computeDeltas 500000 validators 1200 proto nodes 2.8601 ms/op 8.5761 ms/op 0.33
computeDeltas 500000 validators 7200 proto nodes 2.8874 ms/op 8.7089 ms/op 0.33
computeDeltas 750000 validators 300 proto nodes 4.3759 ms/op 10.857 ms/op 0.40
computeDeltas 750000 validators 1200 proto nodes 4.3280 ms/op 10.136 ms/op 0.43
computeDeltas 750000 validators 7200 proto nodes 4.4093 ms/op 9.9940 ms/op 0.44
computeDeltas 1400000 validators 300 proto nodes 8.3984 ms/op 20.503 ms/op 0.41
computeDeltas 1400000 validators 1200 proto nodes 8.4683 ms/op 20.515 ms/op 0.41
computeDeltas 1400000 validators 7200 proto nodes 8.7314 ms/op 20.044 ms/op 0.44
computeDeltas 2100000 validators 300 proto nodes 13.018 ms/op 30.565 ms/op 0.43
computeDeltas 2100000 validators 1200 proto nodes 13.200 ms/op 30.676 ms/op 0.43
computeDeltas 2100000 validators 7200 proto nodes 12.902 ms/op 34.842 ms/op 0.37
altair processAttestation - 250000 vs - 7PWei normalcase 2.5881 ms/op 3.9251 ms/op 0.66
altair processAttestation - 250000 vs - 7PWei worstcase 2.6172 ms/op 5.0812 ms/op 0.52
altair processAttestation - setStatus - 1/6 committees join 132.58 us/op 231.02 us/op 0.57
altair processAttestation - setStatus - 1/3 committees join 211.79 us/op 454.87 us/op 0.47
altair processAttestation - setStatus - 1/2 committees join 289.99 us/op 694.00 us/op 0.42
altair processAttestation - setStatus - 2/3 committees join 397.00 us/op 927.99 us/op 0.43
altair processAttestation - setStatus - 4/5 committees join 503.58 us/op 1.3660 ms/op 0.37
altair processAttestation - setStatus - 100% committees join 606.59 us/op 1.3830 ms/op 0.44
altair processBlock - 250000 vs - 7PWei normalcase 8.7681 ms/op 13.190 ms/op 0.66
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.597 ms/op 53.290 ms/op 0.54
altair processBlock - 250000 vs - 7PWei worstcase 28.836 ms/op 55.075 ms/op 0.52
altair processBlock - 250000 vs - 7PWei worstcase hashState 92.130 ms/op 122.83 ms/op 0.75
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2229 ms/op 4.0325 ms/op 0.55
phase0 processBlock - 250000 vs - 7PWei worstcase 25.401 ms/op 38.971 ms/op 0.65
altair processEth1Data - 250000 vs - 7PWei normalcase 292.85 us/op 823.33 us/op 0.36
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.0610 us/op 33.173 us/op 0.24
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 51.773 us/op 86.280 us/op 0.60
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 15.382 us/op 45.724 us/op 0.34
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 12.536 us/op 25.828 us/op 0.49
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 143.69 us/op 297.29 us/op 0.48
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0185 ms/op 2.4315 ms/op 0.42
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.1667 ms/op 2.9530 ms/op 0.40
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 863.13 us/op 2.9463 ms/op 0.29
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.0091 ms/op 8.5627 ms/op 0.23
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.4705 ms/op 4.6132 ms/op 0.32
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.5175 ms/op 13.301 ms/op 0.26
Tree 40 250000 create 250.54 ms/op 869.45 ms/op 0.29
Tree 40 250000 get(125000) 110.29 ns/op 247.78 ns/op 0.45
Tree 40 250000 set(125000) 721.21 ns/op 2.0297 us/op 0.36
Tree 40 250000 toArray() 9.7863 ms/op 27.116 ms/op 0.36
Tree 40 250000 iterate all - toArray() + loop 9.9372 ms/op 28.521 ms/op 0.35
Tree 40 250000 iterate all - get(i) 41.486 ms/op 92.382 ms/op 0.45
MutableVector 250000 create 11.231 ms/op 15.021 ms/op 0.75
MutableVector 250000 get(125000) 5.6660 ns/op 7.4480 ns/op 0.76
MutableVector 250000 set(125000) 216.81 ns/op 556.09 ns/op 0.39
MutableVector 250000 toArray() 2.2869 ms/op 5.6581 ms/op 0.40
MutableVector 250000 iterate all - toArray() + loop 2.4097 ms/op 5.5105 ms/op 0.44
MutableVector 250000 iterate all - get(i) 1.3306 ms/op 1.7519 ms/op 0.76
Array 250000 create 2.1153 ms/op 4.5500 ms/op 0.46
Array 250000 clone - spread 1.1393 ms/op 1.8480 ms/op 0.62
Array 250000 get(125000) 1.0210 ns/op 2.3450 ns/op 0.44
Array 250000 set(125000) 1.2620 ns/op 6.0340 ns/op 0.21
Array 250000 iterate all - loop 153.70 us/op 188.09 us/op 0.82
effectiveBalanceIncrements clone Uint8Array 300000 25.727 us/op 86.514 us/op 0.30
effectiveBalanceIncrements clone MutableVector 300000 412.00 ns/op 615.00 ns/op 0.67
effectiveBalanceIncrements rw all Uint8Array 300000 186.30 us/op 267.78 us/op 0.70
effectiveBalanceIncrements rw all MutableVector 300000 66.127 ms/op 183.10 ms/op 0.36
phase0 afterProcessEpoch - 250000 vs - 7PWei 78.562 ms/op 137.44 ms/op 0.57
phase0 beforeProcessEpoch - 250000 vs - 7PWei 51.248 ms/op 68.313 ms/op 0.75
altair processEpoch - mainnet_e81889 454.02 ms/op 672.75 ms/op 0.67
mainnet_e81889 - altair beforeProcessEpoch 79.953 ms/op 109.09 ms/op 0.73
mainnet_e81889 - altair processJustificationAndFinalization 11.414 us/op 20.782 us/op 0.55
mainnet_e81889 - altair processInactivityUpdates 4.2705 ms/op 6.3927 ms/op 0.67
mainnet_e81889 - altair processRewardsAndPenalties 63.313 ms/op 66.726 ms/op 0.95
mainnet_e81889 - altair processRegistryUpdates 1.2060 us/op 3.5800 us/op 0.34
mainnet_e81889 - altair processSlashings 582.00 ns/op 598.00 ns/op 0.97
mainnet_e81889 - altair processEth1DataReset 612.00 ns/op 523.00 ns/op 1.17
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.8395 ms/op 1.4640 ms/op 1.26
mainnet_e81889 - altair processSlashingsReset 3.1340 us/op 4.2990 us/op 0.73
mainnet_e81889 - altair processRandaoMixesReset 3.0790 us/op 5.5680 us/op 0.55
mainnet_e81889 - altair processHistoricalRootsUpdate 714.00 ns/op 910.00 ns/op 0.78
mainnet_e81889 - altair processParticipationFlagUpdates 1.0260 us/op 2.2000 us/op 0.47
mainnet_e81889 - altair processSyncCommitteeUpdates 706.00 ns/op 680.00 ns/op 1.04
mainnet_e81889 - altair afterProcessEpoch 81.963 ms/op 122.02 ms/op 0.67
capella processEpoch - mainnet_e217614 1.7341 s/op 2.2325 s/op 0.78
mainnet_e217614 - capella beforeProcessEpoch 422.96 ms/op 491.75 ms/op 0.86
mainnet_e217614 - capella processJustificationAndFinalization 12.700 us/op 18.924 us/op 0.67
mainnet_e217614 - capella processInactivityUpdates 17.058 ms/op 20.841 ms/op 0.82
mainnet_e217614 - capella processRewardsAndPenalties 368.57 ms/op 421.49 ms/op 0.87
mainnet_e217614 - capella processRegistryUpdates 14.943 us/op 17.249 us/op 0.87
mainnet_e217614 - capella processSlashings 560.00 ns/op 947.00 ns/op 0.59
mainnet_e217614 - capella processEth1DataReset 797.00 ns/op 668.00 ns/op 1.19
mainnet_e217614 - capella processEffectiveBalanceUpdates 7.1843 ms/op 4.8816 ms/op 1.47
mainnet_e217614 - capella processSlashingsReset 1.5050 us/op 3.0940 us/op 0.49
mainnet_e217614 - capella processRandaoMixesReset 1.8280 us/op 6.1190 us/op 0.30
mainnet_e217614 - capella processHistoricalRootsUpdate 558.00 ns/op 677.00 ns/op 0.82
mainnet_e217614 - capella processParticipationFlagUpdates 1.3080 us/op 1.3780 us/op 0.95
mainnet_e217614 - capella afterProcessEpoch 204.72 ms/op 331.58 ms/op 0.62
phase0 processEpoch - mainnet_e58758 400.71 ms/op 445.75 ms/op 0.90
mainnet_e58758 - phase0 beforeProcessEpoch 133.44 ms/op 127.22 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 11.523 us/op 15.252 us/op 0.76
mainnet_e58758 - phase0 processRewardsAndPenalties 54.784 ms/op 54.300 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 10.112 us/op 10.720 us/op 0.94
mainnet_e58758 - phase0 processSlashings 671.00 ns/op 544.00 ns/op 1.23
mainnet_e58758 - phase0 processEth1DataReset 498.00 ns/op 380.00 ns/op 1.31
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3925 ms/op 1.1574 ms/op 1.20
mainnet_e58758 - phase0 processSlashingsReset 2.1140 us/op 3.0310 us/op 0.70
mainnet_e58758 - phase0 processRandaoMixesReset 2.5940 us/op 3.8500 us/op 0.67
mainnet_e58758 - phase0 processHistoricalRootsUpdate 604.00 ns/op 383.00 ns/op 1.58
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.7930 us/op 3.7310 us/op 0.75
mainnet_e58758 - phase0 afterProcessEpoch 61.278 ms/op 95.607 ms/op 0.64
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0023 ms/op 1.4018 ms/op 0.72
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1340 ms/op 1.4869 ms/op 0.76
altair processInactivityUpdates - 250000 normalcase 26.892 ms/op 26.674 ms/op 1.01
altair processInactivityUpdates - 250000 worstcase 26.566 ms/op 28.973 ms/op 0.92
phase0 processRegistryUpdates - 250000 normalcase 7.8110 us/op 11.012 us/op 0.71
phase0 processRegistryUpdates - 250000 badcase_full_deposits 351.82 us/op 344.79 us/op 1.02
phase0 processRegistryUpdates - 250000 worstcase 0.5 120.33 ms/op 134.16 ms/op 0.90
altair processRewardsAndPenalties - 250000 normalcase 48.679 ms/op 58.718 ms/op 0.83
altair processRewardsAndPenalties - 250000 worstcase 45.848 ms/op 56.067 ms/op 0.82
phase0 getAttestationDeltas - 250000 normalcase 5.0057 ms/op 9.9482 ms/op 0.50
phase0 getAttestationDeltas - 250000 worstcase 5.5413 ms/op 9.6724 ms/op 0.57
phase0 processSlashings - 250000 worstcase 84.654 us/op 96.592 us/op 0.88
altair processSyncCommitteeUpdates - 250000 103.05 ms/op 147.94 ms/op 0.70
BeaconState.hashTreeRoot - No change 297.00 ns/op 363.00 ns/op 0.82
BeaconState.hashTreeRoot - 1 full validator 124.52 us/op 116.00 us/op 1.07
BeaconState.hashTreeRoot - 32 full validator 1.1540 ms/op 1.5648 ms/op 0.74
BeaconState.hashTreeRoot - 512 full validator 12.033 ms/op 14.608 ms/op 0.82
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 131.14 us/op 150.48 us/op 0.87
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.7050 ms/op 2.2036 ms/op 0.77
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 22.331 ms/op 29.053 ms/op 0.77
BeaconState.hashTreeRoot - 1 balances 86.226 us/op 134.96 us/op 0.64
BeaconState.hashTreeRoot - 32 balances 910.99 us/op 1.3077 ms/op 0.70
BeaconState.hashTreeRoot - 512 balances 8.5390 ms/op 12.200 ms/op 0.70
BeaconState.hashTreeRoot - 250000 balances 151.78 ms/op 183.60 ms/op 0.83
aggregationBits - 2048 els - zipIndexesInBitList 11.356 us/op 16.862 us/op 0.67
byteArrayEquals 32 64.805 ns/op 74.143 ns/op 0.87
Buffer.compare 32 37.832 ns/op 56.046 ns/op 0.68
byteArrayEquals 1024 1.6592 us/op 2.0288 us/op 0.82
Buffer.compare 1024 39.661 ns/op 70.616 ns/op 0.56
byteArrayEquals 16384 26.192 us/op 32.223 us/op 0.81
Buffer.compare 16384 220.10 ns/op 267.24 ns/op 0.82
byteArrayEquals 123687377 209.70 ms/op 244.77 ms/op 0.86
Buffer.compare 123687377 3.9137 ms/op 7.1235 ms/op 0.55
byteArrayEquals 32 - diff last byte 60.671 ns/op 75.675 ns/op 0.80
Buffer.compare 32 - diff last byte 38.011 ns/op 59.617 ns/op 0.64
byteArrayEquals 1024 - diff last byte 1.7010 us/op 2.0399 us/op 0.83
Buffer.compare 1024 - diff last byte 43.582 ns/op 73.845 ns/op 0.59
byteArrayEquals 16384 - diff last byte 27.610 us/op 32.432 us/op 0.85
Buffer.compare 16384 - diff last byte 229.33 ns/op 267.62 ns/op 0.86
byteArrayEquals 123687377 - diff last byte 191.98 ms/op 249.96 ms/op 0.77
Buffer.compare 123687377 - diff last byte 3.7215 ms/op 9.0306 ms/op 0.41
byteArrayEquals 32 - random bytes 4.5550 ns/op 6.5520 ns/op 0.70
Buffer.compare 32 - random bytes 37.405 ns/op 65.979 ns/op 0.57
byteArrayEquals 1024 - random bytes 4.2800 ns/op 8.5340 ns/op 0.50
Buffer.compare 1024 - random bytes 34.183 ns/op 64.582 ns/op 0.53
byteArrayEquals 16384 - random bytes 4.3180 ns/op 6.2390 ns/op 0.69
Buffer.compare 16384 - random bytes 34.076 ns/op 65.196 ns/op 0.52
byteArrayEquals 123687377 - random bytes 7.9900 ns/op 9.7700 ns/op 0.82
Buffer.compare 123687377 - random bytes 40.420 ns/op 78.270 ns/op 0.52
regular array get 100000 times 40.565 us/op 47.525 us/op 0.85
wrappedArray get 100000 times 40.460 us/op 47.178 us/op 0.86
arrayWithProxy get 100000 times 10.805 ms/op 16.231 ms/op 0.67
ssz.Root.equals 55.842 ns/op 56.399 ns/op 0.99
byteArrayEquals 54.054 ns/op 55.961 ns/op 0.97
Buffer.compare 9.5290 ns/op 12.222 ns/op 0.78
shuffle list - 16384 els 4.6118 ms/op 7.2316 ms/op 0.64
shuffle list - 250000 els 67.592 ms/op 107.00 ms/op 0.63
processSlot - 1 slots 14.648 us/op 18.352 us/op 0.80
processSlot - 32 slots 2.9729 ms/op 3.6113 ms/op 0.82
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 50.583 ms/op 62.722 ms/op 0.81
getCommitteeAssignments - req 1 vs - 250000 vc 2.1695 ms/op 2.6234 ms/op 0.83
getCommitteeAssignments - req 100 vs - 250000 vc 3.3208 ms/op 3.8874 ms/op 0.85
getCommitteeAssignments - req 1000 vs - 250000 vc 3.5857 ms/op 4.2470 ms/op 0.84
findModifiedValidators - 10000 modified validators 429.91 ms/op 564.57 ms/op 0.76
findModifiedValidators - 1000 modified validators 332.76 ms/op 460.08 ms/op 0.72
findModifiedValidators - 100 modified validators 304.45 ms/op 447.26 ms/op 0.68
findModifiedValidators - 10 modified validators 293.76 ms/op 411.23 ms/op 0.71
findModifiedValidators - 1 modified validators 300.13 ms/op 440.33 ms/op 0.68
findModifiedValidators - no difference 294.20 ms/op 441.15 ms/op 0.67
compare ViewDUs 3.8681 s/op 4.3526 s/op 0.89
compare each validator Uint8Array 1.5402 s/op 1.6041 s/op 0.96
compare ViewDU to Uint8Array 811.17 ms/op 1.2297 s/op 0.66
migrate state 1000000 validators, 24 modified, 0 new 702.44 ms/op 757.57 ms/op 0.93
migrate state 1000000 validators, 1700 modified, 1000 new 1.1140 s/op 1.0744 s/op 1.04
migrate state 1000000 validators, 3400 modified, 2000 new 1.4085 s/op 1.3090 s/op 1.08
migrate state 1500000 validators, 24 modified, 0 new 786.11 ms/op 785.38 ms/op 1.00
migrate state 1500000 validators, 1700 modified, 1000 new 876.30 ms/op 1.0850 s/op 0.81
migrate state 1500000 validators, 3400 modified, 2000 new 1.0925 s/op 1.3729 s/op 0.80
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.4000 ns/op 4.7100 ns/op 0.93
state getBlockRootAtSlot - 250000 vs - 7PWei 390.81 ns/op 830.52 ns/op 0.47
computeProposers - vc 250000 5.6567 ms/op 10.467 ms/op 0.54
computeEpochShuffling - vc 250000 70.335 ms/op 112.71 ms/op 0.62
getNextSyncCommittee - vc 250000 98.066 ms/op 163.61 ms/op 0.60
computeSigningRoot for AttestationData 17.129 us/op 31.390 us/op 0.55
hash AttestationData serialized data then Buffer.toString(base64) 1.2662 us/op 2.3971 us/op 0.53
toHexString serialized data 812.50 ns/op 1.1518 us/op 0.71
Buffer.toString(base64) 150.84 ns/op 232.75 ns/op 0.65

by benchmarkbot/action

@nflaig nflaig changed the title feat: ignore NotFound error for setting agentVersion fix: ignore NotFound error for setting agentVersion Jan 30, 2024
@matthewkeil matthewkeil marked this pull request as ready for review January 31, 2024 05:15
@matthewkeil matthewkeil requested a review from a team as a code owner January 31, 2024 05:15
@matthewkeil @nflaig
fix: remove NotFound check and only debug log error setting agentVersion
473a445 
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
@nflaig nflaig changed the title fix: ignore NotFound error for setting agentVersion fix: log errors setting agent version as debug Jan 31, 2024
@twoeths
Copy link
Contributor

twoeths commented Jan 31, 2024

there are so great benchmark statistics in this PR although there's nothing to do with it. I think at least we need to switch validator size to 1.5M instead of 250k for a lot of tests.

@matthewkeil
Copy link
Member Author

matthewkeil commented Jan 31, 2024 •
edited
Loading

there are so great benchmark statistics in this PR although there's nothing to do with it. I think at least we need to switch validator size to 1.5M instead of 250k for a lot of tests.

LOL!!! Nope... that was me just having "the 🥷 touch" like you do @tuyennhv .... those are all REAL i tell you!! ARE EEE AYE ELLE REAL!!!!

OK maybe you are right....

@nflaig nflaig enabled auto-merge (squash) February 1, 2024 08:30
@nflaig nflaig merged commit 6b732b0 into unstable Feb 1, 2024
15 of 17 checks passed
@nflaig nflaig deleted the mkeil/agent-version-not-found-error branch February 1, 2024 08:34
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error setting agentVersion for the peer
4 participants
@matthewkeil @twoeths @wemeetagain @nflaig