Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v1.15.1 release #6379

Merged
merged 4 commits into from
Feb 7, 2024
Merged

chore: v1.15.1 release #6379

merged 4 commits into from
Feb 7, 2024

Conversation

philknows
Copy link
Member

@philknows philknows commented Jan 30, 2024

Motivation

As discussed on Jan 30, we are adding hotfixes #6361 and #6363 to v1.15.1 for potential release.
Added #6403 to hotfix.

philknows and others added 3 commits January 30, 2024 12:41
* fix: ignore stale keystore lockfiles

* Update error message if lockfile is already acquired

* Update keymanager lockfile e2e tests
)

* fix: ignore forkchoice invalidations if latestValidHash not found

* rename for better understanding

* update the lvh search start index

* apply feedback
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: d9a7c8c Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 599.22 us/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 99.913 us/op
BLS verify - blst-native 1.3504 ms/op
BLS verifyMultipleSignatures 3 - blst-native 2.8571 ms/op
BLS verifyMultipleSignatures 8 - blst-native 6.2200 ms/op
BLS verifyMultipleSignatures 32 - blst-native 23.467 ms/op
BLS verifyMultipleSignatures 64 - blst-native 47.850 ms/op
BLS verifyMultipleSignatures 128 - blst-native 92.369 ms/op
BLS deserializing 10000 signatures 1.0016 s/op
BLS deserializing 100000 signatures 9.4452 s/op
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3801 ms/op
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5536 ms/op
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.4102 ms/op
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.5844 ms/op
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.9504 ms/op
BLS aggregatePubkeys 32 - blst-native 27.537 us/op
BLS aggregatePubkeys 128 - blst-native 102.53 us/op
getAttestationsForBlock 56.449 ms/op
getSlashingsAndExits - default max 243.72 us/op
getSlashingsAndExits - 2k 432.44 us/op
proposeBlockBody type=full, size=empty 6.5290 ms/op
isKnown best case - 1 super set check 422.00 ns/op
isKnown normal case - 2 super set checks 432.00 ns/op
isKnown worse case - 16 super set checks 524.00 ns/op
CheckpointStateCache - add get delete 6.1110 us/op
validate api signedAggregateAndProof - struct 2.9007 ms/op
validate gossip signedAggregateAndProof - struct 2.9145 ms/op
validate gossip attestation - vc 640000 1.4416 ms/op
batch validate gossip attestation - vc 640000 - chunk 32 184.50 us/op
batch validate gossip attestation - vc 640000 - chunk 64 163.22 us/op
batch validate gossip attestation - vc 640000 - chunk 128 155.73 us/op
batch validate gossip attestation - vc 640000 - chunk 256 143.43 us/op
pickEth1Vote - no votes 1.4559 ms/op
pickEth1Vote - max votes 10.181 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 23.040 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 32.152 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 708.32 us/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 8.2514 ms/op
bytes32 toHexString 712.00 ns/op
bytes32 Buffer.toString(hex) 299.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 517.00 ns/op
bytes32 Buffer.toString(hex) + 0x 316.00 ns/op
Object access 1 prop 0.20400 ns/op
Map access 1 prop 0.15600 ns/op
Object get x1000 7.5510 ns/op
Map get x1000 0.87300 ns/op
Object set x1000 56.756 ns/op
Map set x1000 48.381 ns/op
Return object 10000 times 0.25220 ns/op
Throw Error 10000 times 3.9983 us/op
fastMsgIdFn sha256 / 200 bytes 3.5690 us/op
fastMsgIdFn h32 xxhash / 200 bytes 406.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 405.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 11.949 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 526.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 491.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 107.95 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 2.1400 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.4740 us/op
send data - 1000 256B messages 24.001 ms/op
send data - 1000 512B messages 25.605 ms/op
send data - 1000 1024B messages 44.606 ms/op
send data - 1000 1200B messages 39.711 ms/op
send data - 1000 2048B messages 46.133 ms/op
send data - 1000 4096B messages 42.447 ms/op
send data - 1000 16384B messages 125.50 ms/op
send data - 1000 65536B messages 495.99 ms/op
enrSubnets - fastDeserialize 64 bits 2.0580 us/op
enrSubnets - ssz BitVector 64 bits 604.00 ns/op
enrSubnets - fastDeserialize 4 bits 249.00 ns/op
enrSubnets - ssz BitVector 4 bits 587.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 125.14 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.28 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 210.80 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 357.01 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 453.16 us/op
array of 16000 items push then shift 1.7901 us/op
LinkedList of 16000 items push then shift 9.4940 ns/op
array of 16000 items push then pop 114.12 ns/op
LinkedList of 16000 items push then pop 9.2720 ns/op
array of 24000 items push then shift 2.7615 us/op
LinkedList of 24000 items push then shift 9.4830 ns/op
array of 24000 items push then pop 154.08 ns/op
LinkedList of 24000 items push then pop 9.2090 ns/op
intersect bitArray bitLen 8 7.1680 ns/op
intersect array and set length 8 72.086 ns/op
intersect bitArray bitLen 128 34.919 ns/op
intersect array and set length 128 1.0125 us/op
bitArray.getTrueBitIndexes() bitLen 128 2.0450 us/op
bitArray.getTrueBitIndexes() bitLen 248 3.4830 us/op
bitArray.getTrueBitIndexes() bitLen 512 6.5920 us/op
Buffer.concat 32 items 1.1590 us/op
Uint8Array.set 32 items 2.1200 us/op
Set add up to 64 items then delete first 5.0929 us/op
OrderedSet add up to 64 items then delete first 7.1081 us/op
Set add up to 64 items then delete last 5.3950 us/op
OrderedSet add up to 64 items then delete last 7.3697 us/op
Set add up to 64 items then delete middle 5.7393 us/op
OrderedSet add up to 64 items then delete middle 9.3633 us/op
Set add up to 128 items then delete first 11.311 us/op
OrderedSet add up to 128 items then delete first 15.558 us/op
Set add up to 128 items then delete last 10.899 us/op
OrderedSet add up to 128 items then delete last 14.909 us/op
Set add up to 128 items then delete middle 11.193 us/op
OrderedSet add up to 128 items then delete middle 21.217 us/op
Set add up to 256 items then delete first 22.411 us/op
OrderedSet add up to 256 items then delete first 31.045 us/op
Set add up to 256 items then delete last 20.950 us/op
OrderedSet add up to 256 items then delete last 27.889 us/op
Set add up to 256 items then delete middle 21.414 us/op
OrderedSet add up to 256 items then delete middle 51.928 us/op
transfer serialized Status (84 B) 1.9430 us/op
copy serialized Status (84 B) 1.4820 us/op
transfer serialized SignedVoluntaryExit (112 B) 2.1660 us/op
copy serialized SignedVoluntaryExit (112 B) 1.5500 us/op
transfer serialized ProposerSlashing (416 B) 3.3550 us/op
copy serialized ProposerSlashing (416 B) 2.4640 us/op
transfer serialized Attestation (485 B) 2.8120 us/op
copy serialized Attestation (485 B) 2.5290 us/op
transfer serialized AttesterSlashing (33232 B) 2.7700 us/op
copy serialized AttesterSlashing (33232 B) 9.0280 us/op
transfer serialized Small SignedBeaconBlock (128000 B) 2.7590 us/op
copy serialized Small SignedBeaconBlock (128000 B) 24.850 us/op
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1320 us/op
copy serialized Avg SignedBeaconBlock (200000 B) 35.860 us/op
transfer serialized BlobsSidecar (524380 B) 3.6470 us/op
copy serialized BlobsSidecar (524380 B) 111.79 us/op
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2210 us/op
copy serialized Big SignedBeaconBlock (1000000 B) 198.26 us/op
pass gossip attestations to forkchoice per slot 4.8164 ms/op
forkChoice updateHead vc 100000 bc 64 eq 0 710.98 us/op
forkChoice updateHead vc 600000 bc 64 eq 0 5.3032 ms/op
forkChoice updateHead vc 1000000 bc 64 eq 0 7.6334 ms/op
forkChoice updateHead vc 600000 bc 320 eq 0 4.4014 ms/op
forkChoice updateHead vc 600000 bc 1200 eq 0 4.6533 ms/op
forkChoice updateHead vc 600000 bc 7200 eq 0 5.7231 ms/op
forkChoice updateHead vc 600000 bc 64 eq 1000 12.071 ms/op
forkChoice updateHead vc 600000 bc 64 eq 10000 12.670 ms/op
forkChoice updateHead vc 600000 bc 64 eq 300000 17.579 ms/op
computeDeltas 500000 validators 300 proto nodes 6.9407 ms/op
computeDeltas 500000 validators 1200 proto nodes 6.8045 ms/op
computeDeltas 500000 validators 7200 proto nodes 6.6732 ms/op
computeDeltas 750000 validators 300 proto nodes 9.8035 ms/op
computeDeltas 750000 validators 1200 proto nodes 9.8459 ms/op
computeDeltas 750000 validators 7200 proto nodes 9.8453 ms/op
computeDeltas 1400000 validators 300 proto nodes 19.477 ms/op
computeDeltas 1400000 validators 1200 proto nodes 19.781 ms/op
computeDeltas 1400000 validators 7200 proto nodes 19.354 ms/op
computeDeltas 2100000 validators 300 proto nodes 28.620 ms/op
computeDeltas 2100000 validators 1200 proto nodes 28.574 ms/op
computeDeltas 2100000 validators 7200 proto nodes 28.987 ms/op
altair processAttestation - 250000 vs - 7PWei normalcase 2.4644 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 3.8623 ms/op
altair processAttestation - setStatus - 1/6 committees join 211.53 us/op
altair processAttestation - setStatus - 1/3 committees join 374.63 us/op
altair processAttestation - setStatus - 1/2 committees join 561.14 us/op
altair processAttestation - setStatus - 2/3 committees join 688.29 us/op
altair processAttestation - setStatus - 4/5 committees join 893.68 us/op
altair processAttestation - setStatus - 100% committees join 1.0653 ms/op
altair processBlock - 250000 vs - 7PWei normalcase 12.379 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.190 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 46.645 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.121 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 3.1947 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 33.519 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 554.85 us/op
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 17.143 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 78.004 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 35.823 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 22.286 us/op
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 219.71 us/op
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5719 ms/op
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.3456 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.1308 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.8503 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.3733 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.8635 ms/op
Tree 40 250000 create 558.71 ms/op
Tree 40 250000 get(125000) 239.97 ns/op
Tree 40 250000 set(125000) 2.6220 us/op
Tree 40 250000 toArray() 34.737 ms/op
Tree 40 250000 iterate all - toArray() + loop 47.822 ms/op
Tree 40 250000 iterate all - get(i) 124.38 ms/op
MutableVector 250000 create 22.640 ms/op
MutableVector 250000 get(125000) 12.236 ns/op
MutableVector 250000 set(125000) 839.60 ns/op
MutableVector 250000 toArray() 5.9941 ms/op
MutableVector 250000 iterate all - toArray() + loop 6.6279 ms/op
MutableVector 250000 iterate all - get(i) 2.1215 ms/op
Array 250000 create 5.8256 ms/op
Array 250000 clone - spread 6.6269 ms/op
Array 250000 get(125000) 3.2770 ns/op
Array 250000 set(125000) 6.6010 ns/op
Array 250000 iterate all - loop 197.61 us/op
effectiveBalanceIncrements clone Uint8Array 300000 113.44 us/op
effectiveBalanceIncrements clone MutableVector 300000 2.4380 us/op
effectiveBalanceIncrements rw all Uint8Array 300000 393.35 us/op
effectiveBalanceIncrements rw all MutableVector 300000 279.39 ms/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 157.47 ms/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 89.038 ms/op
altair processEpoch - mainnet_e81889 810.70 ms/op
mainnet_e81889 - altair beforeProcessEpoch 151.21 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 34.946 us/op
mainnet_e81889 - altair processInactivityUpdates 13.417 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 101.12 ms/op
mainnet_e81889 - altair processRegistryUpdates 8.9820 us/op
mainnet_e81889 - altair processSlashings 1.5960 us/op
mainnet_e81889 - altair processEth1DataReset 2.1060 us/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.7594 ms/op
mainnet_e81889 - altair processSlashingsReset 10.780 us/op
mainnet_e81889 - altair processRandaoMixesReset 11.974 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 2.0560 us/op
mainnet_e81889 - altair processParticipationFlagUpdates 4.9260 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 1.3050 us/op
mainnet_e81889 - altair afterProcessEpoch 144.26 ms/op
capella processEpoch - mainnet_e217614 2.6135 s/op
mainnet_e217614 - capella beforeProcessEpoch 557.61 ms/op
mainnet_e217614 - capella processJustificationAndFinalization 31.322 us/op
mainnet_e217614 - capella processInactivityUpdates 39.587 ms/op
mainnet_e217614 - capella processRewardsAndPenalties 510.24 ms/op
mainnet_e217614 - capella processRegistryUpdates 48.854 us/op
mainnet_e217614 - capella processSlashings 1.5350 us/op
mainnet_e217614 - capella processEth1DataReset 1.0490 us/op
mainnet_e217614 - capella processEffectiveBalanceUpdates 6.1590 ms/op
mainnet_e217614 - capella processSlashingsReset 8.4660 us/op
mainnet_e217614 - capella processRandaoMixesReset 9.4620 us/op
mainnet_e217614 - capella processHistoricalRootsUpdate 964.00 ns/op
mainnet_e217614 - capella processParticipationFlagUpdates 2.0100 us/op
mainnet_e217614 - capella afterProcessEpoch 341.64 ms/op
phase0 processEpoch - mainnet_e58758 456.11 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 141.18 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 20.313 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 56.480 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 13.923 us/op
mainnet_e58758 - phase0 processSlashings 556.00 ns/op
mainnet_e58758 - phase0 processEth1DataReset 432.00 ns/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3655 ms/op
mainnet_e58758 - phase0 processSlashingsReset 3.4040 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 4.2150 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 413.00 ns/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9320 us/op
mainnet_e58758 - phase0 afterProcessEpoch 100.67 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.5912 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5173 ms/op
altair processInactivityUpdates - 250000 normalcase 28.192 ms/op
altair processInactivityUpdates - 250000 worstcase 23.397 ms/op
phase0 processRegistryUpdates - 250000 normalcase 11.824 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 417.40 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 141.46 ms/op
altair processRewardsAndPenalties - 250000 normalcase 68.179 ms/op
altair processRewardsAndPenalties - 250000 worstcase 66.917 ms/op
phase0 getAttestationDeltas - 250000 normalcase 13.077 ms/op
phase0 getAttestationDeltas - 250000 worstcase 14.431 ms/op
phase0 processSlashings - 250000 worstcase 132.93 us/op
altair processSyncCommitteeUpdates - 250000 197.44 ms/op
BeaconState.hashTreeRoot - No change 988.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 260.89 us/op
BeaconState.hashTreeRoot - 32 full validator 1.9979 ms/op
BeaconState.hashTreeRoot - 512 full validator 22.246 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 264.60 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 3.7547 ms/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 49.048 ms/op
BeaconState.hashTreeRoot - 1 balances 166.19 us/op
BeaconState.hashTreeRoot - 32 balances 1.4255 ms/op
BeaconState.hashTreeRoot - 512 balances 18.154 ms/op
BeaconState.hashTreeRoot - 250000 balances 243.29 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 21.970 us/op
byteArrayEquals 32 79.770 ns/op
Buffer.compare 32 62.062 ns/op
byteArrayEquals 1024 2.6943 us/op
Buffer.compare 1024 80.258 ns/op
byteArrayEquals 16384 42.349 us/op
Buffer.compare 16384 290.71 ns/op
byteArrayEquals 123687377 274.32 ms/op
Buffer.compare 123687377 8.7067 ms/op
byteArrayEquals 32 - diff last byte 82.703 ns/op
Buffer.compare 32 - diff last byte 60.278 ns/op
byteArrayEquals 1024 - diff last byte 2.2300 us/op
Buffer.compare 1024 - diff last byte 81.086 ns/op
byteArrayEquals 16384 - diff last byte 33.801 us/op
Buffer.compare 16384 - diff last byte 267.21 ns/op
byteArrayEquals 123687377 - diff last byte 285.00 ms/op
Buffer.compare 123687377 - diff last byte 20.490 ms/op
byteArrayEquals 32 - random bytes 8.4940 ns/op
Buffer.compare 32 - random bytes 69.560 ns/op
byteArrayEquals 1024 - random bytes 7.1630 ns/op
Buffer.compare 1024 - random bytes 65.497 ns/op
byteArrayEquals 16384 - random bytes 7.5350 ns/op
Buffer.compare 16384 - random bytes 66.745 ns/op
byteArrayEquals 123687377 - random bytes 10.570 ns/op
Buffer.compare 123687377 - random bytes 83.980 ns/op
regular array get 100000 times 51.235 us/op
wrappedArray get 100000 times 50.661 us/op
arrayWithProxy get 100000 times 16.635 ms/op
ssz.Root.equals 60.575 ns/op
byteArrayEquals 59.772 ns/op
Buffer.compare 14.164 ns/op
shuffle list - 16384 els 8.2358 ms/op
shuffle list - 250000 els 117.01 ms/op
processSlot - 1 slots 30.979 us/op
processSlot - 32 slots 5.2534 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 80.520 ms/op
getCommitteeAssignments - req 1 vs - 250000 vc 2.7338 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 3.8804 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5278 ms/op
findModifiedValidators - 10000 modified validators 746.57 ms/op
findModifiedValidators - 1000 modified validators 632.50 ms/op
findModifiedValidators - 100 modified validators 710.18 ms/op
findModifiedValidators - 10 modified validators 540.91 ms/op
findModifiedValidators - 1 modified validators 645.27 ms/op
findModifiedValidators - no difference 614.98 ms/op
compare ViewDUs 5.3424 s/op
compare each validator Uint8Array 1.6985 s/op
compare ViewDU to Uint8Array 1.4515 s/op
migrate state 1000000 validators, 24 modified, 0 new 807.28 ms/op
migrate state 1000000 validators, 1700 modified, 1000 new 1.1758 s/op
migrate state 1000000 validators, 3400 modified, 2000 new 1.5883 s/op
migrate state 1500000 validators, 24 modified, 0 new 1.0852 s/op
migrate state 1500000 validators, 1700 modified, 1000 new 1.3791 s/op
migrate state 1500000 validators, 3400 modified, 2000 new 1.4139 s/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6300 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 720.11 ns/op
computeProposers - vc 250000 9.5304 ms/op
computeEpochShuffling - vc 250000 107.06 ms/op
getNextSyncCommittee - vc 250000 162.82 ms/op
computeSigningRoot for AttestationData 26.067 us/op
hash AttestationData serialized data then Buffer.toString(base64) 2.3316 us/op
toHexString serialized data 1.0758 us/op
Buffer.toString(base64) 227.72 ns/op

by benchmarkbot/action

@philknows philknows marked this pull request as ready for review February 7, 2024 13:00
@philknows philknows requested a review from a team as a code owner February 7, 2024 13:00
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #6379 (fa0954a) into stable (92ed347) will decrease coverage by 0.01%.
Report is 1 commits behind head on stable.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #6379      +/-   ##
==========================================
- Coverage   60.13%   60.13%   -0.01%     
==========================================
  Files         407      407              
  Lines       46451    46460       +9     
  Branches     1534     1537       +3     
==========================================
+ Hits        27935    27940       +5     
- Misses      18486    18490       +4     
  Partials       30       30              

@philknows philknows merged commit 1857a49 into stable Feb 7, 2024
14 of 16 checks passed
@philknows philknows deleted the rc/v1.15.1 branch February 7, 2024 13:39
philknows added a commit that referenced this pull request Feb 7, 2024
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.15.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants