Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve browser support #6384

Merged
merged 3 commits into from
Feb 1, 2024
Merged

chore: improve browser support #6384

merged 3 commits into from
Feb 1, 2024

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Feb 1, 2024

Motivation

Make sure lodestar libs (e.g. light-client) can be loaded in a browser without relying on nodejs shims.
Recent bundler push for not relying on those (e.g. esbuild and vite)

@jeluard jeluard requested a review from a team as a code owner February 1, 2024 13:30
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #6384 (8d88f43) into unstable (8e0078b) will decrease coverage by 0.01%.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6384      +/-   ##
============================================
- Coverage     60.15%   60.15%   -0.01%     
============================================
  Files           407      407              
  Lines         46512    46508       -4     
  Branches       1550     1550              
============================================
- Hits          27981    27977       -4     
  Misses        18499    18499              
  Partials         32       32              

@wemeetagain wemeetagain merged commit 0db50b9 into ChainSafe:unstable Feb 1, 2024
19 of 21 checks passed
@wemeetagain
Copy link
Member

Maybe we should add a linter rule that types should be imported with import type or import {type if possible.

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants