Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update broken links to lodestar docs #6417

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

krauspt
Copy link
Contributor

@krauspt krauspt commented Feb 10, 2024

Motivation

I've found that many of links inside several README.md files are broken.

Description

This PR replaced broken links with working version. Each replaced link was doublechecked to see if works correctly and also maintains the context of original link.

Steps to test or reproduce

No testing required.

@krauspt krauspt requested a review from a team as a code owner February 10, 2024 15:40
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2024

CLA assistant check
All committers have signed the CLA.

philknows
philknows previously approved these changes Feb 10, 2024
Copy link
Member

@philknows philknows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us fix the links! Missed that as we revamped our documentation nav.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Merging #6417 (998e617) into unstable (5c25185) will not change coverage.
The diff coverage is n/a.

❗ Current head 998e617 differs from pull request most recent head ec36476. Consider uploading reports for the commit ec36476 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6417   +/-   ##
=========================================
  Coverage     61.72%   61.72%           
=========================================
  Files           553      553           
  Lines         57856    57856           
  Branches       1829     1829           
=========================================
  Hits          35711    35711           
  Misses        22108    22108           
  Partials         37       37           

README.md Outdated Show resolved Hide resolved
@nflaig nflaig changed the title fix: update broken links to lodestar docs chore: update broken links to lodestar docs Feb 10, 2024
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
@krauspt
Copy link
Contributor Author

krauspt commented Feb 10, 2024

@nflaig I've messed this one. Thanks.

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update @krauspt

@nflaig nflaig enabled auto-merge (squash) February 10, 2024 18:01
@nflaig nflaig merged commit 1e67579 into ChainSafe:unstable Feb 10, 2024
13 of 15 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants