-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: temporarily reduce the sync committee participation limit for sim tests #6433
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6433 +/- ##
=========================================
Coverage 61.70% 61.70%
=========================================
Files 553 553
Lines 57858 57858
Branches 1829 1829
=========================================
Hits 35702 35702
Misses 22119 22119
Partials 37 37 |
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal but better than having sim tests constantly fail
The reference issue with logs are mentioned in the PR. We need to debug and fix the issue separately. For reference this issue is not new and I observed this behavior many times earlier as well. But in multi_fork test because we have 5 nodes, so low participation for 1 or 2 nodes in few slot does not reduce the epoch participation below 90%. In multi-client test we have only 2 nodes, so why this impact a lot in this test. |
Maybe the runner is just overloaded, and some nodes are resource starved? |
🎉 This PR is included in v1.16.0 🎉 |
Motivation
Make the sim tests run more stable.
Description
Related to #6432, can't easily identified what's wrong in sync committee participation. Until we fix that issue following configuration will help to keep the sim tests pass.
Steps to test or reproduce