Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused eslint disable directives #6444

Merged
merged 2 commits into from
Feb 17, 2024
Merged

chore: remove unused eslint disable directives #6444

merged 2 commits into from
Feb 17, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 17, 2024 •
edited
Loading

Motivation

Eslint disable directives are quite noisy and might be confusing if they are unused (related #5046)

Description

  • Remove unused eslint disable directives
  • Update yarn lint to report unused eslint disable directives, this will help us detect unused rules early, for example in the case where a plugin we extend removed a rule, or due to other code changes
  • Clean up unused rules added in #6420, and other related changes

The @typescript-eslint/no-empty-function (see docs) rule seems to have been removed at some point from one of the plugins we extend from. I don't think we should add this rule ourselves as it is not really useful and just causes noise.

@nflaig nflaig requested a review from a team as a code owner February 17, 2024 10:18
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Merging #6444 (bdf2535) into unstable (227930c) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6444      +/-   ##
============================================
- Coverage     61.71%   61.70%   -0.01%     
============================================
  Files           553      553              
  Lines         57866    57854      -12     
  Branches       1829     1829              
============================================
- Hits          35710    35700      -10     
+ Misses        22119    22117       -2     
  Partials         37       37

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: d400795 Previous: 227930c Ratio
forkChoice updateHead vc 600000 bc 64 eq 300000 15.641 ms/op 49.068 ms/op 0.32
Full benchmark results
Benchmark suite Current: d400795 Previous: 227930c Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 913.78 us/op 1.0117 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 91.717 us/op 136.42 us/op 0.67
BLS verify - blst-native 1.2637 ms/op 1.4219 ms/op 0.89
BLS verifyMultipleSignatures 3 - blst-native 2.6538 ms/op 3.2112 ms/op 0.83
BLS verifyMultipleSignatures 8 - blst-native 5.8511 ms/op 6.5660 ms/op 0.89
BLS verifyMultipleSignatures 32 - blst-native 21.319 ms/op 23.979 ms/op 0.89
BLS verifyMultipleSignatures 64 - blst-native 41.970 ms/op 49.038 ms/op 0.86
BLS verifyMultipleSignatures 128 - blst-native 83.196 ms/op 92.836 ms/op 0.90
BLS deserializing 10000 signatures 916.80 ms/op 1.0304 s/op 0.89
BLS deserializing 100000 signatures 9.1541 s/op 9.7190 s/op 0.94
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.2756 ms/op 1.4825 ms/op 0.86
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4410 ms/op 1.6369 ms/op 0.88
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.2316 ms/op 2.4798 ms/op 0.90
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.4854 ms/op 3.6889 ms/op 1.22
BLS verifyMultipleSignatures - same message - 128 - blst-native 9.5380 ms/op 5.9955 ms/op 1.59
BLS aggregatePubkeys 32 - blst-native 24.877 us/op 27.449 us/op 0.91
BLS aggregatePubkeys 128 - blst-native 94.197 us/op 105.59 us/op 0.89
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 54.295 ms/op 67.411 ms/op 0.81
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 56.054 ms/op 62.800 ms/op 0.89
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 33.339 ms/op 50.269 ms/op 0.66
getSlashingsAndExits - default max 211.60 us/op 486.86 us/op 0.43
getSlashingsAndExits - 2k 439.12 us/op 802.26 us/op 0.55
proposeBlockBody type=full, size=empty 5.6692 ms/op 7.3752 ms/op 0.77
isKnown best case - 1 super set check 304.00 ns/op 708.00 ns/op 0.43
isKnown normal case - 2 super set checks 301.00 ns/op 786.00 ns/op 0.38
isKnown worse case - 16 super set checks 296.00 ns/op 776.00 ns/op 0.38
CheckpointStateCache - add get delete 5.6620 us/op 6.9340 us/op 0.82
validate api signedAggregateAndProof - struct 2.7880 ms/op 2.9611 ms/op 0.94
validate gossip signedAggregateAndProof - struct 2.7528 ms/op 3.0849 ms/op 0.89
validate gossip attestation - vc 640000 1.3247 ms/op 1.5317 ms/op 0.86
batch validate gossip attestation - vc 640000 - chunk 32 158.16 us/op 196.53 us/op 0.80
batch validate gossip attestation - vc 640000 - chunk 64 141.91 us/op 182.15 us/op 0.78
batch validate gossip attestation - vc 640000 - chunk 128 129.79 us/op 181.33 us/op 0.72
batch validate gossip attestation - vc 640000 - chunk 256 129.70 us/op 176.50 us/op 0.73
pickEth1Vote - no votes 1.1119 ms/op 1.7401 ms/op 0.64
pickEth1Vote - max votes 10.769 ms/op 20.140 ms/op 0.53
pickEth1Vote - Eth1Data hashTreeRoot value x2048 19.162 ms/op 26.402 ms/op 0.73
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 39.403 ms/op 41.441 ms/op 0.95
pickEth1Vote - Eth1Data fastSerialize value x2048 589.60 us/op 841.77 us/op 0.70
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.3182 ms/op 9.5507 ms/op 0.66
bytes32 toHexString 483.00 ns/op 921.00 ns/op 0.52
bytes32 Buffer.toString(hex) 285.00 ns/op 392.00 ns/op 0.73
bytes32 Buffer.toString(hex) from Uint8Array 402.00 ns/op 676.00 ns/op 0.59
bytes32 Buffer.toString(hex) + 0x 283.00 ns/op 348.00 ns/op 0.81
Object access 1 prop 0.15700 ns/op 0.28500 ns/op 0.55
Map access 1 prop 0.15200 ns/op 0.16900 ns/op 0.90
Object get x1000 7.1870 ns/op 8.6990 ns/op 0.83
Map get x1000 0.72300 ns/op 1.0550 ns/op 0.69
Object set x1000 48.209 ns/op 89.216 ns/op 0.54
Map set x1000 38.118 ns/op 64.122 ns/op 0.59
Return object 10000 times 0.22990 ns/op 0.31280 ns/op 0.73
Throw Error 10000 times 3.7661 us/op 4.2594 us/op 0.88
fastMsgIdFn sha256 / 200 bytes 3.1760 us/op 4.0450 us/op 0.79
fastMsgIdFn h32 xxhash / 200 bytes 264.00 ns/op 414.00 ns/op 0.64
fastMsgIdFn h64 xxhash / 200 bytes 342.00 ns/op 457.00 ns/op 0.75
fastMsgIdFn sha256 / 1000 bytes 11.119 us/op 12.897 us/op 0.86
fastMsgIdFn h32 xxhash / 1000 bytes 398.00 ns/op 608.00 ns/op 0.65
fastMsgIdFn h64 xxhash / 1000 bytes 422.00 ns/op 517.00 ns/op 0.82
fastMsgIdFn sha256 / 10000 bytes 101.24 us/op 111.70 us/op 0.91
fastMsgIdFn h32 xxhash / 10000 bytes 1.8730 us/op 2.2330 us/op 0.84
fastMsgIdFn h64 xxhash / 10000 bytes 1.2990 us/op 1.6390 us/op 0.79
send data - 1000 256B messages 17.422 ms/op 32.397 ms/op 0.54
send data - 1000 512B messages 24.802 ms/op 33.982 ms/op 0.73
send data - 1000 1024B messages 39.786 ms/op 50.773 ms/op 0.78
send data - 1000 1200B messages 39.367 ms/op 47.343 ms/op 0.83
send data - 1000 2048B messages 48.881 ms/op 55.852 ms/op 0.88
send data - 1000 4096B messages 44.613 ms/op 46.471 ms/op 0.96
send data - 1000 16384B messages 119.73 ms/op 130.62 ms/op 0.92
send data - 1000 65536B messages 515.59 ms/op 518.29 ms/op 0.99
enrSubnets - fastDeserialize 64 bits 1.2110 us/op 1.6110 us/op 0.75
enrSubnets - ssz BitVector 64 bits 417.00 ns/op 610.00 ns/op 0.68
enrSubnets - fastDeserialize 4 bits 171.00 ns/op 273.00 ns/op 0.63
enrSubnets - ssz BitVector 4 bits 421.00 ns/op 655.00 ns/op 0.64
prioritizePeers score -10:0 att 32-0.1 sync 2-0 99.880 us/op 141.40 us/op 0.71
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 123.82 us/op 185.49 us/op 0.67
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 159.66 us/op 213.48 us/op 0.75
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 283.70 us/op 387.34 us/op 0.73
prioritizePeers score 0:0 att 64-1 sync 4-1 327.03 us/op 430.06 us/op 0.76
array of 16000 items push then shift 1.5723 us/op 1.9550 us/op 0.80
LinkedList of 16000 items push then shift 8.6750 ns/op 11.705 ns/op 0.74
array of 16000 items push then pop 70.836 ns/op 132.00 ns/op 0.54
LinkedList of 16000 items push then pop 8.2050 ns/op 10.997 ns/op 0.75
array of 24000 items push then shift 2.3505 us/op 2.8998 us/op 0.81
LinkedList of 24000 items push then shift 8.9920 ns/op 12.113 ns/op 0.74
array of 24000 items push then pop 92.978 ns/op 205.92 ns/op 0.45
LinkedList of 24000 items push then pop 8.5640 ns/op 10.917 ns/op 0.78
intersect bitArray bitLen 8 5.6680 ns/op 7.0000 ns/op 0.81
intersect array and set length 8 59.080 ns/op 107.12 ns/op 0.55
intersect bitArray bitLen 128 33.270 ns/op 40.497 ns/op 0.82
intersect array and set length 128 830.26 ns/op 1.1866 us/op 0.70
bitArray.getTrueBitIndexes() bitLen 128 1.5610 us/op 2.0990 us/op 0.74
bitArray.getTrueBitIndexes() bitLen 248 2.4340 us/op 3.1630 us/op 0.77
bitArray.getTrueBitIndexes() bitLen 512 4.7690 us/op 7.0160 us/op 0.68
Buffer.concat 32 items 1.1450 us/op 1.1690 us/op 0.98
Uint8Array.set 32 items 2.0060 us/op 2.2320 us/op 0.90
Set add up to 64 items then delete first 4.3161 us/op 5.3966 us/op 0.80
OrderedSet add up to 64 items then delete first 5.3488 us/op 6.7994 us/op 0.79
Set add up to 64 items then delete last 4.5926 us/op 6.0971 us/op 0.75
OrderedSet add up to 64 items then delete last 5.7824 us/op 8.1319 us/op 0.71
Set add up to 64 items then delete middle 4.7011 us/op 5.8901 us/op 0.80
OrderedSet add up to 64 items then delete middle 7.4720 us/op 8.1676 us/op 0.91
Set add up to 128 items then delete first 9.9254 us/op 11.581 us/op 0.86
OrderedSet add up to 128 items then delete first 12.692 us/op 15.291 us/op 0.83
Set add up to 128 items then delete last 9.0768 us/op 11.023 us/op 0.82
OrderedSet add up to 128 items then delete last 11.598 us/op 13.818 us/op 0.84
Set add up to 128 items then delete middle 8.9090 us/op 10.958 us/op 0.81
OrderedSet add up to 128 items then delete middle 16.598 us/op 20.345 us/op 0.82
Set add up to 256 items then delete first 18.637 us/op 22.468 us/op 0.83
OrderedSet add up to 256 items then delete first 24.715 us/op 31.975 us/op 0.77
Set add up to 256 items then delete last 17.792 us/op 22.674 us/op 0.78
OrderedSet add up to 256 items then delete last 22.610 us/op 29.700 us/op 0.76
Set add up to 256 items then delete middle 18.823 us/op 22.381 us/op 0.84
OrderedSet add up to 256 items then delete middle 44.971 us/op 55.612 us/op 0.81
transfer serialized Status (84 B) 1.7070 us/op 1.9720 us/op 0.87
copy serialized Status (84 B) 1.3570 us/op 1.5370 us/op 0.88
transfer serialized SignedVoluntaryExit (112 B) 1.9590 us/op 2.2860 us/op 0.86
copy serialized SignedVoluntaryExit (112 B) 1.3160 us/op 1.5960 us/op 0.82
transfer serialized ProposerSlashing (416 B) 2.4660 us/op 2.6750 us/op 0.92
copy serialized ProposerSlashing (416 B) 1.9810 us/op 2.4580 us/op 0.81
transfer serialized Attestation (485 B) 2.4580 us/op 2.6040 us/op 0.94
copy serialized Attestation (485 B) 2.0400 us/op 2.6120 us/op 0.78
transfer serialized AttesterSlashing (33232 B) 2.5650 us/op 3.4130 us/op 0.75
copy serialized AttesterSlashing (33232 B) 5.5240 us/op 10.136 us/op 0.54
transfer serialized Small SignedBeaconBlock (128000 B) 2.8780 us/op 3.2670 us/op 0.88
copy serialized Small SignedBeaconBlock (128000 B) 13.047 us/op 32.647 us/op 0.40
transfer serialized Avg SignedBeaconBlock (200000 B) 3.7090 us/op 4.1130 us/op 0.90
copy serialized Avg SignedBeaconBlock (200000 B) 32.178 us/op 39.214 us/op 0.82
transfer serialized BlobsSidecar (524380 B) 3.6280 us/op 4.6640 us/op 0.78
copy serialized BlobsSidecar (524380 B) 81.738 us/op 233.66 us/op 0.35
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2210 us/op 4.7190 us/op 0.68
copy serialized Big SignedBeaconBlock (1000000 B) 158.06 us/op 217.08 us/op 0.73
pass gossip attestations to forkchoice per slot 4.1963 ms/op 4.5448 ms/op 0.92
forkChoice updateHead vc 100000 bc 64 eq 0 685.32 us/op 744.30 us/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 0 4.2958 ms/op 5.0857 ms/op 0.84
forkChoice updateHead vc 1000000 bc 64 eq 0 6.9785 ms/op 7.9006 ms/op 0.88
forkChoice updateHead vc 600000 bc 320 eq 0 4.1695 ms/op 4.5976 ms/op 0.91
forkChoice updateHead vc 600000 bc 1200 eq 0 4.3355 ms/op 4.5982 ms/op 0.94
forkChoice updateHead vc 600000 bc 7200 eq 0 5.3014 ms/op 6.8546 ms/op 0.77
forkChoice updateHead vc 600000 bc 64 eq 1000 11.185 ms/op 13.928 ms/op 0.80
forkChoice updateHead vc 600000 bc 64 eq 10000 11.787 ms/op 15.851 ms/op 0.74
forkChoice updateHead vc 600000 bc 64 eq 300000 15.641 ms/op 49.068 ms/op 0.32
computeDeltas 500000 validators 300 proto nodes 6.5501 ms/op 7.9361 ms/op 0.83
computeDeltas 500000 validators 1200 proto nodes 6.3899 ms/op 7.5440 ms/op 0.85
computeDeltas 500000 validators 7200 proto nodes 6.4062 ms/op 7.2509 ms/op 0.88
computeDeltas 750000 validators 300 proto nodes 11.448 ms/op 11.236 ms/op 1.02
computeDeltas 750000 validators 1200 proto nodes 9.7616 ms/op 11.031 ms/op 0.88
computeDeltas 750000 validators 7200 proto nodes 9.4626 ms/op 10.969 ms/op 0.86
computeDeltas 1400000 validators 300 proto nodes 18.200 ms/op 21.312 ms/op 0.85
computeDeltas 1400000 validators 1200 proto nodes 18.789 ms/op 20.836 ms/op 0.90
computeDeltas 1400000 validators 7200 proto nodes 18.480 ms/op 21.175 ms/op 0.87
computeDeltas 2100000 validators 300 proto nodes 27.264 ms/op 32.506 ms/op 0.84
computeDeltas 2100000 validators 1200 proto nodes 27.668 ms/op 32.572 ms/op 0.85
computeDeltas 2100000 validators 7200 proto nodes 27.498 ms/op 31.153 ms/op 0.88
altair processAttestation - 250000 vs - 7PWei normalcase 2.2872 ms/op 3.5656 ms/op 0.64
altair processAttestation - 250000 vs - 7PWei worstcase 3.1074 ms/op 4.3790 ms/op 0.71
altair processAttestation - setStatus - 1/6 committees join 151.52 us/op 210.14 us/op 0.72
altair processAttestation - setStatus - 1/3 committees join 288.51 us/op 418.48 us/op 0.69
altair processAttestation - setStatus - 1/2 committees join 409.88 us/op 607.58 us/op 0.67
altair processAttestation - setStatus - 2/3 committees join 527.86 us/op 658.53 us/op 0.80
altair processAttestation - setStatus - 4/5 committees join 634.95 us/op 867.83 us/op 0.73
altair processAttestation - setStatus - 100% committees join 770.01 us/op 1.1618 ms/op 0.66
altair processBlock - 250000 vs - 7PWei normalcase 10.504 ms/op 12.251 ms/op 0.86
altair processBlock - 250000 vs - 7PWei normalcase hashState 40.803 ms/op 43.140 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 40.301 ms/op 55.086 ms/op 0.73
altair processBlock - 250000 vs - 7PWei worstcase hashState 100.06 ms/op 119.99 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei normalcase 3.0470 ms/op 4.5720 ms/op 0.67
phase0 processBlock - 250000 vs - 7PWei worstcase 33.966 ms/op 41.969 ms/op 0.81
altair processEth1Data - 250000 vs - 7PWei normalcase 695.55 us/op 1.0257 ms/op 0.68
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 18.295 us/op 25.750 us/op 0.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 90.766 us/op 115.83 us/op 0.78
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 23.059 us/op 35.327 us/op 0.65
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 13.417 us/op 24.422 us/op 0.55
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 243.45 us/op 254.43 us/op 0.96
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 2.0323 ms/op 1.9892 ms/op 1.02
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.9273 ms/op 3.0561 ms/op 0.96
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.8306 ms/op 2.6452 ms/op 1.07
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.8394 ms/op 5.3250 ms/op 0.72
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.0789 ms/op 3.2228 ms/op 0.65
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.1071 ms/op 7.9376 ms/op 0.64
Tree 40 250000 create 338.64 ms/op 609.89 ms/op 0.56
Tree 40 250000 get(125000) 191.84 ns/op 222.74 ns/op 0.86
Tree 40 250000 set(125000) 980.00 ns/op 1.3830 us/op 0.71
Tree 40 250000 toArray() 18.281 ms/op 27.791 ms/op 0.66
Tree 40 250000 iterate all - toArray() + loop 18.475 ms/op 27.758 ms/op 0.67
Tree 40 250000 iterate all - get(i) 64.047 ms/op 81.940 ms/op 0.78
MutableVector 250000 create 18.267 ms/op 19.120 ms/op 0.96
MutableVector 250000 get(125000) 6.2340 ns/op 7.2450 ns/op 0.86
MutableVector 250000 set(125000) 256.60 ns/op 402.42 ns/op 0.64
MutableVector 250000 toArray() 3.5147 ms/op 5.3331 ms/op 0.66
MutableVector 250000 iterate all - toArray() + loop 3.3392 ms/op 5.9040 ms/op 0.57
MutableVector 250000 iterate all - get(i) 1.4797 ms/op 1.6845 ms/op 0.88
Array 250000 create 2.8884 ms/op 4.6283 ms/op 0.62
Array 250000 clone - spread 1.3131 ms/op 1.5734 ms/op 0.83
Array 250000 get(125000) 1.0530 ns/op 1.7370 ns/op 0.61
Array 250000 set(125000) 4.0160 ns/op 6.1340 ns/op 0.65
Array 250000 iterate all - loop 161.32 us/op 181.10 us/op 0.89
effectiveBalanceIncrements clone Uint8Array 300000 29.849 us/op 88.374 us/op 0.34
effectiveBalanceIncrements clone MutableVector 300000 399.00 ns/op 587.00 ns/op 0.68
effectiveBalanceIncrements rw all Uint8Array 300000 193.92 us/op 221.40 us/op 0.88
effectiveBalanceIncrements rw all MutableVector 300000 84.116 ms/op 126.59 ms/op 0.66
phase0 afterProcessEpoch - 250000 vs - 7PWei 108.87 ms/op 126.58 ms/op 0.86
phase0 beforeProcessEpoch - 250000 vs - 7PWei 54.310 ms/op 79.115 ms/op 0.69
altair processEpoch - mainnet_e81889 497.31 ms/op 575.31 ms/op 0.86
mainnet_e81889 - altair beforeProcessEpoch 84.700 ms/op 102.46 ms/op 0.83
mainnet_e81889 - altair processJustificationAndFinalization 22.767 us/op 19.284 us/op 1.18
mainnet_e81889 - altair processInactivityUpdates 6.2637 ms/op 6.7493 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 79.039 ms/op 73.525 ms/op 1.07
mainnet_e81889 - altair processRegistryUpdates 3.8060 us/op 2.4670 us/op 1.54
mainnet_e81889 - altair processSlashings 867.00 ns/op 441.00 ns/op 1.97
mainnet_e81889 - altair processEth1DataReset 618.00 ns/op 557.00 ns/op 1.11
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.6582 ms/op 1.7409 ms/op 1.53
mainnet_e81889 - altair processSlashingsReset 5.8720 us/op 6.1210 us/op 0.96
mainnet_e81889 - altair processRandaoMixesReset 7.4230 us/op 6.0700 us/op 1.22
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0360 us/op 695.00 ns/op 1.49
mainnet_e81889 - altair processParticipationFlagUpdates 2.2660 us/op 2.2470 us/op 1.01
mainnet_e81889 - altair processSyncCommitteeUpdates 704.00 ns/op 731.00 ns/op 0.96
mainnet_e81889 - altair afterProcessEpoch 116.17 ms/op 126.84 ms/op 0.92
capella processEpoch - mainnet_e217614 2.2606 s/op 2.3811 s/op 0.95
mainnet_e217614 - capella beforeProcessEpoch 515.77 ms/op 522.05 ms/op 0.99
mainnet_e217614 - capella processJustificationAndFinalization 28.054 us/op 20.474 us/op 1.37
mainnet_e217614 - capella processInactivityUpdates 16.817 ms/op 23.739 ms/op 0.71
mainnet_e217614 - capella processRewardsAndPenalties 440.64 ms/op 434.82 ms/op 1.01
mainnet_e217614 - capella processRegistryUpdates 26.080 us/op 41.079 us/op 0.63
mainnet_e217614 - capella processSlashings 904.00 ns/op 892.00 ns/op 1.01
mainnet_e217614 - capella processEth1DataReset 658.00 ns/op 949.00 ns/op 0.69
mainnet_e217614 - capella processEffectiveBalanceUpdates 7.5193 ms/op 6.1673 ms/op 1.22
mainnet_e217614 - capella processSlashingsReset 5.5910 us/op 6.2760 us/op 0.89
mainnet_e217614 - capella processRandaoMixesReset 7.2450 us/op 8.7500 us/op 0.83
mainnet_e217614 - capella processHistoricalRootsUpdate 965.00 ns/op 658.00 ns/op 1.47
mainnet_e217614 - capella processParticipationFlagUpdates 2.8380 us/op 6.2540 us/op 0.45
mainnet_e217614 - capella afterProcessEpoch 288.43 ms/op 379.09 ms/op 0.76
phase0 processEpoch - mainnet_e58758 493.04 ms/op 596.73 ms/op 0.83
mainnet_e58758 - phase0 beforeProcessEpoch 156.86 ms/op 180.70 ms/op 0.87
mainnet_e58758 - phase0 processJustificationAndFinalization 23.300 us/op 41.516 us/op 0.56
mainnet_e58758 - phase0 processRewardsAndPenalties 69.731 ms/op 68.859 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 14.126 us/op 13.185 us/op 1.07
mainnet_e58758 - phase0 processSlashings 948.00 ns/op 783.00 ns/op 1.21
mainnet_e58758 - phase0 processEth1DataReset 664.00 ns/op 888.00 ns/op 0.75
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1670 ms/op 1.4416 ms/op 1.50
mainnet_e58758 - phase0 processSlashingsReset 4.7520 us/op 5.4630 us/op 0.87
mainnet_e58758 - phase0 processRandaoMixesReset 6.2380 us/op 7.5400 us/op 0.83
mainnet_e58758 - phase0 processHistoricalRootsUpdate 927.00 ns/op 1.0240 us/op 0.91
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.9530 us/op 5.7320 us/op 1.04
mainnet_e58758 - phase0 afterProcessEpoch 89.060 ms/op 106.43 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9657 ms/op 1.8588 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.6039 ms/op 2.0565 ms/op 1.27
altair processInactivityUpdates - 250000 normalcase 30.668 ms/op 39.905 ms/op 0.77
altair processInactivityUpdates - 250000 worstcase 35.174 ms/op 35.561 ms/op 0.99
phase0 processRegistryUpdates - 250000 normalcase 14.704 us/op 20.164 us/op 0.73
phase0 processRegistryUpdates - 250000 badcase_full_deposits 745.21 us/op 522.89 us/op 1.43
phase0 processRegistryUpdates - 250000 worstcase 0.5 151.69 ms/op 153.44 ms/op 0.99
altair processRewardsAndPenalties - 250000 normalcase 67.084 ms/op 58.780 ms/op 1.14
altair processRewardsAndPenalties - 250000 worstcase 66.976 ms/op 66.227 ms/op 1.01
phase0 getAttestationDeltas - 250000 normalcase 8.8115 ms/op 9.4895 ms/op 0.93
phase0 getAttestationDeltas - 250000 worstcase 8.6749 ms/op 13.058 ms/op 0.66
phase0 processSlashings - 250000 worstcase 126.50 us/op 114.00 us/op 1.11
altair processSyncCommitteeUpdates - 250000 144.88 ms/op 176.56 ms/op 0.82
BeaconState.hashTreeRoot - No change 362.00 ns/op 871.00 ns/op 0.42
BeaconState.hashTreeRoot - 1 full validator 155.32 us/op 177.54 us/op 0.87
BeaconState.hashTreeRoot - 32 full validator 1.4594 ms/op 1.8706 ms/op 0.78
BeaconState.hashTreeRoot - 512 full validator 16.640 ms/op 22.158 ms/op 0.75
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 183.53 us/op 231.57 us/op 0.79
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2082 ms/op 3.2077 ms/op 0.69
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 31.354 ms/op 35.881 ms/op 0.87
BeaconState.hashTreeRoot - 1 balances 135.16 us/op 170.72 us/op 0.79
BeaconState.hashTreeRoot - 32 balances 1.2588 ms/op 1.2713 ms/op 0.99
BeaconState.hashTreeRoot - 512 balances 12.263 ms/op 13.646 ms/op 0.90
BeaconState.hashTreeRoot - 250000 balances 244.90 ms/op 276.46 ms/op 0.89
aggregationBits - 2048 els - zipIndexesInBitList 16.450 us/op 31.704 us/op 0.52
byteArrayEquals 32 74.207 ns/op 80.941 ns/op 0.92
Buffer.compare 32 54.406 ns/op 60.732 ns/op 0.90
byteArrayEquals 1024 2.0009 us/op 2.2312 us/op 0.90
Buffer.compare 1024 68.345 ns/op 78.403 ns/op 0.87
byteArrayEquals 16384 31.888 us/op 35.899 us/op 0.89
Buffer.compare 16384 266.38 ns/op 296.92 ns/op 0.90
byteArrayEquals 123687377 241.90 ms/op 260.80 ms/op 0.93
Buffer.compare 123687377 6.1199 ms/op 8.2623 ms/op 0.74
byteArrayEquals 32 - diff last byte 71.450 ns/op 85.091 ns/op 0.84
Buffer.compare 32 - diff last byte 55.675 ns/op 63.052 ns/op 0.88
byteArrayEquals 1024 - diff last byte 2.0216 us/op 2.2032 us/op 0.92
Buffer.compare 1024 - diff last byte 71.276 ns/op 79.491 ns/op 0.90
byteArrayEquals 16384 - diff last byte 32.244 us/op 35.754 us/op 0.90
Buffer.compare 16384 - diff last byte 252.60 ns/op 288.46 ns/op 0.88
byteArrayEquals 123687377 - diff last byte 233.41 ms/op 256.10 ms/op 0.91
Buffer.compare 123687377 - diff last byte 6.1740 ms/op 8.1832 ms/op 0.75
byteArrayEquals 32 - random bytes 5.3010 ns/op 6.4380 ns/op 0.82
Buffer.compare 32 - random bytes 59.815 ns/op 64.724 ns/op 0.92
byteArrayEquals 1024 - random bytes 5.0590 ns/op 6.9100 ns/op 0.73
Buffer.compare 1024 - random bytes 59.474 ns/op 64.584 ns/op 0.92
byteArrayEquals 16384 - random bytes 5.0760 ns/op 6.0030 ns/op 0.85
Buffer.compare 16384 - random bytes 59.340 ns/op 64.148 ns/op 0.93
byteArrayEquals 123687377 - random bytes 8.4500 ns/op 9.8700 ns/op 0.86
Buffer.compare 123687377 - random bytes 62.760 ns/op 84.300 ns/op 0.74
regular array get 100000 times 42.914 us/op 49.205 us/op 0.87
wrappedArray get 100000 times 42.935 us/op 47.809 us/op 0.90
arrayWithProxy get 100000 times 13.405 ms/op 17.588 ms/op 0.76
ssz.Root.equals 51.617 ns/op 56.332 ns/op 0.92
byteArrayEquals 50.874 ns/op 55.081 ns/op 0.92
Buffer.compare 10.480 ns/op 12.408 ns/op 0.84
shuffle list - 16384 els 6.8447 ms/op 7.6323 ms/op 0.90
shuffle list - 250000 els 100.09 ms/op 112.58 ms/op 0.89
processSlot - 1 slots 21.248 us/op 17.090 us/op 1.24
processSlot - 32 slots 4.3978 ms/op 3.4610 ms/op 1.27
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 63.047 ms/op 64.926 ms/op 0.97
getCommitteeAssignments - req 1 vs - 250000 vc 2.4289 ms/op 2.6126 ms/op 0.93
getCommitteeAssignments - req 100 vs - 250000 vc 3.7063 ms/op 3.8703 ms/op 0.96
getCommitteeAssignments - req 1000 vs - 250000 vc 3.8830 ms/op 4.2876 ms/op 0.91
findModifiedValidators - 10000 modified validators 544.85 ms/op 562.21 ms/op 0.97
findModifiedValidators - 1000 modified validators 421.74 ms/op 457.61 ms/op 0.92
findModifiedValidators - 100 modified validators 417.57 ms/op 417.03 ms/op 1.00
findModifiedValidators - 10 modified validators 424.26 ms/op 460.25 ms/op 0.92
findModifiedValidators - 1 modified validators 407.30 ms/op 450.56 ms/op 0.90
findModifiedValidators - no difference 393.85 ms/op 459.45 ms/op 0.86
compare ViewDUs 5.0461 s/op 5.0228 s/op 1.00
compare each validator Uint8Array 1.4760 s/op 2.0036 s/op 0.74
compare ViewDU to Uint8Array 1.1018 s/op 1.6241 s/op 0.68
migrate state 1000000 validators, 24 modified, 0 new 895.03 ms/op 961.31 ms/op 0.93
migrate state 1000000 validators, 1700 modified, 1000 new 1.2104 s/op 1.3263 s/op 0.91
migrate state 1000000 validators, 3400 modified, 2000 new 1.4729 s/op 1.4220 s/op 1.04
migrate state 1500000 validators, 24 modified, 0 new 874.17 ms/op 969.95 ms/op 0.90
migrate state 1500000 validators, 1700 modified, 1000 new 1.1298 s/op 1.2874 s/op 0.88
migrate state 1500000 validators, 3400 modified, 2000 new 1.3019 s/op 1.7338 s/op 0.75
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5600 ns/op 6.0100 ns/op 0.76
state getBlockRootAtSlot - 250000 vs - 7PWei 606.36 ns/op 929.36 ns/op 0.65
computeProposers - vc 250000 9.3718 ms/op 15.058 ms/op 0.62
computeEpochShuffling - vc 250000 103.50 ms/op 139.24 ms/op 0.74
getNextSyncCommittee - vc 250000 153.81 ms/op 221.81 ms/op 0.69
computeSigningRoot for AttestationData 30.758 us/op 36.265 us/op 0.85
hash AttestationData serialized data then Buffer.toString(base64) 2.3041 us/op 2.6570 us/op 0.87
toHexString serialized data 1.0598 us/op 2.0912 us/op 0.51
Buffer.toString(base64) 224.07 ns/op 313.21 ns/op 0.72

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 1943346 into unstable Feb 17, 2024
20 of 22 checks passed
@wemeetagain wemeetagain deleted the nflaig/remove-unused-disable-directives branch February 17, 2024 14:22
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@nazarhussain nazarhussain Awaiting requested review from nazarhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain