-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: arm64 binaries creation issue #6857
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6857 +/- ##
=========================================
Coverage 62.19% 62.20%
=========================================
Files 571 571
Lines 60021 60021
Branches 1973 1979 +6
=========================================
+ Hits 37333 37334 +1
+ Misses 22645 22644 -1
Partials 43 43 |
@@ -39,7 +39,7 @@ jobs: | |||
echo "$HOME/bin" >> $GITHUB_PATH | |||
# Install missing build-essential | |||
sudo apt-get update | |||
sudo apt-get install -y build-essential | |||
sudo apt-get install -y build-essential python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an issue with the runner or the node action? we might wanna pin the version to not randomly having binary builds fail (if possible at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be a limitation of the runner, currently in beta. Not clear yet that it solves the issue.
Performance Report✔️ no performance regression detected Full benchmark results
|
Replaced by #6858 |
Motivation
Fix
binaries
workflow forarm64